You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by mi...@apache.org on 2014/09/14 10:18:35 UTC

svn commit: r1624805 - /lucene/dev/branches/lucene_solr_4_10/lucene/core/src/java/org/apache/lucene/codecs/lucene46/Lucene46SegmentInfoWriter.java

Author: mikemccand
Date: Sun Sep 14 08:18:35 2014
New Revision: 1624805

URL: http://svn.apache.org/r1624805
Log:
detect invalid major version when writing .si

Modified:
    lucene/dev/branches/lucene_solr_4_10/lucene/core/src/java/org/apache/lucene/codecs/lucene46/Lucene46SegmentInfoWriter.java

Modified: lucene/dev/branches/lucene_solr_4_10/lucene/core/src/java/org/apache/lucene/codecs/lucene46/Lucene46SegmentInfoWriter.java
URL: http://svn.apache.org/viewvc/lucene/dev/branches/lucene_solr_4_10/lucene/core/src/java/org/apache/lucene/codecs/lucene46/Lucene46SegmentInfoWriter.java?rev=1624805&r1=1624804&r2=1624805&view=diff
==============================================================================
--- lucene/dev/branches/lucene_solr_4_10/lucene/core/src/java/org/apache/lucene/codecs/lucene46/Lucene46SegmentInfoWriter.java (original)
+++ lucene/dev/branches/lucene_solr_4_10/lucene/core/src/java/org/apache/lucene/codecs/lucene46/Lucene46SegmentInfoWriter.java Sun Sep 14 08:18:35 2014
@@ -54,10 +54,8 @@ public class Lucene46SegmentInfoWriter e
     try {
       CodecUtil.writeHeader(output, Lucene46SegmentInfoFormat.CODEC_NAME, Lucene46SegmentInfoFormat.VERSION_CURRENT);
       Version version = si.getVersion();
-      String versionString = version.toString();
-      if (versionString.startsWith("3.") == false &&
-          versionString.startsWith("4.") == false) {
-        throw new IllegalArgumentException("invalid major version: should be 3 or 4 but got: " + version + " segment=" + si);
+      if (version.major < 3 || version.major > 4) {
+        throw new IllegalArgumentException("invalid major version: should be 3 or 4 but got: " + version.major + " segment=" + si);
       }
       // Write the Lucene version that created this segment, since 3.1
       output.writeString(version.toString());