[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #6567: GEODE-9070: Improve ClientServerSessionCacheDUnitTest and add additional logging

[GitBox <gi...@apache.org>]

jdeppe-pivotal commented on a change in pull request #6567:
URL: https://github.com/apache/geode/pull/6567#discussion_r649334702



##########
File path: geode-core/src/main/java/org/apache/geode/distributed/internal/ClusterDistributionManager.java
##########
@@ -1082,7 +1082,16 @@ public InternalDistributedMember getId() {
       if (observer != null) {
         observer.beforeSendMessage(this, msg);
       }
-      return sendMessage(msg);
+      Set<InternalDistributedMember> membersNotSent = sendMessage(msg);
+
+      if (membersNotSent != null && !membersNotSent.isEmpty()) {
+        logger.warn(
+            "The following members: {} were not properly sent the message: {}. If unhandled this may"
+                + " cause the result processor to hang while collecting results.",
+            membersNotSent, msg.getShortClassName());
+      }
+
+      return membersNotSent;

Review comment:
       The log message states - `If unhandled...` what does it then mean to 'handle' the situation? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org