You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/06/21 13:42:35 UTC
[GitHub] [kafka] badaiaqrandista opened a new pull request #8909: KAFKA-6733: Support of printing additional ConsumerRecord fields in DefaultMessageFormatter (rebased)
badaiaqrandista opened a new pull request #8909:
URL: https://github.com/apache/kafka/pull/8909
See KIP-431: https://cwiki.apache.org/confluence/display/KAFKA/KIP-431%3A+Support+of+printing+additional+ConsumerRecord+fields+in+DefaultMessageFormatter
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] badaiaqrandista commented on pull request #8909: KAFKA-6733: Support of printing additional ConsumerRecord fields in DefaultMessageFormatter (rebased)
Posted by GitBox <gi...@apache.org>.
badaiaqrandista commented on pull request #8909:
URL: https://github.com/apache/kafka/pull/8909#issuecomment-662316482
I think I've corrupted this PR with incorrect merge. So I'm closing it and will create a new one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] badaiaqrandista closed pull request #8909: KAFKA-6733: Support of printing additional ConsumerRecord fields in DefaultMessageFormatter (rebased)
Posted by GitBox <gi...@apache.org>.
badaiaqrandista closed pull request #8909:
URL: https://github.com/apache/kafka/pull/8909
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac commented on a change in pull request #8909: KAFKA-6733: Support of printing additional ConsumerRecord fields in DefaultMessageFormatter (rebased)
Posted by GitBox <gi...@apache.org>.
dajac commented on a change in pull request #8909:
URL: https://github.com/apache/kafka/pull/8909#discussion_r449546534
##########
File path: core/src/main/scala/kafka/tools/ConsoleConsumer.scala
##########
@@ -460,46 +466,31 @@ class DefaultMessageFormatter extends MessageFormatter {
var printKey = false
var printValue = true
var printPartition = false
- var keySeparator = "\t".getBytes(StandardCharsets.UTF_8)
- var lineSeparator = "\n".getBytes(StandardCharsets.UTF_8)
+ var printOffset = false
+ var printHeaders = false
+ var keySeparator = utfBytes("\t")
+ var lineSeparator = utfBytes("\n")
+ var headersSeparator = utfBytes(",")
var keyDeserializer: Option[Deserializer[_]] = None
var valueDeserializer: Option[Deserializer[_]] = None
+ var headersDeserializer: Option[Deserializer[_]] = None
override def init(props: Properties): Unit = {
Review comment:
@badaiaqrandista FYI, the `init` method has been deprecated as part of KIP-597: https://github.com/apache/kafka/pull/8604. You will have to adapt your PR to support it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org