You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2020/06/04 17:29:59 UTC

[GitHub] [samza] lakshmi-manasa-g commented on a change in pull request #1375: Samza-2540: Legacy Task application are missing app.run.id for both batch & stream jobs

lakshmi-manasa-g commented on a change in pull request #1375:
URL: https://github.com/apache/samza/pull/1375#discussion_r435418946



##########
File path: samza-core/src/main/java/org/apache/samza/execution/JobPlanner.java
##########
@@ -127,9 +134,6 @@ final void writePlanJsonFile(String planJson) {
 
   private Map<String, String> getGeneratedConfig(String runId) {

Review comment:
       does this method still need a runId passed into it?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org