You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/07 10:49:19 UTC
[GitHub] [flink] rkhachatryan opened a new pull request #18297: [FLINK-25395][state] Don't discard shared state on TM
rkhachatryan opened a new pull request #18297:
URL: https://github.com/apache/flink/pull/18297
## What is the purpose of the change
```
After FLINK-25395, shared (incremental) state can be re-used
by state backends regardless of the confirmation by JM.
JM will only discard it on checkpoint subsumption or job termination.
However, state can also be discarded by TM in case of failures:
- AsyncCheckpointRunnable.cleanup
- PeriodicMaterializationManager.uploadSnapshot
- StreamOperatorStateHandler.snapshotState
- SubtaskCheckpointCoordinatorImpl.cleanup
Those cleanups might render previous checkpoints invalid.
This change fixes it by removing discard calls from the relevant
state handles. This may leave more orphaned state artefacts on DFS,
which should be addressed by FLINK-24852.
```
## Verifying this change
- added `IncrementalStateReuseAfterFailureITCase` that reproduces the original FileNotFoundException if changes to handles are reverted
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18297: [FLINK-25395][state] Don't discard shared state on TM
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18297:
URL: https://github.com/apache/flink/pull/18297#issuecomment-1007316142
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7407da5e58ed7e7d093ddfd048e08583a5b5f49e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29096",
"triggerID" : "7407da5e58ed7e7d093ddfd048e08583a5b5f49e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7407da5e58ed7e7d093ddfd048e08583a5b5f49e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29096)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18297: [FLINK-25395][state] Don't discard shared state on TM
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18297:
URL: https://github.com/apache/flink/pull/18297#issuecomment-1007316142
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7407da5e58ed7e7d093ddfd048e08583a5b5f49e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29096",
"triggerID" : "7407da5e58ed7e7d093ddfd048e08583a5b5f49e",
"triggerType" : "PUSH"
}, {
"hash" : "9ba683626f0e8cacd5f1a957f441a3dc5ed8052d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29185",
"triggerID" : "9ba683626f0e8cacd5f1a957f441a3dc5ed8052d",
"triggerType" : "PUSH"
}, {
"hash" : "704ffe0a61208970a6b9d6c777faa20deb31780d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29203",
"triggerID" : "704ffe0a61208970a6b9d6c777faa20deb31780d",
"triggerType" : "PUSH"
}, {
"hash" : "86220030570198152807a53f22832770efcd12e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29205",
"triggerID" : "86220030570198152807a53f22832770efcd12e7",
"triggerType" : "PUSH"
}, {
"hash" : "08c8a6f0bb7201b507f08a2b56432bcc94ebe914",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29236",
"triggerID" : "08c8a6f0bb7201b507f08a2b56432bcc94ebe914",
"triggerType" : "PUSH"
}, {
"hash" : "49aa65fadd8ee87ac7c97fd7b3be06f0238c3fcd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "49aa65fadd8ee87ac7c97fd7b3be06f0238c3fcd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 08c8a6f0bb7201b507f08a2b56432bcc94ebe914 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29236)
* 49aa65fadd8ee87ac7c97fd7b3be06f0238c3fcd UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on a change in pull request #18297: [FLINK-25395][state] Fix TM error handling when uploading shared state
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #18297:
URL: https://github.com/apache/flink/pull/18297#discussion_r785510841
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/changelog/ChangelogStateHandleStreamImpl.java
##########
@@ -83,11 +80,7 @@ public KeyedStateHandle getIntersection(KeyGroupRange keyGroupRange) {
@Override
public void discardState() throws Exception {
- // discard only on TM; on JM, shared state is removed on subsumption
- if (stateRegistry == null) {
- bestEffortDiscardAllStateObjects(
- handlesAndOffsets.stream().map(t2 -> t2.f0).collect(Collectors.toList()));
- }
+ // do nothing: rely on SharedStateRegistry for cleanup after ACK;
Review comment:
I meant acknowledging checkpoint by task to JobManager.
I expaneded the comment:
```
// Do nothing: state will be discarded by SharedStateRegistry once JM receives it and a
// newer checkpoint completes without using it. JM might not receive the handle in the
// following cases:
// 1. hard TM failure
// 2. job termination
// 3. materialization of changes written pre-emptively
// The above cases will be addressed by FLINK-23139 and/or FLINK-24852```
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18297: [FLINK-25395][state] Don't discard shared state on TM
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18297:
URL: https://github.com/apache/flink/pull/18297#issuecomment-1007315437
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 7407da5e58ed7e7d093ddfd048e08583a5b5f49e (Fri Jan 07 10:53:10 UTC 2022)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on a change in pull request #18297: [FLINK-25395][state] Fix TM error handling when uploading shared state
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #18297:
URL: https://github.com/apache/flink/pull/18297#discussion_r784256807
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/changelog/ChangelogStateHandleStreamImpl.java
##########
@@ -83,11 +80,7 @@ public KeyedStateHandle getIntersection(KeyGroupRange keyGroupRange) {
@Override
public void discardState() throws Exception {
- // discard only on TM; on JM, shared state is removed on subsumption
- if (stateRegistry == null) {
- bestEffortDiscardAllStateObjects(
- handlesAndOffsets.stream().map(t2 -> t2.f0).collect(Collectors.toList()));
- }
+ // do nothing: rely on SharedStateRegistry for cleanup after ACK;
Review comment:
The in-memory object will be GCed on checkpoint subsumption;
The actual handles will be discarded by `SharedStateRegistry` when no longer used (they are registered in `registerSharedStates`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka commented on a change in pull request #18297: [FLINK-25395][state] Fix TM error handling when uploading shared state
Posted by GitBox <gi...@apache.org>.
Myasuka commented on a change in pull request #18297:
URL: https://github.com/apache/flink/pull/18297#discussion_r783922498
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/changelog/ChangelogStateHandleStreamImpl.java
##########
@@ -83,11 +80,7 @@ public KeyedStateHandle getIntersection(KeyGroupRange keyGroupRange) {
@Override
public void discardState() throws Exception {
- // discard only on TM; on JM, shared state is removed on subsumption
- if (stateRegistry == null) {
- bestEffortDiscardAllStateObjects(
- handlesAndOffsets.stream().map(t2 -> t2.f0).collect(Collectors.toList()));
- }
+ // do nothing: rely on SharedStateRegistry for cleanup after ACK;
Review comment:
When would the `handlesAndOffsets` be deleted then?
##########
File path: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/snapshot/RocksIncrementalSnapshotStrategy.java
##########
@@ -493,12 +482,10 @@ private void uploadSstFiles(
// ignore an older upload if it completed after a newer one has completed
if (checkpointId > lastCheckpointIdUploadedSst) {
lastCheckpointIdUploadedSst = checkpointId;
Review comment:
`lastCheckpointIdUploadedSst` is no longger useful.
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/changelog/ChangelogStateHandleStreamImpl.java
##########
@@ -83,11 +80,7 @@ public KeyedStateHandle getIntersection(KeyGroupRange keyGroupRange) {
@Override
public void discardState() throws Exception {
- // discard only on TM; on JM, shared state is removed on subsumption
- if (stateRegistry == null) {
Review comment:
The private `stateRegistry` could be also removed from this class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18297: [FLINK-25395][state] Don't discard shared state on TM
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18297:
URL: https://github.com/apache/flink/pull/18297#issuecomment-1007316142
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18297: [FLINK-25395][state] Don't discard shared state on TM
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18297:
URL: https://github.com/apache/flink/pull/18297#issuecomment-1007316142
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7407da5e58ed7e7d093ddfd048e08583a5b5f49e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29096",
"triggerID" : "7407da5e58ed7e7d093ddfd048e08583a5b5f49e",
"triggerType" : "PUSH"
}, {
"hash" : "9ba683626f0e8cacd5f1a957f441a3dc5ed8052d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29185",
"triggerID" : "9ba683626f0e8cacd5f1a957f441a3dc5ed8052d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9ba683626f0e8cacd5f1a957f441a3dc5ed8052d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29185)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18297: [FLINK-25395][state] Fix TM error handling when uploading shared state
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18297:
URL: https://github.com/apache/flink/pull/18297#issuecomment-1007316142
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7407da5e58ed7e7d093ddfd048e08583a5b5f49e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29096",
"triggerID" : "7407da5e58ed7e7d093ddfd048e08583a5b5f49e",
"triggerType" : "PUSH"
}, {
"hash" : "9ba683626f0e8cacd5f1a957f441a3dc5ed8052d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29185",
"triggerID" : "9ba683626f0e8cacd5f1a957f441a3dc5ed8052d",
"triggerType" : "PUSH"
}, {
"hash" : "704ffe0a61208970a6b9d6c777faa20deb31780d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29203",
"triggerID" : "704ffe0a61208970a6b9d6c777faa20deb31780d",
"triggerType" : "PUSH"
}, {
"hash" : "86220030570198152807a53f22832770efcd12e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29205",
"triggerID" : "86220030570198152807a53f22832770efcd12e7",
"triggerType" : "PUSH"
}, {
"hash" : "08c8a6f0bb7201b507f08a2b56432bcc94ebe914",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29236",
"triggerID" : "08c8a6f0bb7201b507f08a2b56432bcc94ebe914",
"triggerType" : "PUSH"
}, {
"hash" : "49aa65fadd8ee87ac7c97fd7b3be06f0238c3fcd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29274",
"triggerID" : "49aa65fadd8ee87ac7c97fd7b3be06f0238c3fcd",
"triggerType" : "PUSH"
}, {
"hash" : "eeb8c798bc364480d8e2b5ecf8b55c54397cef14",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29316",
"triggerID" : "eeb8c798bc364480d8e2b5ecf8b55c54397cef14",
"triggerType" : "PUSH"
}, {
"hash" : "1f13ac7621406c519bb21cada599448bda822453",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29417",
"triggerID" : "1f13ac7621406c519bb21cada599448bda822453",
"triggerType" : "PUSH"
}, {
"hash" : "83a05868dd4718112ebcd8f92271d84aa90fa733",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "83a05868dd4718112ebcd8f92271d84aa90fa733",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1f13ac7621406c519bb21cada599448bda822453 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29417)
* 83a05868dd4718112ebcd8f92271d84aa90fa733 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18297: [FLINK-25395][state] Don't discard shared state on TM
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18297:
URL: https://github.com/apache/flink/pull/18297#issuecomment-1007316142
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7407da5e58ed7e7d093ddfd048e08583a5b5f49e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29096",
"triggerID" : "7407da5e58ed7e7d093ddfd048e08583a5b5f49e",
"triggerType" : "PUSH"
}, {
"hash" : "9ba683626f0e8cacd5f1a957f441a3dc5ed8052d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9ba683626f0e8cacd5f1a957f441a3dc5ed8052d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7407da5e58ed7e7d093ddfd048e08583a5b5f49e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29096)
* 9ba683626f0e8cacd5f1a957f441a3dc5ed8052d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan merged pull request #18297: [FLINK-25395][state] Fix TM error handling when uploading shared state
Posted by GitBox <gi...@apache.org>.
rkhachatryan merged pull request #18297:
URL: https://github.com/apache/flink/pull/18297
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18297: [FLINK-25395][state] Fix TM error handling when uploading shared state
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18297:
URL: https://github.com/apache/flink/pull/18297#issuecomment-1007316142
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7407da5e58ed7e7d093ddfd048e08583a5b5f49e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29096",
"triggerID" : "7407da5e58ed7e7d093ddfd048e08583a5b5f49e",
"triggerType" : "PUSH"
}, {
"hash" : "9ba683626f0e8cacd5f1a957f441a3dc5ed8052d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29185",
"triggerID" : "9ba683626f0e8cacd5f1a957f441a3dc5ed8052d",
"triggerType" : "PUSH"
}, {
"hash" : "704ffe0a61208970a6b9d6c777faa20deb31780d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29203",
"triggerID" : "704ffe0a61208970a6b9d6c777faa20deb31780d",
"triggerType" : "PUSH"
}, {
"hash" : "86220030570198152807a53f22832770efcd12e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29205",
"triggerID" : "86220030570198152807a53f22832770efcd12e7",
"triggerType" : "PUSH"
}, {
"hash" : "08c8a6f0bb7201b507f08a2b56432bcc94ebe914",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29236",
"triggerID" : "08c8a6f0bb7201b507f08a2b56432bcc94ebe914",
"triggerType" : "PUSH"
}, {
"hash" : "49aa65fadd8ee87ac7c97fd7b3be06f0238c3fcd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29274",
"triggerID" : "49aa65fadd8ee87ac7c97fd7b3be06f0238c3fcd",
"triggerType" : "PUSH"
}, {
"hash" : "eeb8c798bc364480d8e2b5ecf8b55c54397cef14",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29316",
"triggerID" : "eeb8c798bc364480d8e2b5ecf8b55c54397cef14",
"triggerType" : "PUSH"
}, {
"hash" : "1f13ac7621406c519bb21cada599448bda822453",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29417",
"triggerID" : "1f13ac7621406c519bb21cada599448bda822453",
"triggerType" : "PUSH"
}, {
"hash" : "83a05868dd4718112ebcd8f92271d84aa90fa733",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29509",
"triggerID" : "83a05868dd4718112ebcd8f92271d84aa90fa733",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 83a05868dd4718112ebcd8f92271d84aa90fa733 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29509)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18297: [FLINK-25395][state] Don't discard shared state on TM
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18297:
URL: https://github.com/apache/flink/pull/18297#issuecomment-1007316142
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7407da5e58ed7e7d093ddfd048e08583a5b5f49e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29096",
"triggerID" : "7407da5e58ed7e7d093ddfd048e08583a5b5f49e",
"triggerType" : "PUSH"
}, {
"hash" : "9ba683626f0e8cacd5f1a957f441a3dc5ed8052d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29185",
"triggerID" : "9ba683626f0e8cacd5f1a957f441a3dc5ed8052d",
"triggerType" : "PUSH"
}, {
"hash" : "704ffe0a61208970a6b9d6c777faa20deb31780d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29203",
"triggerID" : "704ffe0a61208970a6b9d6c777faa20deb31780d",
"triggerType" : "PUSH"
}, {
"hash" : "86220030570198152807a53f22832770efcd12e7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29205",
"triggerID" : "86220030570198152807a53f22832770efcd12e7",
"triggerType" : "PUSH"
}, {
"hash" : "08c8a6f0bb7201b507f08a2b56432bcc94ebe914",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "08c8a6f0bb7201b507f08a2b56432bcc94ebe914",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 86220030570198152807a53f22832770efcd12e7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29205)
* 08c8a6f0bb7201b507f08a2b56432bcc94ebe914 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18297: [FLINK-25395][state] Don't discard shared state on TM
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18297:
URL: https://github.com/apache/flink/pull/18297#issuecomment-1007316142
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7407da5e58ed7e7d093ddfd048e08583a5b5f49e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7407da5e58ed7e7d093ddfd048e08583a5b5f49e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7407da5e58ed7e7d093ddfd048e08583a5b5f49e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18297: [FLINK-25395][state] Don't discard shared state on TM
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18297:
URL: https://github.com/apache/flink/pull/18297#issuecomment-1007316142
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7407da5e58ed7e7d093ddfd048e08583a5b5f49e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29096",
"triggerID" : "7407da5e58ed7e7d093ddfd048e08583a5b5f49e",
"triggerType" : "PUSH"
}, {
"hash" : "9ba683626f0e8cacd5f1a957f441a3dc5ed8052d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29185",
"triggerID" : "9ba683626f0e8cacd5f1a957f441a3dc5ed8052d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7407da5e58ed7e7d093ddfd048e08583a5b5f49e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29096)
* 9ba683626f0e8cacd5f1a957f441a3dc5ed8052d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29185)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on pull request #18297: [FLINK-25395][state] Fix TM error handling when uploading shared state
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on pull request #18297:
URL: https://github.com/apache/flink/pull/18297#issuecomment-1014383309
Thanks for the review.
I've just merged to master after squashing the commits and rebasing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18297: [FLINK-25395][state] Don't discard shared state on TM
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18297:
URL: https://github.com/apache/flink/pull/18297#issuecomment-1007315437
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18297: [FLINK-25395][state] Fix TM error handling when uploading shared state
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18297:
URL: https://github.com/apache/flink/pull/18297#issuecomment-1007316142
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7407da5e58ed7e7d093ddfd048e08583a5b5f49e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29096",
"triggerID" : "7407da5e58ed7e7d093ddfd048e08583a5b5f49e",
"triggerType" : "PUSH"
}, {
"hash" : "9ba683626f0e8cacd5f1a957f441a3dc5ed8052d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29185",
"triggerID" : "9ba683626f0e8cacd5f1a957f441a3dc5ed8052d",
"triggerType" : "PUSH"
}, {
"hash" : "704ffe0a61208970a6b9d6c777faa20deb31780d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29203",
"triggerID" : "704ffe0a61208970a6b9d6c777faa20deb31780d",
"triggerType" : "PUSH"
}, {
"hash" : "86220030570198152807a53f22832770efcd12e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29205",
"triggerID" : "86220030570198152807a53f22832770efcd12e7",
"triggerType" : "PUSH"
}, {
"hash" : "08c8a6f0bb7201b507f08a2b56432bcc94ebe914",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29236",
"triggerID" : "08c8a6f0bb7201b507f08a2b56432bcc94ebe914",
"triggerType" : "PUSH"
}, {
"hash" : "49aa65fadd8ee87ac7c97fd7b3be06f0238c3fcd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29274",
"triggerID" : "49aa65fadd8ee87ac7c97fd7b3be06f0238c3fcd",
"triggerType" : "PUSH"
}, {
"hash" : "eeb8c798bc364480d8e2b5ecf8b55c54397cef14",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29316",
"triggerID" : "eeb8c798bc364480d8e2b5ecf8b55c54397cef14",
"triggerType" : "PUSH"
}, {
"hash" : "1f13ac7621406c519bb21cada599448bda822453",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29417",
"triggerID" : "1f13ac7621406c519bb21cada599448bda822453",
"triggerType" : "PUSH"
}, {
"hash" : "83a05868dd4718112ebcd8f92271d84aa90fa733",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29509",
"triggerID" : "83a05868dd4718112ebcd8f92271d84aa90fa733",
"triggerType" : "PUSH"
}, {
"hash" : "e9f6844ca37bc2cc2fbd2691fa424479a269460b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e9f6844ca37bc2cc2fbd2691fa424479a269460b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 83a05868dd4718112ebcd8f92271d84aa90fa733 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29509)
* e9f6844ca37bc2cc2fbd2691fa424479a269460b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18297: [FLINK-25395][state] Don't discard shared state on TM
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18297:
URL: https://github.com/apache/flink/pull/18297#issuecomment-1007316142
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7407da5e58ed7e7d093ddfd048e08583a5b5f49e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29096",
"triggerID" : "7407da5e58ed7e7d093ddfd048e08583a5b5f49e",
"triggerType" : "PUSH"
}, {
"hash" : "9ba683626f0e8cacd5f1a957f441a3dc5ed8052d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29185",
"triggerID" : "9ba683626f0e8cacd5f1a957f441a3dc5ed8052d",
"triggerType" : "PUSH"
}, {
"hash" : "704ffe0a61208970a6b9d6c777faa20deb31780d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29203",
"triggerID" : "704ffe0a61208970a6b9d6c777faa20deb31780d",
"triggerType" : "PUSH"
}, {
"hash" : "86220030570198152807a53f22832770efcd12e7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29205",
"triggerID" : "86220030570198152807a53f22832770efcd12e7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 86220030570198152807a53f22832770efcd12e7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29205)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18297: [FLINK-25395][state] Don't discard shared state on TM
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18297:
URL: https://github.com/apache/flink/pull/18297#issuecomment-1007316142
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7407da5e58ed7e7d093ddfd048e08583a5b5f49e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29096",
"triggerID" : "7407da5e58ed7e7d093ddfd048e08583a5b5f49e",
"triggerType" : "PUSH"
}, {
"hash" : "9ba683626f0e8cacd5f1a957f441a3dc5ed8052d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29185",
"triggerID" : "9ba683626f0e8cacd5f1a957f441a3dc5ed8052d",
"triggerType" : "PUSH"
}, {
"hash" : "704ffe0a61208970a6b9d6c777faa20deb31780d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29203",
"triggerID" : "704ffe0a61208970a6b9d6c777faa20deb31780d",
"triggerType" : "PUSH"
}, {
"hash" : "86220030570198152807a53f22832770efcd12e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29205",
"triggerID" : "86220030570198152807a53f22832770efcd12e7",
"triggerType" : "PUSH"
}, {
"hash" : "08c8a6f0bb7201b507f08a2b56432bcc94ebe914",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29236",
"triggerID" : "08c8a6f0bb7201b507f08a2b56432bcc94ebe914",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 08c8a6f0bb7201b507f08a2b56432bcc94ebe914 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29236)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18297: [FLINK-25395][state] Don't discard shared state on TM
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18297:
URL: https://github.com/apache/flink/pull/18297#issuecomment-1007316142
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7407da5e58ed7e7d093ddfd048e08583a5b5f49e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29096",
"triggerID" : "7407da5e58ed7e7d093ddfd048e08583a5b5f49e",
"triggerType" : "PUSH"
}, {
"hash" : "9ba683626f0e8cacd5f1a957f441a3dc5ed8052d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29185",
"triggerID" : "9ba683626f0e8cacd5f1a957f441a3dc5ed8052d",
"triggerType" : "PUSH"
}, {
"hash" : "704ffe0a61208970a6b9d6c777faa20deb31780d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29203",
"triggerID" : "704ffe0a61208970a6b9d6c777faa20deb31780d",
"triggerType" : "PUSH"
}, {
"hash" : "86220030570198152807a53f22832770efcd12e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29205",
"triggerID" : "86220030570198152807a53f22832770efcd12e7",
"triggerType" : "PUSH"
}, {
"hash" : "08c8a6f0bb7201b507f08a2b56432bcc94ebe914",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29236",
"triggerID" : "08c8a6f0bb7201b507f08a2b56432bcc94ebe914",
"triggerType" : "PUSH"
}, {
"hash" : "49aa65fadd8ee87ac7c97fd7b3be06f0238c3fcd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29274",
"triggerID" : "49aa65fadd8ee87ac7c97fd7b3be06f0238c3fcd",
"triggerType" : "PUSH"
}, {
"hash" : "eeb8c798bc364480d8e2b5ecf8b55c54397cef14",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29316",
"triggerID" : "eeb8c798bc364480d8e2b5ecf8b55c54397cef14",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 49aa65fadd8ee87ac7c97fd7b3be06f0238c3fcd Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29274)
* eeb8c798bc364480d8e2b5ecf8b55c54397cef14 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29316)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18297: [FLINK-25395][state] Don't discard shared state on TM
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18297:
URL: https://github.com/apache/flink/pull/18297#issuecomment-1007316142
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7407da5e58ed7e7d093ddfd048e08583a5b5f49e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29096",
"triggerID" : "7407da5e58ed7e7d093ddfd048e08583a5b5f49e",
"triggerType" : "PUSH"
}, {
"hash" : "9ba683626f0e8cacd5f1a957f441a3dc5ed8052d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29185",
"triggerID" : "9ba683626f0e8cacd5f1a957f441a3dc5ed8052d",
"triggerType" : "PUSH"
}, {
"hash" : "704ffe0a61208970a6b9d6c777faa20deb31780d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29203",
"triggerID" : "704ffe0a61208970a6b9d6c777faa20deb31780d",
"triggerType" : "PUSH"
}, {
"hash" : "86220030570198152807a53f22832770efcd12e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29205",
"triggerID" : "86220030570198152807a53f22832770efcd12e7",
"triggerType" : "PUSH"
}, {
"hash" : "08c8a6f0bb7201b507f08a2b56432bcc94ebe914",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29236",
"triggerID" : "08c8a6f0bb7201b507f08a2b56432bcc94ebe914",
"triggerType" : "PUSH"
}, {
"hash" : "49aa65fadd8ee87ac7c97fd7b3be06f0238c3fcd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29274",
"triggerID" : "49aa65fadd8ee87ac7c97fd7b3be06f0238c3fcd",
"triggerType" : "PUSH"
}, {
"hash" : "eeb8c798bc364480d8e2b5ecf8b55c54397cef14",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29316",
"triggerID" : "eeb8c798bc364480d8e2b5ecf8b55c54397cef14",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* eeb8c798bc364480d8e2b5ecf8b55c54397cef14 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29316)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18297: [FLINK-25395][state] Fix TM error handling when uploading shared state
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18297:
URL: https://github.com/apache/flink/pull/18297#issuecomment-1007316142
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7407da5e58ed7e7d093ddfd048e08583a5b5f49e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29096",
"triggerID" : "7407da5e58ed7e7d093ddfd048e08583a5b5f49e",
"triggerType" : "PUSH"
}, {
"hash" : "9ba683626f0e8cacd5f1a957f441a3dc5ed8052d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29185",
"triggerID" : "9ba683626f0e8cacd5f1a957f441a3dc5ed8052d",
"triggerType" : "PUSH"
}, {
"hash" : "704ffe0a61208970a6b9d6c777faa20deb31780d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29203",
"triggerID" : "704ffe0a61208970a6b9d6c777faa20deb31780d",
"triggerType" : "PUSH"
}, {
"hash" : "86220030570198152807a53f22832770efcd12e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29205",
"triggerID" : "86220030570198152807a53f22832770efcd12e7",
"triggerType" : "PUSH"
}, {
"hash" : "08c8a6f0bb7201b507f08a2b56432bcc94ebe914",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29236",
"triggerID" : "08c8a6f0bb7201b507f08a2b56432bcc94ebe914",
"triggerType" : "PUSH"
}, {
"hash" : "49aa65fadd8ee87ac7c97fd7b3be06f0238c3fcd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29274",
"triggerID" : "49aa65fadd8ee87ac7c97fd7b3be06f0238c3fcd",
"triggerType" : "PUSH"
}, {
"hash" : "eeb8c798bc364480d8e2b5ecf8b55c54397cef14",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29316",
"triggerID" : "eeb8c798bc364480d8e2b5ecf8b55c54397cef14",
"triggerType" : "PUSH"
}, {
"hash" : "1f13ac7621406c519bb21cada599448bda822453",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1f13ac7621406c519bb21cada599448bda822453",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* eeb8c798bc364480d8e2b5ecf8b55c54397cef14 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29316)
* 1f13ac7621406c519bb21cada599448bda822453 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka commented on a change in pull request #18297: [FLINK-25395][state] Fix TM error handling when uploading shared state
Posted by GitBox <gi...@apache.org>.
Myasuka commented on a change in pull request #18297:
URL: https://github.com/apache/flink/pull/18297#discussion_r784683300
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/changelog/ChangelogStateHandleStreamImpl.java
##########
@@ -83,11 +80,7 @@ public KeyedStateHandle getIntersection(KeyGroupRange keyGroupRange) {
@Override
public void discardState() throws Exception {
- // discard only on TM; on JM, shared state is removed on subsumption
- if (stateRegistry == null) {
- bestEffortDiscardAllStateObjects(
- handlesAndOffsets.stream().map(t2 -> t2.f0).collect(Collectors.toList()));
- }
+ // do nothing: rely on SharedStateRegistry for cleanup after ACK;
Review comment:
Thanks for your clarification, I think we can improve the comment, e.g What the `ACK` is meaning here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18297: [FLINK-25395][state] Don't discard shared state on TM
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18297:
URL: https://github.com/apache/flink/pull/18297#issuecomment-1007316142
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7407da5e58ed7e7d093ddfd048e08583a5b5f49e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29096",
"triggerID" : "7407da5e58ed7e7d093ddfd048e08583a5b5f49e",
"triggerType" : "PUSH"
}, {
"hash" : "9ba683626f0e8cacd5f1a957f441a3dc5ed8052d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29185",
"triggerID" : "9ba683626f0e8cacd5f1a957f441a3dc5ed8052d",
"triggerType" : "PUSH"
}, {
"hash" : "704ffe0a61208970a6b9d6c777faa20deb31780d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29203",
"triggerID" : "704ffe0a61208970a6b9d6c777faa20deb31780d",
"triggerType" : "PUSH"
}, {
"hash" : "86220030570198152807a53f22832770efcd12e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29205",
"triggerID" : "86220030570198152807a53f22832770efcd12e7",
"triggerType" : "PUSH"
}, {
"hash" : "08c8a6f0bb7201b507f08a2b56432bcc94ebe914",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29236",
"triggerID" : "08c8a6f0bb7201b507f08a2b56432bcc94ebe914",
"triggerType" : "PUSH"
}, {
"hash" : "49aa65fadd8ee87ac7c97fd7b3be06f0238c3fcd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29274",
"triggerID" : "49aa65fadd8ee87ac7c97fd7b3be06f0238c3fcd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 08c8a6f0bb7201b507f08a2b56432bcc94ebe914 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29236)
* 49aa65fadd8ee87ac7c97fd7b3be06f0238c3fcd Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29274)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18297: [FLINK-25395][state] Don't discard shared state on TM
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18297:
URL: https://github.com/apache/flink/pull/18297#issuecomment-1007316142
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7407da5e58ed7e7d093ddfd048e08583a5b5f49e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29096",
"triggerID" : "7407da5e58ed7e7d093ddfd048e08583a5b5f49e",
"triggerType" : "PUSH"
}, {
"hash" : "9ba683626f0e8cacd5f1a957f441a3dc5ed8052d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29185",
"triggerID" : "9ba683626f0e8cacd5f1a957f441a3dc5ed8052d",
"triggerType" : "PUSH"
}, {
"hash" : "704ffe0a61208970a6b9d6c777faa20deb31780d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29203",
"triggerID" : "704ffe0a61208970a6b9d6c777faa20deb31780d",
"triggerType" : "PUSH"
}, {
"hash" : "86220030570198152807a53f22832770efcd12e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29205",
"triggerID" : "86220030570198152807a53f22832770efcd12e7",
"triggerType" : "PUSH"
}, {
"hash" : "08c8a6f0bb7201b507f08a2b56432bcc94ebe914",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29236",
"triggerID" : "08c8a6f0bb7201b507f08a2b56432bcc94ebe914",
"triggerType" : "PUSH"
}, {
"hash" : "49aa65fadd8ee87ac7c97fd7b3be06f0238c3fcd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29274",
"triggerID" : "49aa65fadd8ee87ac7c97fd7b3be06f0238c3fcd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 49aa65fadd8ee87ac7c97fd7b3be06f0238c3fcd Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29274)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18297: [FLINK-25395][state] Fix TM error handling when uploading shared state
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18297:
URL: https://github.com/apache/flink/pull/18297#issuecomment-1007316142
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7407da5e58ed7e7d093ddfd048e08583a5b5f49e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29096",
"triggerID" : "7407da5e58ed7e7d093ddfd048e08583a5b5f49e",
"triggerType" : "PUSH"
}, {
"hash" : "9ba683626f0e8cacd5f1a957f441a3dc5ed8052d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29185",
"triggerID" : "9ba683626f0e8cacd5f1a957f441a3dc5ed8052d",
"triggerType" : "PUSH"
}, {
"hash" : "704ffe0a61208970a6b9d6c777faa20deb31780d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29203",
"triggerID" : "704ffe0a61208970a6b9d6c777faa20deb31780d",
"triggerType" : "PUSH"
}, {
"hash" : "86220030570198152807a53f22832770efcd12e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29205",
"triggerID" : "86220030570198152807a53f22832770efcd12e7",
"triggerType" : "PUSH"
}, {
"hash" : "08c8a6f0bb7201b507f08a2b56432bcc94ebe914",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29236",
"triggerID" : "08c8a6f0bb7201b507f08a2b56432bcc94ebe914",
"triggerType" : "PUSH"
}, {
"hash" : "49aa65fadd8ee87ac7c97fd7b3be06f0238c3fcd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29274",
"triggerID" : "49aa65fadd8ee87ac7c97fd7b3be06f0238c3fcd",
"triggerType" : "PUSH"
}, {
"hash" : "eeb8c798bc364480d8e2b5ecf8b55c54397cef14",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29316",
"triggerID" : "eeb8c798bc364480d8e2b5ecf8b55c54397cef14",
"triggerType" : "PUSH"
}, {
"hash" : "1f13ac7621406c519bb21cada599448bda822453",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29417",
"triggerID" : "1f13ac7621406c519bb21cada599448bda822453",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* eeb8c798bc364480d8e2b5ecf8b55c54397cef14 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29316)
* 1f13ac7621406c519bb21cada599448bda822453 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29417)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18297: [FLINK-25395][state] Fix TM error handling when uploading shared state
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18297:
URL: https://github.com/apache/flink/pull/18297#issuecomment-1007316142
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7407da5e58ed7e7d093ddfd048e08583a5b5f49e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29096",
"triggerID" : "7407da5e58ed7e7d093ddfd048e08583a5b5f49e",
"triggerType" : "PUSH"
}, {
"hash" : "9ba683626f0e8cacd5f1a957f441a3dc5ed8052d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29185",
"triggerID" : "9ba683626f0e8cacd5f1a957f441a3dc5ed8052d",
"triggerType" : "PUSH"
}, {
"hash" : "704ffe0a61208970a6b9d6c777faa20deb31780d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29203",
"triggerID" : "704ffe0a61208970a6b9d6c777faa20deb31780d",
"triggerType" : "PUSH"
}, {
"hash" : "86220030570198152807a53f22832770efcd12e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29205",
"triggerID" : "86220030570198152807a53f22832770efcd12e7",
"triggerType" : "PUSH"
}, {
"hash" : "08c8a6f0bb7201b507f08a2b56432bcc94ebe914",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29236",
"triggerID" : "08c8a6f0bb7201b507f08a2b56432bcc94ebe914",
"triggerType" : "PUSH"
}, {
"hash" : "49aa65fadd8ee87ac7c97fd7b3be06f0238c3fcd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29274",
"triggerID" : "49aa65fadd8ee87ac7c97fd7b3be06f0238c3fcd",
"triggerType" : "PUSH"
}, {
"hash" : "eeb8c798bc364480d8e2b5ecf8b55c54397cef14",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29316",
"triggerID" : "eeb8c798bc364480d8e2b5ecf8b55c54397cef14",
"triggerType" : "PUSH"
}, {
"hash" : "1f13ac7621406c519bb21cada599448bda822453",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29417",
"triggerID" : "1f13ac7621406c519bb21cada599448bda822453",
"triggerType" : "PUSH"
}, {
"hash" : "83a05868dd4718112ebcd8f92271d84aa90fa733",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29509",
"triggerID" : "83a05868dd4718112ebcd8f92271d84aa90fa733",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1f13ac7621406c519bb21cada599448bda822453 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29417)
* 83a05868dd4718112ebcd8f92271d84aa90fa733 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29509)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on a change in pull request #18297: [FLINK-25395][state] Fix TM error handling when uploading shared state
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #18297:
URL: https://github.com/apache/flink/pull/18297#discussion_r785510841
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/changelog/ChangelogStateHandleStreamImpl.java
##########
@@ -83,11 +80,7 @@ public KeyedStateHandle getIntersection(KeyGroupRange keyGroupRange) {
@Override
public void discardState() throws Exception {
- // discard only on TM; on JM, shared state is removed on subsumption
- if (stateRegistry == null) {
- bestEffortDiscardAllStateObjects(
- handlesAndOffsets.stream().map(t2 -> t2.f0).collect(Collectors.toList()));
- }
+ // do nothing: rely on SharedStateRegistry for cleanup after ACK;
Review comment:
I meant acknowledging checkpoint by task to JobManager.
I expaneded the comment:
```
// Do nothing: state will be discarded by SharedStateRegistry once JM receives it and a
// newer checkpoint completes without using it. JM might not receive the handle in the
// following cases:
// 1. hard TM failure
// 2. job termination
// 3. materialization of changes written pre-emptively
// The above cases will be addressed by FLINK-23139 and/or FLINK-24852
```
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18297: [FLINK-25395][state] Don't discard shared state on TM
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18297:
URL: https://github.com/apache/flink/pull/18297#issuecomment-1007316142
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7407da5e58ed7e7d093ddfd048e08583a5b5f49e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29096",
"triggerID" : "7407da5e58ed7e7d093ddfd048e08583a5b5f49e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7407da5e58ed7e7d093ddfd048e08583a5b5f49e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29096)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on a change in pull request #18297: [FLINK-25395][state] Fix TM error handling when uploading shared state
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #18297:
URL: https://github.com/apache/flink/pull/18297#discussion_r785510841
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/changelog/ChangelogStateHandleStreamImpl.java
##########
@@ -83,11 +80,7 @@ public KeyedStateHandle getIntersection(KeyGroupRange keyGroupRange) {
@Override
public void discardState() throws Exception {
- // discard only on TM; on JM, shared state is removed on subsumption
- if (stateRegistry == null) {
- bestEffortDiscardAllStateObjects(
- handlesAndOffsets.stream().map(t2 -> t2.f0).collect(Collectors.toList()));
- }
+ // do nothing: rely on SharedStateRegistry for cleanup after ACK;
Review comment:
I meant acknowledging checkpoint by task to JobManager.
I expaneded the comment:
```
// Do nothing: state will be discarded by SharedStateRegistry once JM receives it and a
// newer checkpoint completes without using it. JM might not receive the handle in the
// following cases:
// 1. hard TM failure
// 2. job termination
// 3. materialization of changes written pre-emptively
// The above cases will be addressed by FLINK-23139 and/or FLINK-24852```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18297: [FLINK-25395][state] Don't discard shared state on TM
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18297:
URL: https://github.com/apache/flink/pull/18297#issuecomment-1007316142
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7407da5e58ed7e7d093ddfd048e08583a5b5f49e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29096",
"triggerID" : "7407da5e58ed7e7d093ddfd048e08583a5b5f49e",
"triggerType" : "PUSH"
}, {
"hash" : "9ba683626f0e8cacd5f1a957f441a3dc5ed8052d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29185",
"triggerID" : "9ba683626f0e8cacd5f1a957f441a3dc5ed8052d",
"triggerType" : "PUSH"
}, {
"hash" : "704ffe0a61208970a6b9d6c777faa20deb31780d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29203",
"triggerID" : "704ffe0a61208970a6b9d6c777faa20deb31780d",
"triggerType" : "PUSH"
}, {
"hash" : "86220030570198152807a53f22832770efcd12e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29205",
"triggerID" : "86220030570198152807a53f22832770efcd12e7",
"triggerType" : "PUSH"
}, {
"hash" : "08c8a6f0bb7201b507f08a2b56432bcc94ebe914",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29236",
"triggerID" : "08c8a6f0bb7201b507f08a2b56432bcc94ebe914",
"triggerType" : "PUSH"
}, {
"hash" : "49aa65fadd8ee87ac7c97fd7b3be06f0238c3fcd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29274",
"triggerID" : "49aa65fadd8ee87ac7c97fd7b3be06f0238c3fcd",
"triggerType" : "PUSH"
}, {
"hash" : "eeb8c798bc364480d8e2b5ecf8b55c54397cef14",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "eeb8c798bc364480d8e2b5ecf8b55c54397cef14",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 49aa65fadd8ee87ac7c97fd7b3be06f0238c3fcd Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29274)
* eeb8c798bc364480d8e2b5ecf8b55c54397cef14 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18297: [FLINK-25395][state] Fix TM error handling when uploading shared state
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18297:
URL: https://github.com/apache/flink/pull/18297#issuecomment-1007316142
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7407da5e58ed7e7d093ddfd048e08583a5b5f49e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29096",
"triggerID" : "7407da5e58ed7e7d093ddfd048e08583a5b5f49e",
"triggerType" : "PUSH"
}, {
"hash" : "9ba683626f0e8cacd5f1a957f441a3dc5ed8052d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29185",
"triggerID" : "9ba683626f0e8cacd5f1a957f441a3dc5ed8052d",
"triggerType" : "PUSH"
}, {
"hash" : "704ffe0a61208970a6b9d6c777faa20deb31780d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29203",
"triggerID" : "704ffe0a61208970a6b9d6c777faa20deb31780d",
"triggerType" : "PUSH"
}, {
"hash" : "86220030570198152807a53f22832770efcd12e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29205",
"triggerID" : "86220030570198152807a53f22832770efcd12e7",
"triggerType" : "PUSH"
}, {
"hash" : "08c8a6f0bb7201b507f08a2b56432bcc94ebe914",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29236",
"triggerID" : "08c8a6f0bb7201b507f08a2b56432bcc94ebe914",
"triggerType" : "PUSH"
}, {
"hash" : "49aa65fadd8ee87ac7c97fd7b3be06f0238c3fcd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29274",
"triggerID" : "49aa65fadd8ee87ac7c97fd7b3be06f0238c3fcd",
"triggerType" : "PUSH"
}, {
"hash" : "eeb8c798bc364480d8e2b5ecf8b55c54397cef14",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29316",
"triggerID" : "eeb8c798bc364480d8e2b5ecf8b55c54397cef14",
"triggerType" : "PUSH"
}, {
"hash" : "1f13ac7621406c519bb21cada599448bda822453",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29417",
"triggerID" : "1f13ac7621406c519bb21cada599448bda822453",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1f13ac7621406c519bb21cada599448bda822453 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29417)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18297: [FLINK-25395][state] Don't discard shared state on TM
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18297:
URL: https://github.com/apache/flink/pull/18297#issuecomment-1007316142
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7407da5e58ed7e7d093ddfd048e08583a5b5f49e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29096",
"triggerID" : "7407da5e58ed7e7d093ddfd048e08583a5b5f49e",
"triggerType" : "PUSH"
}, {
"hash" : "9ba683626f0e8cacd5f1a957f441a3dc5ed8052d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29185",
"triggerID" : "9ba683626f0e8cacd5f1a957f441a3dc5ed8052d",
"triggerType" : "PUSH"
}, {
"hash" : "704ffe0a61208970a6b9d6c777faa20deb31780d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29203",
"triggerID" : "704ffe0a61208970a6b9d6c777faa20deb31780d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 704ffe0a61208970a6b9d6c777faa20deb31780d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29203)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18297: [FLINK-25395][state] Don't discard shared state on TM
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18297:
URL: https://github.com/apache/flink/pull/18297#issuecomment-1007316142
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7407da5e58ed7e7d093ddfd048e08583a5b5f49e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29096",
"triggerID" : "7407da5e58ed7e7d093ddfd048e08583a5b5f49e",
"triggerType" : "PUSH"
}, {
"hash" : "9ba683626f0e8cacd5f1a957f441a3dc5ed8052d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29185",
"triggerID" : "9ba683626f0e8cacd5f1a957f441a3dc5ed8052d",
"triggerType" : "PUSH"
}, {
"hash" : "704ffe0a61208970a6b9d6c777faa20deb31780d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29203",
"triggerID" : "704ffe0a61208970a6b9d6c777faa20deb31780d",
"triggerType" : "PUSH"
}, {
"hash" : "86220030570198152807a53f22832770efcd12e7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29205",
"triggerID" : "86220030570198152807a53f22832770efcd12e7",
"triggerType" : "PUSH"
}, {
"hash" : "08c8a6f0bb7201b507f08a2b56432bcc94ebe914",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29236",
"triggerID" : "08c8a6f0bb7201b507f08a2b56432bcc94ebe914",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 86220030570198152807a53f22832770efcd12e7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29205)
* 08c8a6f0bb7201b507f08a2b56432bcc94ebe914 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29236)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18297: [FLINK-25395][state] Fix TM error handling when uploading shared state
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18297:
URL: https://github.com/apache/flink/pull/18297#issuecomment-1007316142
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7407da5e58ed7e7d093ddfd048e08583a5b5f49e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29096",
"triggerID" : "7407da5e58ed7e7d093ddfd048e08583a5b5f49e",
"triggerType" : "PUSH"
}, {
"hash" : "9ba683626f0e8cacd5f1a957f441a3dc5ed8052d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29185",
"triggerID" : "9ba683626f0e8cacd5f1a957f441a3dc5ed8052d",
"triggerType" : "PUSH"
}, {
"hash" : "704ffe0a61208970a6b9d6c777faa20deb31780d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29203",
"triggerID" : "704ffe0a61208970a6b9d6c777faa20deb31780d",
"triggerType" : "PUSH"
}, {
"hash" : "86220030570198152807a53f22832770efcd12e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29205",
"triggerID" : "86220030570198152807a53f22832770efcd12e7",
"triggerType" : "PUSH"
}, {
"hash" : "08c8a6f0bb7201b507f08a2b56432bcc94ebe914",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29236",
"triggerID" : "08c8a6f0bb7201b507f08a2b56432bcc94ebe914",
"triggerType" : "PUSH"
}, {
"hash" : "49aa65fadd8ee87ac7c97fd7b3be06f0238c3fcd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29274",
"triggerID" : "49aa65fadd8ee87ac7c97fd7b3be06f0238c3fcd",
"triggerType" : "PUSH"
}, {
"hash" : "eeb8c798bc364480d8e2b5ecf8b55c54397cef14",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29316",
"triggerID" : "eeb8c798bc364480d8e2b5ecf8b55c54397cef14",
"triggerType" : "PUSH"
}, {
"hash" : "1f13ac7621406c519bb21cada599448bda822453",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29417",
"triggerID" : "1f13ac7621406c519bb21cada599448bda822453",
"triggerType" : "PUSH"
}, {
"hash" : "83a05868dd4718112ebcd8f92271d84aa90fa733",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29509",
"triggerID" : "83a05868dd4718112ebcd8f92271d84aa90fa733",
"triggerType" : "PUSH"
}, {
"hash" : "e9f6844ca37bc2cc2fbd2691fa424479a269460b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29528",
"triggerID" : "e9f6844ca37bc2cc2fbd2691fa424479a269460b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 83a05868dd4718112ebcd8f92271d84aa90fa733 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29509)
* e9f6844ca37bc2cc2fbd2691fa424479a269460b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29528)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on a change in pull request #18297: [FLINK-25395][state] Fix TM error handling when uploading shared state
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #18297:
URL: https://github.com/apache/flink/pull/18297#discussion_r785510841
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/changelog/ChangelogStateHandleStreamImpl.java
##########
@@ -83,11 +80,7 @@ public KeyedStateHandle getIntersection(KeyGroupRange keyGroupRange) {
@Override
public void discardState() throws Exception {
- // discard only on TM; on JM, shared state is removed on subsumption
- if (stateRegistry == null) {
- bestEffortDiscardAllStateObjects(
- handlesAndOffsets.stream().map(t2 -> t2.f0).collect(Collectors.toList()));
- }
+ // do nothing: rely on SharedStateRegistry for cleanup after ACK;
Review comment:
I meant acknowledging checkpoint by task to JobManager.
I expaneded the comment:
```
// Do nothing: state will be discarded by SharedStateRegistry once JM receives it and a
// newer checkpoint completes without using it. JM might not receive the handle in the
// following cases:
// 1. hard TM failure
// 2. job termination
// 3. materialization of changes written pre-emptively
// The above cases will be addressed by FLINK-23139 and/or FLINK-24852``
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18297: [FLINK-25395][state] Fix TM error handling when uploading shared state
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18297:
URL: https://github.com/apache/flink/pull/18297#issuecomment-1007316142
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7407da5e58ed7e7d093ddfd048e08583a5b5f49e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29096",
"triggerID" : "7407da5e58ed7e7d093ddfd048e08583a5b5f49e",
"triggerType" : "PUSH"
}, {
"hash" : "9ba683626f0e8cacd5f1a957f441a3dc5ed8052d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29185",
"triggerID" : "9ba683626f0e8cacd5f1a957f441a3dc5ed8052d",
"triggerType" : "PUSH"
}, {
"hash" : "704ffe0a61208970a6b9d6c777faa20deb31780d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29203",
"triggerID" : "704ffe0a61208970a6b9d6c777faa20deb31780d",
"triggerType" : "PUSH"
}, {
"hash" : "86220030570198152807a53f22832770efcd12e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29205",
"triggerID" : "86220030570198152807a53f22832770efcd12e7",
"triggerType" : "PUSH"
}, {
"hash" : "08c8a6f0bb7201b507f08a2b56432bcc94ebe914",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29236",
"triggerID" : "08c8a6f0bb7201b507f08a2b56432bcc94ebe914",
"triggerType" : "PUSH"
}, {
"hash" : "49aa65fadd8ee87ac7c97fd7b3be06f0238c3fcd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29274",
"triggerID" : "49aa65fadd8ee87ac7c97fd7b3be06f0238c3fcd",
"triggerType" : "PUSH"
}, {
"hash" : "eeb8c798bc364480d8e2b5ecf8b55c54397cef14",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29316",
"triggerID" : "eeb8c798bc364480d8e2b5ecf8b55c54397cef14",
"triggerType" : "PUSH"
}, {
"hash" : "1f13ac7621406c519bb21cada599448bda822453",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29417",
"triggerID" : "1f13ac7621406c519bb21cada599448bda822453",
"triggerType" : "PUSH"
}, {
"hash" : "83a05868dd4718112ebcd8f92271d84aa90fa733",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29509",
"triggerID" : "83a05868dd4718112ebcd8f92271d84aa90fa733",
"triggerType" : "PUSH"
}, {
"hash" : "e9f6844ca37bc2cc2fbd2691fa424479a269460b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29528",
"triggerID" : "e9f6844ca37bc2cc2fbd2691fa424479a269460b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e9f6844ca37bc2cc2fbd2691fa424479a269460b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29528)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18297: [FLINK-25395][state] Don't discard shared state on TM
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18297:
URL: https://github.com/apache/flink/pull/18297#issuecomment-1007316142
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7407da5e58ed7e7d093ddfd048e08583a5b5f49e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29096",
"triggerID" : "7407da5e58ed7e7d093ddfd048e08583a5b5f49e",
"triggerType" : "PUSH"
}, {
"hash" : "9ba683626f0e8cacd5f1a957f441a3dc5ed8052d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29185",
"triggerID" : "9ba683626f0e8cacd5f1a957f441a3dc5ed8052d",
"triggerType" : "PUSH"
}, {
"hash" : "704ffe0a61208970a6b9d6c777faa20deb31780d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29203",
"triggerID" : "704ffe0a61208970a6b9d6c777faa20deb31780d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9ba683626f0e8cacd5f1a957f441a3dc5ed8052d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29185)
* 704ffe0a61208970a6b9d6c777faa20deb31780d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29203)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18297: [FLINK-25395][state] Don't discard shared state on TM
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18297:
URL: https://github.com/apache/flink/pull/18297#issuecomment-1007316142
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7407da5e58ed7e7d093ddfd048e08583a5b5f49e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29096",
"triggerID" : "7407da5e58ed7e7d093ddfd048e08583a5b5f49e",
"triggerType" : "PUSH"
}, {
"hash" : "9ba683626f0e8cacd5f1a957f441a3dc5ed8052d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29185",
"triggerID" : "9ba683626f0e8cacd5f1a957f441a3dc5ed8052d",
"triggerType" : "PUSH"
}, {
"hash" : "704ffe0a61208970a6b9d6c777faa20deb31780d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "704ffe0a61208970a6b9d6c777faa20deb31780d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9ba683626f0e8cacd5f1a957f441a3dc5ed8052d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29185)
* 704ffe0a61208970a6b9d6c777faa20deb31780d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18297: [FLINK-25395][state] Don't discard shared state on TM
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18297:
URL: https://github.com/apache/flink/pull/18297#issuecomment-1007316142
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7407da5e58ed7e7d093ddfd048e08583a5b5f49e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29096",
"triggerID" : "7407da5e58ed7e7d093ddfd048e08583a5b5f49e",
"triggerType" : "PUSH"
}, {
"hash" : "9ba683626f0e8cacd5f1a957f441a3dc5ed8052d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29185",
"triggerID" : "9ba683626f0e8cacd5f1a957f441a3dc5ed8052d",
"triggerType" : "PUSH"
}, {
"hash" : "704ffe0a61208970a6b9d6c777faa20deb31780d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29203",
"triggerID" : "704ffe0a61208970a6b9d6c777faa20deb31780d",
"triggerType" : "PUSH"
}, {
"hash" : "86220030570198152807a53f22832770efcd12e7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29205",
"triggerID" : "86220030570198152807a53f22832770efcd12e7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 704ffe0a61208970a6b9d6c777faa20deb31780d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29203)
* 86220030570198152807a53f22832770efcd12e7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29205)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18297: [FLINK-25395][state] Don't discard shared state on TM
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18297:
URL: https://github.com/apache/flink/pull/18297#issuecomment-1007316142
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7407da5e58ed7e7d093ddfd048e08583a5b5f49e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29096",
"triggerID" : "7407da5e58ed7e7d093ddfd048e08583a5b5f49e",
"triggerType" : "PUSH"
}, {
"hash" : "9ba683626f0e8cacd5f1a957f441a3dc5ed8052d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29185",
"triggerID" : "9ba683626f0e8cacd5f1a957f441a3dc5ed8052d",
"triggerType" : "PUSH"
}, {
"hash" : "704ffe0a61208970a6b9d6c777faa20deb31780d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29203",
"triggerID" : "704ffe0a61208970a6b9d6c777faa20deb31780d",
"triggerType" : "PUSH"
}, {
"hash" : "86220030570198152807a53f22832770efcd12e7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "86220030570198152807a53f22832770efcd12e7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 704ffe0a61208970a6b9d6c777faa20deb31780d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29203)
* 86220030570198152807a53f22832770efcd12e7 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org