You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by trixpan <gi...@git.apache.org> on 2017/04/01 08:18:21 UTC
[GitHub] nifi pull request #1644: NIFI-11 - Capture StringIndexOutOfBoundsException t...
GitHub user trixpan opened a pull request:
https://github.com/apache/nifi/pull/1644
NIFI-11 - Capture StringIndexOutOfBoundsException to prevent failed e\u2026
\u2026valuations from disrupting flow
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [X] Have you written or updated unit tests to verify your changes?
- [X] ~~~If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?~~~
- [X] ~~~If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?~~~
- [X] ~~~If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?~~~
- [X] ~~~If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?~~~
### For documentation related changes:
- [X] ~~~Have you ensured that format looks appropriate for the output in which it is rendered?~~~
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/trixpan/nifi NIFI-11
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1644.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1644
----
commit 2e602f05aefee5e6cb99fa405dad887bcb5602c2
Author: Andre F de Miranda <tr...@users.noreply.github.com>
Date: 2017-04-01T08:12:58Z
NIFI-11 - Capture StringIndexOutOfBoundsException to prevent failed evaluations from disrupting flow
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1644: NIFI-11 - Capture StringIndexOutOfBoundsException to preve...
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1644
Pretty sure it still needs an update.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1644: NIFI-11 - Capture StringIndexOutOfBoundsException t...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/1644
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1644: NIFI-11 - Capture StringIndexOutOfBoundsException to preve...
Posted by trixpan <gi...@git.apache.org>.
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1644
@mcgilman Hopefully I managed to address your feedback in this last iteration
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1644: NIFI-11 - Capture StringIndexOutOfBoundsException to preve...
Posted by trixpan <gi...@git.apache.org>.
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1644
@mcgilman indeed. Hopefully the last commit should address the remaining ones.
Cheers
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1644: NIFI-11 - Capture StringIndexOutOfBoundsException to preve...
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1644
@trixpan Sorry for the delay, I must have missed the mention on this PR.
Evaluating EL can lead to different types of Exceptions depending on the issue with the statement (StringIndexOutOfBounds, NumberFormat, etc). If an onTrigger throws a ProcessException, the flowfile will be penalized and the Processor will NOT be administratively yielded. If any other type of Exception escapes, the flowfile will be penalized and the Process will be administratively yielded. I think the issue in this case is that we are only catching ProcessException. As a result all other Exceptions are escaping and causing the Processor to be yielded. I'm thinking the fix is to simply catch Exception and then rethrow ProcessException to prevent the administrative yielding. Thoughts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1644: NIFI-11 - Capture StringIndexOutOfBoundsException to preve...
Posted by trixpan <gi...@git.apache.org>.
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1644
@mcgilman - I gave it a try in finding a solution. Happy to adjust in case you think it is needed.
Cheers
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1644: NIFI-11 - Capture StringIndexOutOfBoundsException to preve...
Posted by trixpan <gi...@git.apache.org>.
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1644
@mcgilman - Sorry for the delay.
rebased and hopefully addressed the jUnit issue
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1644: NIFI-11 - Capture StringIndexOutOfBoundsException to preve...
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1644
@trixpan I believe there a couple other instances where we are evaluating an expression where we are still just catching ProcessException. Specifically, I believe we also need this adjustment when evaluating conditions and considering attributes to delete.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1644: NIFI-11 - Capture StringIndexOutOfBoundsException to preve...
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1644
Thanks @trixpan! This has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1644: NIFI-11 - Capture StringIndexOutOfBoundsException to preve...
Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on the issue:
https://github.com/apache/nifi/pull/1644
@trixpan and @mcgilman is this ready/close or does it need another commit? Could not quite tell from the history if there was a new commit and already squashed or not.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1644: NIFI-11 - Capture StringIndexOutOfBoundsException to preve...
Posted by trixpan <gi...@git.apache.org>.
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1644
@mcgilman makes total sense. Will adjust
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1644: NIFI-11 - Capture StringIndexOutOfBoundsException to preve...
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1644
@trixpan I think the most recent commit does address the remaining spots, however it appears break a unit test. Do you mind updating? Looking at the failure in the Travis build, I believe the new exception is the desirable behavior.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---