You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/11/27 08:50:32 UTC

[GitHub] [tvm] comaniac commented on pull request #6981: [AutoScheduler] Accelerate feature extraction for winograd

comaniac commented on pull request #6981:
URL: https://github.com/apache/tvm/pull/6981#issuecomment-734720123


   I like the idea in general as it may also benefit other workloads that uses selects, but I have some concerns about the new attribute and flag.
   
   For the `const_matrix` attribute, it might be confusing in the future about what does it mean and why. It might be better to make it more feature extraction specific, such as `ignore_feature_extraction`.
   
   In addition, the `feature_extraction_mode` looks a bit ad-hoc. I would rather having a separate API instead of sharing `normalize` and only use it when extracting feature. This separation can also make sure the extensibility of feature improvements in the future.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org