You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/09 11:30:39 UTC

[GitHub] [arrow] johanpel commented on pull request #11908: ARROW-15030: [C++] CSV writer test failures

johanpel commented on pull request #11908:
URL: https://github.com/apache/arrow/pull/11908#issuecomment-989767970


   I can reproduce it now indeed, thanks.
   
   If I understand correctly, erroneous status messages created through the `ARROW_RETURN_IF_` macro are different depending on this flag.
   
   In this case, it means you cannot check error messages that are contained within such a status, so you can only check whether the StatusCode matches, but not whether the message is as expected.
   
   I will update the PR to fix this.
   
   Since the context information only exists for debugging purposes, would it be an idea to somehow exclude it from status equality predicates, such that tests with/without the flag do not differ in outcome?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org