You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ant.apache.org by GitBox <gi...@apache.org> on 2021/10/03 11:39:18 UTC

[GitHub] [ant] arturobernalg commented on pull request #163: Make final var when is possible.

arturobernalg commented on pull request #163:
URL: https://github.com/apache/ant/pull/163#issuecomment-932933258


   > This is a huge change when it comes to the number of lines touched. When faced with such a big change I always fear I may overlook something subtle.
   > 
   > Personally I don't believe making the argument of a one-line method that just calls another method passing on the argument is improving anything. YMMV.
   
   HI @bodewig 
   I close the PR
   TY


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org