You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apex.apache.org by davidyan74 <gi...@git.apache.org> on 2016/04/12 01:47:13 UTC
[GitHub] incubator-apex-core pull request: APEXCORE-427 Made pubsub connect...
GitHub user davidyan74 opened a pull request:
https://github.com/apache/incubator-apex-core/pull/302
APEXCORE-427 Made pubsub connect timeout configurable
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/davidyan74/incubator-apex-core APEXCORE-427
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-apex-core/pull/302.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #302
----
commit 20a2858c9fee28ff3407afbb16f1ac687fed3b41
Author: David Yan <da...@datatorrent.com>
Date: 2016-04-11T23:46:43Z
APEXCORE-427 Made pubsub connect timeout configurable
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEXCORE-427 Made pubsub connect...
Posted by tweise <gi...@git.apache.org>.
Github user tweise commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/302#discussion_r59306808
--- Diff: api/src/main/java/com/datatorrent/api/Context.java ---
@@ -438,6 +438,10 @@
*/
Attribute<String> GATEWAY_PASSWORD = new Attribute<String>(new String2String());
/**
+ * The timeout when connecting to the pubsub service in gateway
+ */
+ Attribute<Integer> PUBSUB_CONNECT_TIMEOUT_MILLIS = new Attribute<>(500);
--- End diff --
Why are you not making this part of the URL?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEXCORE-427 Made pubsub connect...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-apex-core/pull/302
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEXCORE-427 Made pubsub connect...
Posted by davidyan74 <gi...@git.apache.org>.
Github user davidyan74 commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/302#issuecomment-208626432
@vrozov please review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---