You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Martin Hauner <Ma...@gmx.net> on 2006/08/01 16:10:14 UTC
[PATCH] use MacOSX network location web proxy settings
Hi,
using my Mac mostly from two locations with one having no proxy and the
other having a proxy i always have to edit subversions proxy settings
after changing location to access a repository. Of course, I always see
at first a subversion error before I do remember to edit the servers
file. ;)
Since MacOSX has network location specific proxy settings i though it
wouldn't be a bad idea if subversion would use them.
So I wrote a patch that reads the proxy information from the system if
'http-system-proxy' is set in the global section of the servers config
file.
The patch works but has a few (small) issues:
- I have no idea how to read proxy username/password from the MacOSX
settings. I didn't find any documention how to do this.
- To keep the patch simple on the first run and to avoid splitting up
the existing code blocks that read the configuration sections the
MacOSX specific code also reads the timeout/compression/neon_debug
options from the global section.
- I simply added the required framework to LIBS in configure.in. I
guess that is not the preferred solution.
The log message is part of the attached patch.
--
Martin
Subcommander 1.1.1, http://subcommander.tigris.org
a cross platform Win32/Unix/MacOSX subversion gui
client & diff/merge tool.
Echte DSL-Flatrate dauerhaft für 0,- Euro*. Nur noch kurze Zeit!
"Feel free" mit GMX DSL: http://www.gmx.net/de/go/dsl
Re: [PATCH] use MacOSX network location web proxy settings
Posted by Garrett Rooney <ro...@electricjellyfish.net>.
On 9/19/06, Malcolm Rowe <ma...@farside.org.uk> wrote:
> On Mon, Aug 14, 2006 at 09:56:54PM +0100, Julian Foad wrote:
> > Is there any Mac user reading this who could say anything useful about this?
> >
>
> I'm a Mac user, but I don't use the locations feature, so I can't really
> comment much.
Ditto.
> Keychain probably knows the proxy server's username and password.
> We would probably want to link in the Keychain framework for this even
> if the Keychain secure password storage (--enable-keychain) was disabled.
>
> Adding the framework line to LIBS is probably correct, though suboptimal
> - see the equivalent comment in configure.in for Keychain support.
> We probably want a configure test rather than a hardcoded platform
> check though.
>
> Finally, shouldn't we just do this by default? If you have a system-level
> proxy server set up (under Mac OS X or Windows), it would typically make
> sense to use it. I can see that we might want to set something to switch
> off that behaviour and go direct, but it the default should be to use it, no?
Agreed.
-garrett
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] use MacOSX network location web proxy settings
Posted by Malcolm Rowe <ma...@farside.org.uk>.
On Mon, Aug 14, 2006 at 09:56:54PM +0100, Julian Foad wrote:
> Is there any Mac user reading this who could say anything useful about this?
>
I'm a Mac user, but I don't use the locations feature, so I can't really
comment much.
Keychain probably knows the proxy server's username and password.
We would probably want to link in the Keychain framework for this even
if the Keychain secure password storage (--enable-keychain) was disabled.
Adding the framework line to LIBS is probably correct, though suboptimal
- see the equivalent comment in configure.in for Keychain support.
We probably want a configure test rather than a hardcoded platform
check though.
Finally, shouldn't we just do this by default? If you have a system-level
proxy server set up (under Mac OS X or Windows), it would typically make
sense to use it. I can see that we might want to set something to switch
off that behaviour and go direct, but it the default should be to use it, no?
Regards,
Malcolm
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] use MacOSX network location web proxy settings
Posted by Julian Foad <ju...@btopenworld.com>.
Is there any Mac user reading this who could say anything useful about this?
Martin Hauner wrote in <http://svn.haxx.se/dev/archive-2006-08/0049.shtml>:
>
> using my Mac mostly from two locations with one having no proxy and the
> other having a proxy i always have to edit subversions proxy settings
> after changing location to access a repository. Of course, I always see
> at first a subversion error before I do remember to edit the servers
> file. ;)
>
> Since MacOSX has network location specific proxy settings i though it
> wouldn't be a bad idea if subversion would use them.
>
> So I wrote a patch that reads the proxy information from the system if
> 'http-system-proxy' is set in the global section of the servers config
> file.
>
> The patch works but has a few (small) issues:
>
> - I have no idea how to read proxy username/password from the MacOSX
> settings. I didn't find any documention how to do this.
>
> - To keep the patch simple on the first run and to avoid splitting up
> the existing code blocks that read the configuration sections the
> MacOSX specific code also reads the timeout/compression/neon_debug
> options from the global section.
>
> - I simply added the required framework to LIBS in configure.in. I
> guess that is not the preferred solution.
>
>
> The log message is part of the attached patch.
[The patch is in the archived message.]
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org