You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-commits@jackrabbit.apache.org by md...@apache.org on 2012/08/21 17:48:52 UTC

svn commit: r1375620 - in /jackrabbit/oak/trunk: oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/identifier/IdentifierManager.java oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/RepositoryTest.java

Author: mduerig
Date: Tue Aug 21 15:48:51 2012
New Revision: 1375620

URL: http://svn.apache.org/viewvc?rev=1375620&view=rev
Log:
OAK-101: implement identifier handling (byUUID, byIdentifier, etc)

Modified:
    jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/identifier/IdentifierManager.java
    jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/RepositoryTest.java

Modified: jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/identifier/IdentifierManager.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/identifier/IdentifierManager.java?rev=1375620&r1=1375619&r2=1375620&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/identifier/IdentifierManager.java (original)
+++ jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/identifier/IdentifierManager.java Tue Aug 21 15:48:51 2012
@@ -190,7 +190,6 @@ public class IdentifierManager {
                 String pName = propertyName == null ? "*" : propertyName;   // TODO: sanitize against injection attacks!?
                 Map<String, ? extends CoreValue> bindings = Collections.singletonMap("uuid", new StringValue(uuid));
 
-                // TODO query depends on OAK-261
                 Result result = queryEngine.executeQuery(
                         "SELECT * FROM [nt:base] WHERE PROPERTY([" + pName + "], '" + reference + "') = $uuid",
                         Query.JCR_SQL2, Long.MAX_VALUE, 0, bindings, new NamePathMapper.Default());

Modified: jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/RepositoryTest.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/RepositoryTest.java?rev=1375620&r1=1375619&r2=1375620&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/RepositoryTest.java (original)
+++ jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/RepositoryTest.java Tue Aug 21 15:48:51 2012
@@ -999,7 +999,6 @@ public class RepositoryTest extends Abst
     }
 
     @Test
-    @Ignore("OAK-261")  //  TODO OAK-261: Support querying on property types
     public void getNamedReferences() throws RepositoryException {
         Session session = getAdminSession();
         Node referee = getNode("/foo");
@@ -1032,7 +1031,6 @@ public class RepositoryTest extends Abst
     }
 
     @Test
-    @Ignore("OAK-261")  //  TODO OAK-261: Support querying on property types
     public void getNamedWeakReferences() throws RepositoryException {
         Session session = getAdminSession();
         Node referee = getNode("/foo");