You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Laszlo Hornyak <lh...@redhat.com> on 2012/11/11 19:16:04 UTC
Review Request: Removed redundant imports from VolumeHostDao and
VolumeHostDaoImpl
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8011/
-----------------------------------------------------------
Review request for cloudstack.
Description
-------
just testing if I got the process right...
Diffs
-----
server/src/com/cloud/storage/dao/VolumeHostDao.java 4ec69c3
server/src/com/cloud/storage/dao/VolumeHostDaoImpl.java 389f8c0
Diff: https://reviews.apache.org/r/8011/diff/
Testing
-------
Thanks,
Laszlo Hornyak
Re: Review Request: Removed redundant imports from VolumeHostDao and
VolumeHostDaoImpl
Posted by Prasanna Santhanam <Pr...@citrix.com>.
> On Nov. 14, 2012, 8:49 a.m., Prasanna Santhanam wrote:
> > Looks good to me
Please close the review as submitted. Thanks,
commit 499a28cb43948fe0c9de0abfb8be4be970f7283b
Author: Laszlo Hornyak <lh...@redhat.com>
Date: Sun Nov 11 19:09:30 2012 +0100
Removed redundant imports from VolumeHostDao
Signed-off-by: Laszlo Hornyak <lh...@redhat.com>
Signed-off-by: Prasanna Santhanam <ts...@apache.org> 1352883689 +0530
- Prasanna
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8011/#review13420
-----------------------------------------------------------
On Nov. 11, 2012, 6:16 p.m., Laszlo Hornyak wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8011/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2012, 6:16 p.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> just testing if I got the process right...
>
>
> Diffs
> -----
>
> server/src/com/cloud/storage/dao/VolumeHostDao.java 4ec69c3
> server/src/com/cloud/storage/dao/VolumeHostDaoImpl.java 389f8c0
>
> Diff: https://reviews.apache.org/r/8011/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Laszlo Hornyak
>
>
Re: Review Request: Removed redundant imports from VolumeHostDao and
VolumeHostDaoImpl
Posted by Prasanna Santhanam <Pr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8011/#review13420
-----------------------------------------------------------
Ship it!
Looks good to me
- Prasanna Santhanam
On Nov. 11, 2012, 6:16 p.m., Laszlo Hornyak wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8011/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2012, 6:16 p.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> just testing if I got the process right...
>
>
> Diffs
> -----
>
> server/src/com/cloud/storage/dao/VolumeHostDao.java 4ec69c3
> server/src/com/cloud/storage/dao/VolumeHostDaoImpl.java 389f8c0
>
> Diff: https://reviews.apache.org/r/8011/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Laszlo Hornyak
>
>