You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@storm.apache.org by bo...@apache.org on 2016/01/11 20:08:24 UTC
[2/4] storm git commit: Updating defaults based on the review
Updating defaults based on the review
Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/2de46793
Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/2de46793
Diff: http://git-wip-us.apache.org/repos/asf/storm/diff/2de46793
Branch: refs/heads/master
Commit: 2de46793572ee55a32f73c3ecb3002f6a8db936d
Parents: e36bc47
Author: Arun Mahadevan <ai...@hortonworks.com>
Authored: Thu Dec 17 11:06:45 2015 +0530
Committer: Arun Mahadevan <ai...@hortonworks.com>
Committed: Thu Dec 17 11:06:45 2015 +0530
----------------------------------------------------------------------
.../main/java/org/apache/storm/hdfs/bolt/AbstractHdfsBolt.java | 5 ++---
.../src/main/java/org/apache/storm/hive/common/HiveOptions.java | 5 ++---
2 files changed, 4 insertions(+), 6 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/storm/blob/2de46793/external/storm-hdfs/src/main/java/org/apache/storm/hdfs/bolt/AbstractHdfsBolt.java
----------------------------------------------------------------------
diff --git a/external/storm-hdfs/src/main/java/org/apache/storm/hdfs/bolt/AbstractHdfsBolt.java b/external/storm-hdfs/src/main/java/org/apache/storm/hdfs/bolt/AbstractHdfsBolt.java
index 3ec4997..995066c 100644
--- a/external/storm-hdfs/src/main/java/org/apache/storm/hdfs/bolt/AbstractHdfsBolt.java
+++ b/external/storm-hdfs/src/main/java/org/apache/storm/hdfs/bolt/AbstractHdfsBolt.java
@@ -49,10 +49,9 @@ public abstract class AbstractHdfsBolt extends BaseRichBolt {
private static final Logger LOG = LoggerFactory.getLogger(AbstractHdfsBolt.class);
private static final Integer DEFAULT_RETRY_COUNT = 3;
/**
- * A low default value so that tuples are flushed and acked as soon as possible to avoid
- * replay and spouts can continue emitting without hitting TOPOLOGY_MAX_SPOUT_PENDING.
+ * Half of the default Config.TOPOLOGY_MESSAGE_TIMEOUT_SECS
*/
- private static final int DEFAULT_TICK_TUPLE_INTERVAL_SECS = 1;
+ private static final int DEFAULT_TICK_TUPLE_INTERVAL_SECS = 15;
protected ArrayList<RotationAction> rotationActions = new ArrayList<RotationAction>();
private Path currentFile;
http://git-wip-us.apache.org/repos/asf/storm/blob/2de46793/external/storm-hive/src/main/java/org/apache/storm/hive/common/HiveOptions.java
----------------------------------------------------------------------
diff --git a/external/storm-hive/src/main/java/org/apache/storm/hive/common/HiveOptions.java b/external/storm-hive/src/main/java/org/apache/storm/hive/common/HiveOptions.java
index e0e4d74..8c2f55d 100644
--- a/external/storm-hive/src/main/java/org/apache/storm/hive/common/HiveOptions.java
+++ b/external/storm-hive/src/main/java/org/apache/storm/hive/common/HiveOptions.java
@@ -27,10 +27,9 @@ import org.apache.hive.hcatalog.streaming.*;
public class HiveOptions implements Serializable {
/**
- * A low default value so that tuples are flushed and acked as soon as possible to avoid
- * replay and spouts can continue emitting without hitting TOPOLOGY_MAX_SPOUT_PENDING.
+ * Half of the default Config.TOPOLOGY_MESSAGE_TIMEOUT_SECS
*/
- private static final int DEFAULT_TICK_TUPLE_INTERVAL_SECS = 1;
+ private static final int DEFAULT_TICK_TUPLE_INTERVAL_SECS = 15;
protected HiveMapper mapper;
protected String databaseName;