[GitHub] [hive] zabetak commented on pull request #1771: HIVE-24528: Wrong implicit type conversion when comparing decimals and strings

[GitBox <gi...@apache.org>]

zabetak commented on pull request #1771:
URL: https://github.com/apache/hive/pull/1771#issuecomment-744450241


   > What if the string is a very large number that exceeds the max decimal precision?
   
   Other kind of unexpected behavior but maybe better documented. Citing the [wiki](https://cwiki.apache.org/confluence/display/Hive/LanguageManual+Types): _After such a type change, if the data can be shown correctly with the new type, the data will be displayed. Otherwise, the data will be displayed as NULL_ 
   
   I haven't made entirely my mind if its better to keep double or go for decimal but raised a PR to kick-off some discussion and see also the impact on the code base.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org