[GitHub] [iceberg] JingsongLi commented on a change in pull request #1318: Add equality field IDs to DeleteFile

[GitBox <gi...@apache.org>]

JingsongLi commented on a change in pull request #1318:
URL: https://github.com/apache/iceberg/pull/1318#discussion_r468317358



##########
File path: core/src/main/java/org/apache/iceberg/BaseFile.java
##########
@@ -385,7 +399,24 @@ public String toString() {
         .add("lower_bounds", lowerBounds)
         .add("upper_bounds", upperBounds)
         .add("key_metadata", keyMetadata == null ? "null" : "(redacted)")
-        .add("split_offsets", splitOffsets == null ? "null" : splitOffsets)
+        .add("split_offsets", splitOffsets == null ? "null" : splitOffsets())
+        .add("equality_ids", equalityIds == null ? "null" : equalityFieldIds())
         .toString();
   }
+
+  private static int[] toIntArray(List<Integer> ints) {

Review comment:
       If the data class pattern in Iceberg is:
   - stores (primitive) arrays in class field.
   - provides List method to return this field.
   
   Can we add `ArrayUtil` class to provide `toPrimitive` and `toList` utils?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org