You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/04/08 15:38:27 UTC
[GitHub] [ignite] tkalkirill opened a new pull request #8992: IGNITE-14507 wip
tkalkirill opened a new pull request #8992:
URL: https://github.com/apache/ignite/pull/8992
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
### The Contribution Checklist
- [ ] There is a single JIRA ticket related to the pull request.
- [ ] The web-link to the pull request is attached to the JIRA ticket.
- [ ] The JIRA ticket has the _Patch Available_ state.
- [ ] The pull request body describes changes that have been made.
The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
- [ ] The pull request title is treated as the final commit message.
The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
- [ ] A reviewer has been mentioned through the JIRA comments
(see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
- [ ] The pull request has been checked by the Teamcity Bot and
the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
### Notes
- [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
- [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
- [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
- [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] asfgit closed pull request #8992: IGNITE-14507 Un-deprecate IGNITE_BINARY_SORT_OBJECT_FIELDS
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #8992:
URL: https://github.com/apache/ignite/pull/8992
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] alamar commented on a change in pull request #8992: IGNITE-14507 Un-deprecate IGNITE_BINARY_SORT_OBJECT_FIELDS
Posted by GitBox <gi...@apache.org>.
alamar commented on a change in pull request #8992:
URL: https://github.com/apache/ignite/pull/8992#discussion_r610459040
##########
File path: modules/core/src/main/java/org/apache/ignite/IgniteSystemProperties.java
##########
@@ -1012,10 +1012,7 @@
/**
* When set to {@code true} fields are written by BinaryMarshaller in sorted order. Otherwise
* the natural order is used.
- * <p>
- * @deprecated Should be removed in Apache Ignite 2.0.
*/
Review comment:
Can we add a notice that it needs to be made default in Apache Ignite 3.0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] tkalkirill commented on a change in pull request #8992: IGNITE-14507 Un-deprecate IGNITE_BINARY_SORT_OBJECT_FIELDS
Posted by GitBox <gi...@apache.org>.
tkalkirill commented on a change in pull request #8992:
URL: https://github.com/apache/ignite/pull/8992#discussion_r610470543
##########
File path: modules/core/src/main/java/org/apache/ignite/IgniteSystemProperties.java
##########
@@ -1012,10 +1012,7 @@
/**
* When set to {@code true} fields are written by BinaryMarshaller in sorted order. Otherwise
* the natural order is used.
- * <p>
- * @deprecated Should be removed in Apache Ignite 2.0.
*/
Review comment:
Let's notice it in IGNITE-9702
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] alamar commented on a change in pull request #8992: IGNITE-14507 Un-deprecate IGNITE_BINARY_SORT_OBJECT_FIELDS
Posted by GitBox <gi...@apache.org>.
alamar commented on a change in pull request #8992:
URL: https://github.com/apache/ignite/pull/8992#discussion_r610549737
##########
File path: modules/core/src/main/java/org/apache/ignite/IgniteSystemProperties.java
##########
@@ -1012,10 +1012,7 @@
/**
* When set to {@code true} fields are written by BinaryMarshaller in sorted order. Otherwise
* the natural order is used.
- * <p>
- * @deprecated Should be removed in Apache Ignite 2.0.
*/
Review comment:
We can't add notice for 2.x in the ticket filed against 3.0. I think it should be noted in source, you can include ticket link if you like
You can also file a new ticket for 2.x which will introduce sortedField boolean into BinaryConfiguration, if you like to postpone it.
Or just add the notice now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org