[GitHub] [spark] gczsjdy commented on a change in pull request #25007: [SPARK-28209][CORE][SHUFFLE] Proposed new shuffle writer API

[GitBox <gi...@apache.org>]

gczsjdy commented on a change in pull request #25007: [SPARK-28209][CORE][SHUFFLE] Proposed new shuffle writer API 
URL: https://github.com/apache/spark/pull/25007#discussion_r300595585
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/shuffle/sort/SortShuffleManager.scala
 ##########
 @@ -79,6 +83,8 @@ private[spark] class SortShuffleManager(conf: SparkConf) extends ShuffleManager
    */
   private[this] val numMapsForShuffle = new ConcurrentHashMap[Int, Int]()
 
+  private lazy val shuffleExecutorComponents = loadShuffleExecutorComponents(conf)
+
   override val shuffleBlockResolver = new IndexShuffleBlockResolver(conf)
 
 Review comment:
   Should we remove this hardcoded `IndexShuffleBlockResolver`? Due to it's only used in `DefaultShuffleDataIO`. And this `IndexShuffleBlockResolver` has already(as it should be, dealt with in certain implementation) be constructed in https://github.com/apache/spark/blob/2421c928dd35ccaa28825a96bcd3449e94383b59/core/src/main/java/org/apache/spark/shuffle/sort/io/DefaultShuffleExecutorComponents.java#L43

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org