You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by StevenMPhillips <gi...@git.apache.org> on 2016/02/06 00:01:58 UTC

[GitHub] drill pull request: DRILL-3623: Optimize limit 0 queries

GitHub user StevenMPhillips opened a pull request:

    https://github.com/apache/drill/pull/364

    DRILL-3623: Optimize limit 0 queries

    This pulls some patches that Sudheesh had previously worked on but not committed. In addition, fixes some problems when the type is not one of the json ExtendTypes.
    
    There are still problems with float, decimal, and interval_day/year.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/StevenMPhillips/drill limit_0

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/364.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #364
    
----
commit 8c3f2e8911dabc93f7b3f381600ccfaccc008938
Author: Sudheesh Katkam <sk...@maprtech.com>
Date:   2015-11-17T23:12:48Z

    DRILL-3623: Use shorter exec path for LIMIT 0 queries when schema of the root logical node is known
    
    + DRILL-4043: Perform LIMIT 0 optimization before logical transformation

commit 3be63cd5b95891cbfee1bdb6cfa2baaaf18f31c8
Author: Sudheesh Katkam <sk...@maprtech.com>
Date:   2015-12-22T19:07:39Z

    WIP

commit b4061e46fe91b747bc2afe82e66cd6d0bc060d1b
Author: Steven Phillips <st...@dremio.com>
Date:   2016-01-31T01:49:04Z

    Make limit 0 return correct type for VARCHAR
    
    Still does not work correctly for float4, decimal, or interval types

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request: DRILL-3623: Optimize limit 0 queries

Posted by sudheeshkatkam <gi...@git.apache.org>.

Github user sudheeshkatkam commented on the pull request:

    https://github.com/apache/drill/pull/364#issuecomment-182089660
  
    @StevenMPhillips This is still WIP, right?
    
    @hsuanyi and I plan to post an update soon.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request: DRILL-3623: Optimize limit 0 queries

Posted by StevenMPhillips <gi...@git.apache.org>.

Github user StevenMPhillips commented on the pull request:

    https://github.com/apache/drill/pull/364#issuecomment-183008840
  
    @hhsuanyi I did not open any calcite jira. The new calcite version was there from Sudheesh's commit which I pulled in.
    
    @sudheeshkatkam Does your update handle limit 0 for all types?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request: DRILL-3623: Optimize limit 0 queries

Posted by sudheeshkatkam <gi...@git.apache.org>.

Github user sudheeshkatkam commented on the pull request:

    https://github.com/apache/drill/pull/364#issuecomment-183425694
  
    The update does not handle all type (because some types were out of scope). The [latest patch](https://github.com/sudheeshkatkam/drill/commits/limit_zero) (WIP) is rebased on top of Hsuan's work.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---