[GitHub] markusthoemmes commented on issue #3799: Display proper error when sequence invocation fails due to missing component

[GitBox <gi...@apache.org>]

markusthoemmes commented on issue #3799: Display proper error when sequence invocation fails due to missing component
URL: https://github.com/apache/incubator-openwhisk/pull/3799#issuecomment-405692374
 
 
   I think this fix has moved a bit in the wrong direction. The mode @rabbah wants to keep is lazy evaluation of the Futures. While it is true, that all actions will be fetched at the same time, invocation will only wait for the first Future to complete before it starts invoking the sequence. The failing operation will be `invokeNextAction`. We can either attach `recoverWith` to the `invokeNextAction` call or even recover this within `invokeNextAction`. We can then use the current `accounting` object (since that's known when calling `invokeNextAction`) to apply the failure there. That should keep state up to that point (another thing mentioned by @rabbah) and should keep the change simple.
   
   Thoughts?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services