You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@abdera.apache.org by "Jim Ancona (JIRA)" <ji...@apache.org> on 2008/03/19 20:54:24 UTC
[jira] Created: (ABDERA-133) ProviderHelper.isValidEntry()
improperly implements the RFC 4287 validity check
ProviderHelper.isValidEntry() improperly implements the RFC 4287 validity check
-------------------------------------------------------------------------------
Key: ABDERA-133
URL: https://issues.apache.org/jira/browse/ABDERA-133
Project: Abdera
Issue Type: Bug
Affects Versions: 0.4.0
Reporter: Jim Ancona
Priority: Critical
ProviderHelper.isValidEntry() marks entries with an XML content type and no summary element as invalid.
RFC 4287 says:
<code>
o atom:entry elements MUST contain an atom:summary element in either
of the following cases:
* the atom:entry contains an atom:content that has a "src"
attribute (and is thus empty).
* the atom:entry contains content that is encoded in Base64;
i.e., the "type" attribute of atom:content is a MIME media type
[MIMEREG], but is not an XML media type [RFC3023], does not
begin with "text/", and does not end with "/xml" or "+xml".
</code>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ABDERA-133) ProviderHelper.isValidEntry()
improperly implements the RFC 4287 validity check
Posted by "Jim Ancona (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ABDERA-133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Ancona updated ABDERA-133:
------------------------------
Description:
ProviderHelper.isValidEntry() marks entries with an XML content type and no summary element as invalid.
RFC 4287 says:
o atom:entry elements MUST contain an atom:summary element in either
of the following cases:
* the atom:entry contains an atom:content that has a "src"
attribute (and is thus empty).
* the atom:entry contains content that is encoded in Base64;
i.e., the "type" attribute of atom:content is a MIME media type
[MIMEREG], but is not an XML media type [RFC3023], does not
begin with "text/", and does not end with "/xml" or "+xml".
was:
ProviderHelper.isValidEntry() marks entries with an XML content type and no summary element as invalid.
RFC 4287 says:
<code>
o atom:entry elements MUST contain an atom:summary element in either
of the following cases:
* the atom:entry contains an atom:content that has a "src"
attribute (and is thus empty).
* the atom:entry contains content that is encoded in Base64;
i.e., the "type" attribute of atom:content is a MIME media type
[MIMEREG], but is not an XML media type [RFC3023], does not
begin with "text/", and does not end with "/xml" or "+xml".
</code>
> ProviderHelper.isValidEntry() improperly implements the RFC 4287 validity check
> -------------------------------------------------------------------------------
>
> Key: ABDERA-133
> URL: https://issues.apache.org/jira/browse/ABDERA-133
> Project: Abdera
> Issue Type: Bug
> Affects Versions: 0.4.0
> Reporter: Jim Ancona
> Priority: Critical
>
> ProviderHelper.isValidEntry() marks entries with an XML content type and no summary element as invalid.
> RFC 4287 says:
> o atom:entry elements MUST contain an atom:summary element in either
> of the following cases:
> * the atom:entry contains an atom:content that has a "src"
> attribute (and is thus empty).
> * the atom:entry contains content that is encoded in Base64;
> i.e., the "type" attribute of atom:content is a MIME media type
> [MIMEREG], but is not an XML media type [RFC3023], does not
> begin with "text/", and does not end with "/xml" or "+xml".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (ABDERA-133) ProviderHelper.isValidEntry()
improperly implements the RFC 4287 validity check
Posted by "James M Snell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ABDERA-133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James M Snell resolved ABDERA-133.
----------------------------------
Resolution: Fixed
Fix Version/s: 0.4.0
fix committed to 0.4.0 branch and trunk
> ProviderHelper.isValidEntry() improperly implements the RFC 4287 validity check
> -------------------------------------------------------------------------------
>
> Key: ABDERA-133
> URL: https://issues.apache.org/jira/browse/ABDERA-133
> Project: Abdera
> Issue Type: Bug
> Affects Versions: 0.4.0
> Reporter: Jim Ancona
> Priority: Critical
> Fix For: 0.4.0
>
> Attachments: ProviderHelper.patch
>
>
> ProviderHelper.isValidEntry() marks entries with an XML content type and no summary element as invalid.
> RFC 4287 says:
> o atom:entry elements MUST contain an atom:summary element in either
> of the following cases:
> * the atom:entry contains an atom:content that has a "src"
> attribute (and is thus empty).
> * the atom:entry contains content that is encoded in Base64;
> i.e., the "type" attribute of atom:content is a MIME media type
> [MIMEREG], but is not an XML media type [RFC3023], does not
> begin with "text/", and does not end with "/xml" or "+xml".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (ABDERA-133) ProviderHelper.isValidEntry()
improperly implements the RFC 4287 validity check
Posted by "James M Snell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ABDERA-133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James M Snell resolved ABDERA-133.
----------------------------------
Resolution: Fixed
checked in
> ProviderHelper.isValidEntry() improperly implements the RFC 4287 validity check
> -------------------------------------------------------------------------------
>
> Key: ABDERA-133
> URL: https://issues.apache.org/jira/browse/ABDERA-133
> Project: Abdera
> Issue Type: Bug
> Affects Versions: 0.4.0
> Reporter: Jim Ancona
> Priority: Critical
> Fix For: 0.4.0
>
> Attachments: ProviderHelper.patch, ProviderHelper2.java.patch
>
>
> ProviderHelper.isValidEntry() marks entries with an XML content type and no summary element as invalid.
> RFC 4287 says:
> o atom:entry elements MUST contain an atom:summary element in either
> of the following cases:
> * the atom:entry contains an atom:content that has a "src"
> attribute (and is thus empty).
> * the atom:entry contains content that is encoded in Base64;
> i.e., the "type" attribute of atom:content is a MIME media type
> [MIMEREG], but is not an XML media type [RFC3023], does not
> begin with "text/", and does not end with "/xml" or "+xml".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ABDERA-133) ProviderHelper.isValidEntry()
improperly implements the RFC 4287 validity check
Posted by "Jim Ancona (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ABDERA-133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Ancona updated ABDERA-133:
------------------------------
Attachment: ProviderHelper2.java.patch
Patch for the new issue
> ProviderHelper.isValidEntry() improperly implements the RFC 4287 validity check
> -------------------------------------------------------------------------------
>
> Key: ABDERA-133
> URL: https://issues.apache.org/jira/browse/ABDERA-133
> Project: Abdera
> Issue Type: Bug
> Affects Versions: 0.4.0
> Reporter: Jim Ancona
> Priority: Critical
> Fix For: 0.4.0
>
> Attachments: ProviderHelper.patch, ProviderHelper2.java.patch
>
>
> ProviderHelper.isValidEntry() marks entries with an XML content type and no summary element as invalid.
> RFC 4287 says:
> o atom:entry elements MUST contain an atom:summary element in either
> of the following cases:
> * the atom:entry contains an atom:content that has a "src"
> attribute (and is thus empty).
> * the atom:entry contains content that is encoded in Base64;
> i.e., the "type" attribute of atom:content is a MIME media type
> [MIMEREG], but is not an XML media type [RFC3023], does not
> begin with "text/", and does not end with "/xml" or "+xml".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ABDERA-133) ProviderHelper.isValidEntry()
improperly implements the RFC 4287 validity check
Posted by "Jim Ancona (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ABDERA-133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Ancona updated ABDERA-133:
------------------------------
Attachment: ProviderHelper.patch
Patch which fixes the issue
> ProviderHelper.isValidEntry() improperly implements the RFC 4287 validity check
> -------------------------------------------------------------------------------
>
> Key: ABDERA-133
> URL: https://issues.apache.org/jira/browse/ABDERA-133
> Project: Abdera
> Issue Type: Bug
> Affects Versions: 0.4.0
> Reporter: Jim Ancona
> Priority: Critical
> Attachments: ProviderHelper.patch
>
>
> ProviderHelper.isValidEntry() marks entries with an XML content type and no summary element as invalid.
> RFC 4287 says:
> o atom:entry elements MUST contain an atom:summary element in either
> of the following cases:
> * the atom:entry contains an atom:content that has a "src"
> attribute (and is thus empty).
> * the atom:entry contains content that is encoded in Base64;
> i.e., the "type" attribute of atom:content is a MIME media type
> [MIMEREG], but is not an XML media type [RFC3023], does not
> begin with "text/", and does not end with "/xml" or "+xml".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (ABDERA-133) ProviderHelper.isValidEntry()
improperly implements the RFC 4287 validity check
Posted by "Jim Ancona (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ABDERA-133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Ancona reopened ABDERA-133:
-------------------------------
I found another issue in this method. Checking for the atom:author tag is incorrect--it fails when the eleme3nt is inside the source element, rather than in the entry itself.
> ProviderHelper.isValidEntry() improperly implements the RFC 4287 validity check
> -------------------------------------------------------------------------------
>
> Key: ABDERA-133
> URL: https://issues.apache.org/jira/browse/ABDERA-133
> Project: Abdera
> Issue Type: Bug
> Affects Versions: 0.4.0
> Reporter: Jim Ancona
> Priority: Critical
> Fix For: 0.4.0
>
> Attachments: ProviderHelper.patch
>
>
> ProviderHelper.isValidEntry() marks entries with an XML content type and no summary element as invalid.
> RFC 4287 says:
> o atom:entry elements MUST contain an atom:summary element in either
> of the following cases:
> * the atom:entry contains an atom:content that has a "src"
> attribute (and is thus empty).
> * the atom:entry contains content that is encoded in Base64;
> i.e., the "type" attribute of atom:content is a MIME media type
> [MIMEREG], but is not an XML media type [RFC3023], does not
> begin with "text/", and does not end with "/xml" or "+xml".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.