You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by necosta <gi...@git.apache.org> on 2017/06/21 16:25:03 UTC
[GitHub] zeppelin pull request #2425: [ZEPPELIN-2673] - Helium skip node install
GitHub user necosta opened a pull request:
https://github.com/apache/zeppelin/pull/2425
[ZEPPELIN-2673] - Helium skip node install
### What is this PR for?
Skip altogether the install of NPM. Node and YarnPkg when the packages have been successfully downloaded into the node installer dir (default ../local-repo/helium-bundles/node/)
### What type of PR is it?
Bug Fix
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-2673
### How should this be tested?
Open Zeppelin > Helium > Enable Plugin > Check NPM/Node install > Stop Zeppelin > Start Zeppelin > Enable Plugin > Check skip of NPM/Node install
### Questions:
* Does the licenses files need update? N
* Is there breaking changes for older versions? N
* Does this needs documentation? N
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nokia/zeppelin helium_skip_node_install
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2425.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2425
----
commit b24f4ff026c0213b11e5501be5391451839461d2
Author: Nelson Costa <ne...@gmail.com>
Date: 2017-06-21T15:00:02Z
Skip Helium Node and NPM re-install after Zeppelin re-start
commit 05459aaa9584e222a14262930068b3c98e8c1dcc
Author: Nelson Costa <ne...@gmail.com>
Date: 2017-06-21T16:15:30Z
ESPOOBL-1625: Refactor check mode
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2425: [ZEPPELIN-2673] - Helium skip node install
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2425
@necosta I forgot to ask your env. What is your OS and it's version?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2425: [ZEPPELIN-2673] - Helium skip node install
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2425
Does Zeppelin already check whether node + npm + yarn is installed or not?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2425: [ZEPPELIN-2673] - Helium skip node install
Posted by necosta <gi...@git.apache.org>.
Github user necosta commented on the issue:
https://github.com/apache/zeppelin/pull/2425
Ok, let me check this in more detail.
Looks that the plugin does check and skip install in certain conditions and when versions match.
However not working for me.
I'll close the pull request for now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2425: [ZEPPELIN-2673] - Helium skip node install
Posted by necosta <gi...@git.apache.org>.
Github user necosta closed the pull request at:
https://github.com/apache/zeppelin/pull/2425
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---