You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spamassassin.apache.org by du...@apache.org on 2005/08/28 05:28:50 UTC

svn commit: r263805 - /spamassassin/branches/3.1/spamd/spamd.raw

Author: duncf
Date: Sat Aug 27 20:28:48 2005
New Revision: 263805

URL: http://svn.apache.org/viewcvs?rev=263805&view=rev
Log:
Bug 4552: Uninitialized values in spamd when processing TELL commands.

Modified:
    spamassassin/branches/3.1/spamd/spamd.raw

Modified: spamassassin/branches/3.1/spamd/spamd.raw
URL: http://svn.apache.org/viewcvs/spamassassin/branches/3.1/spamd/spamd.raw?rev=263805&r1=263804&r2=263805&view=diff
==============================================================================
--- spamassassin/branches/3.1/spamd/spamd.raw (original)
+++ spamassassin/branches/3.1/spamd/spamd.raw Sat Aug 27 20:28:48 2005
@@ -1475,18 +1475,21 @@
     push(@did_remove, 'remote') if ($msgrpt->revoke());
   }
 
-  my $hdr;
-  my $info_set_str;
-  my $info_remove_str;
+  my $hdr = "";
+  my $info_str;
 
   if (scalar(@did_set)) {
     $hdr .= "DidSet: " . join(',', @did_set) . "\r\n";
-    $info_set_str = " Setting " . join(',', @did_set) . " ";
+    $info_str .= " Setting " . join(',', @did_set) . " ";
   }
 
   if (scalar(@did_remove)) {
     $hdr .= "DidRemove: " . join(',', @did_remove) . "\r\n";
-    $info_remove_str = " Removing " . join(',', @did_remove) . " ";
+    $info_str .= " Removing " . join(',', @did_remove) . " ";
+  }
+
+  if (!$info_str) {
+    $info_str = " Did nothing ";
   }
 
   print $client "SPAMD/1.1 $resphash{$resp} $resp\r\n",
@@ -1494,7 +1497,7 @@
 
   my $scantime = sprintf( "%.1f", time - $start_time );
 
-  info("spamd:$info_set_str$info_remove_str for $current_user:$> in"
+  info("spamd: Tell:${info_str}for $current_user:$> in"
        . " $scantime seconds, $actual_length bytes");
 
   $mail->finish();