You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jakarta.apache.org by bu...@apache.org on 2010/10/21 09:43:59 UTC
DO NOT REPLY [Bug 50134] New: TransactionController : Reports bad
response time when it contains other TransactionControllers
https://issues.apache.org/bugzilla/show_bug.cgi?id=50134
Summary: TransactionController : Reports bad response time when
it contains other TransactionControllers
Product: JMeter
Version: 2.4
Platform: All
OS/Version: All
Status: NEW
Severity: blocker
Priority: P2
Component: Main
AssignedTo: notifications@jakarta.apache.org
ReportedBy: p.mouawad@ubik-ingenierie.com
Created an attachment (id=26197)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=26197)
Screenshot showing bug
Hello,
I have a case where I nested a TransactionController inside another.
See attached test JMX called bug.jmx.
What happens is root TransactionController cumulates times of its insider
transaction controller, see attached screenshot.
scenario4 has time of 16124 instead of having 8063.
This issue affects 2.4 and nightly build of 21/10/2010.
I will submit a patch in minutes.
Regards
Philippe M.
http://www.ubik-ingenierie.com
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org
DO NOT REPLY [Bug 50134] TransactionController : Reports bad
response time when it contains other TransactionControllers
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50134
--- Comment #12 from Philippe Mouawad <p....@ubik-ingenierie.com> 2010-11-01 06:11:47 EDT ---
Created an attachment (id=26245)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=26245)
Patch to issue
Hello,
I analyzed a bit more what was happening.
I think I understood where the issue comes from.
As the plan is built, here is how sampleOccured in TransactionController is
called:
SampleOccured :s4-1-s1 in :s4-chapeau
SampleOccured :s4-1-s1 in :scenario5
SampleOccured :s4-1-s2 in :s4-chapeau
SampleOccured :s4-1-s2 in :scenario5
SampleOccured :s4-chapeau in :scenario5
This is because scenario5 and s4-chapeau are both registered as listeners for
each sample, this end up in the upper most parent recording twice things and
mixing up pause time.
In my analysis there are 2 types of SampleEvent:
- One that is initiated by a real Sample
- One that is initiated "artificially" by TransactionController#next2, this one
should not be used in computations
So my idea was to distinguish them by an additional attribute called
isTransactionSampleEvent.
I use this attribute setting it to true in next2() to build the SampleEvent
and use it in sampleOccured() to use it in computation or not.
I tested with the existing test plan and the one that is a bit more complicated
and it works.
But I think you have the big picture to validate this modification.
By the way you will notice some changes in SampleEvent because I made some
refactoring in the constructor to make them use each others instead of
copy/paste.
Thank you for your time and great product and hope you will have some time to
take this patch into account.
Regards
Philippe M.
http://www.ubik-ingenierie.com
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org
DO NOT REPLY [Bug 50134] TransactionController : Reports bad
response time when it contains other TransactionControllers
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50134
Philippe Mouawad <p....@ubik-ingenierie.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEEDINFO |NEW
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org
DO NOT REPLY [Bug 50134] TransactionController : Reports bad
response time when it contains other TransactionControllers
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50134
Philippe Mouawad <p....@ubik-ingenierie.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEEDINFO |NEW
--- Comment #9 from Philippe Mouawad <p....@ubik-ingenierie.com> 2010-10-21 12:49:50 EDT ---
Sorry sebb, You can remove all disabled objects, thé scénario to use is S5.
You run it and in résults you Will see that scénario 5 has wrong response Time
it cumulates all its inner response Time even when on transactioncontroller
contains another one.
I Can upload new jmx within tomorrow if you really need it.
I submitted thé patch to bug and tested it successfully.
Thank you
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org
DO NOT REPLY [Bug 50134] TransactionController : Reports bad
response time when it contains other TransactionControllers
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50134
Sebb <se...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |NEEDINFO
--- Comment #5 from Sebb <se...@apache.org> 2010-10-21 06:36:58 EDT ---
Would it be possible to provide a simpler test case using just Java Request
samplers?
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org
DO NOT REPLY [Bug 50134] TransactionController : Reports bad
response time when it contains other TransactionControllers
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50134
--- Comment #4 from Philippe Mouawad <p....@ubik-ingenierie.com> 2010-10-21 03:58:02 EDT ---
Hello,
I submitted the patch, hope you can take it into account soon.
Thank you
Regards
Philippe M.
http://www.ubik-ingenierie.com
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org
DO NOT REPLY [Bug 50134] TransactionController : Reports bad
response time when it contains other TransactionControllers
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50134
--- Comment #3 from Philippe Mouawad <p....@ubik-ingenierie.com> 2010-10-21 03:56:51 EDT ---
Created an attachment (id=26200)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=26200)
Patch to the bug
This patch corrects the issue.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org
DO NOT REPLY [Bug 50134] TransactionController : Reports bad
response time when it contains other TransactionControllers
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50134
--- Comment #1 from Philippe Mouawad <p....@ubik-ingenierie.com> 2010-10-21 03:46:10 EDT ---
Created an attachment (id=26198)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=26198)
JMX Plan showing issue
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org
DO NOT REPLY [Bug 50134] TransactionController : Reports bad
response time when it contains other TransactionControllers
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50134
--- Comment #6 from Philippe Mouawad <p....@ubik-ingenierie.com> 2010-10-21 10:06:57 EDT ---
Created an attachment (id=26201)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=26201)
Simpler Test plan
Here is a simpler test based on java samplers.
Philippe M.
http://www.ubik-ingenierie.com
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org
DO NOT REPLY [Bug 50134] TransactionController : Reports bad
response time when it contains other TransactionControllers
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50134
Sebb <se...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |NEEDINFO
--- Comment #8 from Sebb <se...@apache.org> 2010-10-21 11:08:43 EDT ---
Sorry, but the test plan is still quite difficult to follow, as it has disabled
entries and assertions, several thread groups etc.
I've no idea which parts of the plan are relevant.
Time spent fixing the test plan is time that cannot be spent fixing the bug.
Please can you provide the simplest possible plan that shows the problem?
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org
DO NOT REPLY [Bug 50134] TransactionController : Reports bad
response time when it contains other TransactionControllers
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50134
--- Comment #7 from Philippe Mouawad <p....@ubik-ingenierie.com> 2010-10-21 10:07:44 EDT ---
Created an attachment (id=26202)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=26202)
Screenshot showing bug with new Java Sampler JMX
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org
DO NOT REPLY [Bug 50134] TransactionController : Reports bad
response time when it contains other TransactionControllers
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50134
Sebb <se...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #13 from Sebb <se...@apache.org> 2010-11-01 13:01:39 EDT ---
Yes, I think your analysis is correct, and the patch approach is reasonable.
Applied the fix to SVN with some minor changes:
- dropped unnecessary setTransactionSampleEvent and made boolean final
- made new ctor private, as not used externally
- simplified nested conditional block.
- replaced tabs with spaces, and removed spurious blank lines
URL: http://svn.apache.org/viewvc?rev=1029746&view=rev
Log:
Bug 50134 - TransactionController : Reports bad response time when it contains
other TransactionControllers
Modified:
jakarta/jmeter/trunk/src/core/org/apache/jmeter/control/TransactionController.java
jakarta/jmeter/trunk/src/core/org/apache/jmeter/samplers/SampleEvent.java
jakarta/jmeter/trunk/xdocs/changes.xml
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org
DO NOT REPLY [Bug 50134] TransactionController : Reports bad
response time when it contains other TransactionControllers
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50134
--- Comment #2 from Philippe Mouawad <p....@ubik-ingenierie.com> 2010-10-21 03:48:02 EDT ---
Created an attachment (id=26199)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=26199)
JSP for test case
Put this JSP in standard Tomcat 6 inside folder:
examples/jsp/test
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org
DO NOT REPLY [Bug 50134] TransactionController : Reports bad
response time when it contains other TransactionControllers
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50134
Philippe Mouawad <p....@ubik-ingenierie.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #26198|0 |1
is obsolete| |
Attachment #26199|0 |1
is obsolete| |
Attachment #26201|0 |1
is obsolete| |
AssignedTo|notifications@jakarta.apach |p.mouawad@ubik-ingenierie.c
|e.org |om
--- Comment #10 from Philippe Mouawad <p....@ubik-ingenierie.com> 2010-10-21 14:39:02 EDT ---
Created an attachment (id=26203)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=26203)
Cleaned up patch
Sorry It seems I messed up with my JMX, this one is the good one.
Thank you again for your time.
Regards
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org