You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Brenden Matthews <br...@diddyinc.com> on 2013/04/15 23:52:17 UTC
Review Request: Include pre/post-package hook scripts in Hadoop tutorial.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10509/
-----------------------------------------------------------
Review request for mesos.
Description
-------
Include pre/post-package hook scripts in Hadoop tutorial.
Diffs
-----
hadoop/TUTORIAL.sh f8131cd
Diff: https://reviews.apache.org/r/10509/diff/
Testing
-------
Used in production at Airbnb.
Thanks,
Brenden Matthews
Re: Review Request: Include pre/post-package hook scripts in Hadoop tutorial.
Posted by Brenden Matthews <br...@diddyinc.com>.
> On April 15, 2013, 10:30 p.m., Brenden Matthews wrote:
> > There's an error in the diff, but Review Board won't allow me to upload a new patch.
>
> Vinod Kone wrote:
> Hmm.. Thats strange. What is the error message that you get?
This is the error:
The file "hadoop/TUTORIAL.sh" (revision 980a8e3) was not found in the repository
This is the patch:
http://ompldr.org/vaTQwZw/0006-Include-pre-post-package-hook-scripts-in-Hadoop-tuto.patch
- Brenden
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10509/#review19219
-----------------------------------------------------------
On April 15, 2013, 9:52 p.m., Brenden Matthews wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10509/
> -----------------------------------------------------------
>
> (Updated April 15, 2013, 9:52 p.m.)
>
>
> Review request for mesos.
>
>
> Description
> -------
>
> Include pre/post-package hook scripts in Hadoop tutorial.
>
>
> Diffs
> -----
>
> hadoop/TUTORIAL.sh f8131cd
>
> Diff: https://reviews.apache.org/r/10509/diff/
>
>
> Testing
> -------
>
> Used in production at Airbnb.
>
>
> Thanks,
>
> Brenden Matthews
>
>
Re: Review Request: Include pre/post-package hook scripts in Hadoop tutorial.
Posted by Vinod Kone <vi...@gmail.com>.
> On April 15, 2013, 10:30 p.m., Brenden Matthews wrote:
> > There's an error in the diff, but Review Board won't allow me to upload a new patch.
Hmm.. Thats strange. What is the error message that you get?
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10509/#review19219
-----------------------------------------------------------
On April 15, 2013, 9:52 p.m., Brenden Matthews wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10509/
> -----------------------------------------------------------
>
> (Updated April 15, 2013, 9:52 p.m.)
>
>
> Review request for mesos.
>
>
> Description
> -------
>
> Include pre/post-package hook scripts in Hadoop tutorial.
>
>
> Diffs
> -----
>
> hadoop/TUTORIAL.sh f8131cd
>
> Diff: https://reviews.apache.org/r/10509/diff/
>
>
> Testing
> -------
>
> Used in production at Airbnb.
>
>
> Thanks,
>
> Brenden Matthews
>
>
Re: Review Request: Include pre/post-package hook scripts in Hadoop tutorial.
Posted by Vinod Kone <vi...@gmail.com>.
> On April 15, 2013, 10:30 p.m., Brenden Matthews wrote:
> > There's an error in the diff, but Review Board won't allow me to upload a new patch.
>
> Vinod Kone wrote:
> Hmm.. Thats strange. What is the error message that you get?
>
> Brenden Matthews wrote:
> This is the error:
>
> The file "hadoop/TUTORIAL.sh" (revision 980a8e3) was not found in the repository
>
>
> This is the patch:
>
> http://ompldr.org/vaTQwZw/0006-Include-pre-post-package-hook-scripts-in-Hadoop-tuto.patch
>
> Vinod Kone wrote:
> that is strange. the patch format looks fine to me :/. could you rebase off the latest trunk and re-diff to create the patch?
surprisingly, now i can view the diff, but it looks like the wrong diff!
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10509/#review19219
-----------------------------------------------------------
On April 15, 2013, 9:52 p.m., Brenden Matthews wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10509/
> -----------------------------------------------------------
>
> (Updated April 15, 2013, 9:52 p.m.)
>
>
> Review request for mesos.
>
>
> Description
> -------
>
> Include pre/post-package hook scripts in Hadoop tutorial.
>
>
> Diffs
> -----
>
> hadoop/TUTORIAL.sh f8131cd
>
> Diff: https://reviews.apache.org/r/10509/diff/
>
>
> Testing
> -------
>
> Used in production at Airbnb.
>
>
> Thanks,
>
> Brenden Matthews
>
>
Re: Review Request: Include pre/post-package hook scripts in Hadoop tutorial.
Posted by Vinod Kone <vi...@gmail.com>.
> On April 15, 2013, 10:30 p.m., Brenden Matthews wrote:
> > There's an error in the diff, but Review Board won't allow me to upload a new patch.
>
> Vinod Kone wrote:
> Hmm.. Thats strange. What is the error message that you get?
>
> Brenden Matthews wrote:
> This is the error:
>
> The file "hadoop/TUTORIAL.sh" (revision 980a8e3) was not found in the repository
>
>
> This is the patch:
>
> http://ompldr.org/vaTQwZw/0006-Include-pre-post-package-hook-scripts-in-Hadoop-tuto.patch
that is strange. the patch format looks fine to me :/. could you rebase off the latest trunk and re-diff to create the patch?
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10509/#review19219
-----------------------------------------------------------
On April 15, 2013, 9:52 p.m., Brenden Matthews wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10509/
> -----------------------------------------------------------
>
> (Updated April 15, 2013, 9:52 p.m.)
>
>
> Review request for mesos.
>
>
> Description
> -------
>
> Include pre/post-package hook scripts in Hadoop tutorial.
>
>
> Diffs
> -----
>
> hadoop/TUTORIAL.sh f8131cd
>
> Diff: https://reviews.apache.org/r/10509/diff/
>
>
> Testing
> -------
>
> Used in production at Airbnb.
>
>
> Thanks,
>
> Brenden Matthews
>
>
Re: Review Request: Include pre/post-package hook scripts in Hadoop tutorial.
Posted by Brenden Matthews <br...@diddyinc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10509/#review19219
-----------------------------------------------------------
There's an error in the diff, but Review Board won't allow me to upload a new patch.
- Brenden Matthews
On April 15, 2013, 9:52 p.m., Brenden Matthews wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10509/
> -----------------------------------------------------------
>
> (Updated April 15, 2013, 9:52 p.m.)
>
>
> Review request for mesos.
>
>
> Description
> -------
>
> Include pre/post-package hook scripts in Hadoop tutorial.
>
>
> Diffs
> -----
>
> hadoop/TUTORIAL.sh f8131cd
>
> Diff: https://reviews.apache.org/r/10509/diff/
>
>
> Testing
> -------
>
> Used in production at Airbnb.
>
>
> Thanks,
>
> Brenden Matthews
>
>
Re: Review Request: Include pre/post-package hook scripts in Hadoop tutorial.
Posted by Brenden Matthews <br...@diddyinc.com>.
> On April 17, 2013, 7:12 p.m., Ben Mahler wrote:
> > Note that the tutorial outputs the commands that were run, in order to guide users as to what commands they need to run to build. Is that not sufficient information for creating an Airbnb specific build on your end?
I'd rather follow the DRY principal, and also not have to maintain a separate installation procedure. It's possible to reuse the existing one after some slight modifications, and I think this will help others who want to use Mesos as well.
- Brenden
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10509/#review19345
-----------------------------------------------------------
On April 16, 2013, 10:01 p.m., Brenden Matthews wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10509/
> -----------------------------------------------------------
>
> (Updated April 16, 2013, 10:01 p.m.)
>
>
> Review request for mesos.
>
>
> Description
> -------
>
> Include pre/post-package hook scripts in Hadoop tutorial.
>
>
> Diffs
> -----
>
> hadoop/TUTORIAL.sh f8131cd
>
> Diff: https://reviews.apache.org/r/10509/diff/
>
>
> Testing
> -------
>
> Used in production at Airbnb.
>
>
> Thanks,
>
> Brenden Matthews
>
>
Re: Review Request: Include pre/post-package hook scripts in Hadoop tutorial.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10509/#review19345
-----------------------------------------------------------
Note that the tutorial outputs the commands that were run, in order to guide users as to what commands they need to run to build. Is that not sufficient information for creating an Airbnb specific build on your end?
- Ben Mahler
On April 16, 2013, 10:01 p.m., Brenden Matthews wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10509/
> -----------------------------------------------------------
>
> (Updated April 16, 2013, 10:01 p.m.)
>
>
> Review request for mesos.
>
>
> Description
> -------
>
> Include pre/post-package hook scripts in Hadoop tutorial.
>
>
> Diffs
> -----
>
> hadoop/TUTORIAL.sh f8131cd
>
> Diff: https://reviews.apache.org/r/10509/diff/
>
>
> Testing
> -------
>
> Used in production at Airbnb.
>
>
> Thanks,
>
> Brenden Matthews
>
>
Re: Review Request: Include pre/post-package hook scripts in Hadoop tutorial.
Posted by Brenden Matthews <br...@diddyinc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10509/
-----------------------------------------------------------
(Updated April 16, 2013, 10:01 p.m.)
Review request for mesos.
Changes
-------
It seems to work now. No idea what was going on.
Description
-------
Include pre/post-package hook scripts in Hadoop tutorial.
Diffs (updated)
-----
hadoop/TUTORIAL.sh f8131cd
Diff: https://reviews.apache.org/r/10509/diff/
Testing
-------
Used in production at Airbnb.
Thanks,
Brenden Matthews