You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@lucene.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2022/02/04 23:27:00 UTC

[jira] [Commented] (LUCENE-10050) Remove DrillSideways#search(DrillDownQuery,Collector) in favor of DrillSideways#search(DrillDownQuery,CollectorManager)

    [ https://issues.apache.org/jira/browse/LUCENE-10050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17487369#comment-17487369 ] 

ASF subversion and git services commented on LUCENE-10050:
----------------------------------------------------------

Commit de4eccbb55eab4132628dd6ee712cf8b261cdfa8 in lucene's branch refs/heads/main from Gautam Worah
[ https://gitbox.apache.org/repos/asf?p=lucene.git;h=de4eccb ]

LUCENE-10050 Remove DrillSideways#search(DrillDownQuery,Collector) in favor of DrillSideways#search(DrillDownQuery,CollectorManager) (#632)



> Remove DrillSideways#search(DrillDownQuery,Collector) in favor of DrillSideways#search(DrillDownQuery,CollectorManager)
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-10050
>                 URL: https://issues.apache.org/jira/browse/LUCENE-10050
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/facet
>            Reporter: Greg Miller
>            Priority: Minor
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> With similar motivation to LUCENE-10002, we should consider doing away with the ability to directly provide a Collector to DrillSideways in favor of always accepting a CollectorManager. Just like with IndexSearcher, it's trappy that you can provide an Executor when setting up DrillSideways and then not leverage it by directly providing a single Collector.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org