You are viewing a plain text version of this content. The canonical link for it is here.
Posted to scm@geronimo.apache.org by jd...@apache.org on 2007/09/06 23:41:08 UTC
svn commit: r573388 - in /geronimo/sandbox/gshell/trunk:
gshell-assembly/src/main/underlay/etc/
gshell-core/src/main/java/org/apache/geronimo/gshell/layout/model/
gshell-core/src/test/resources/org/apache/geronimo/gshell/layout/model/
Author: jdillon
Date: Thu Sep 6 14:41:07 2007
New Revision: 573388
URL: http://svn.apache.org/viewvc?rev=573388&view=rev
Log:
Rename implementation to id for the layout
Modified:
geronimo/sandbox/gshell/trunk/gshell-assembly/src/main/underlay/etc/layout.xml
geronimo/sandbox/gshell/trunk/gshell-core/src/main/java/org/apache/geronimo/gshell/layout/model/Command.java
geronimo/sandbox/gshell/trunk/gshell-core/src/test/resources/org/apache/geronimo/gshell/layout/model/layout2.xml
Modified: geronimo/sandbox/gshell/trunk/gshell-assembly/src/main/underlay/etc/layout.xml
URL: http://svn.apache.org/viewvc/geronimo/sandbox/gshell/trunk/gshell-assembly/src/main/underlay/etc/layout.xml?rev=573388&r1=573387&r2=573388&view=diff
==============================================================================
--- geronimo/sandbox/gshell/trunk/gshell-assembly/src/main/underlay/etc/layout.xml (original)
+++ geronimo/sandbox/gshell/trunk/gshell-assembly/src/main/underlay/etc/layout.xml Thu Sep 6 14:41:07 2007
@@ -26,7 +26,7 @@
<nodes>
<command>
<name>help</name>
- <implementation>org.apache.geronimo.gshell.commands.buildins.HelpCommand</implementation>
+ <id>org.apache.geronimo.gshell.commands.buildins.HelpCommand</id>
</command>
<alias>
Modified: geronimo/sandbox/gshell/trunk/gshell-core/src/main/java/org/apache/geronimo/gshell/layout/model/Command.java
URL: http://svn.apache.org/viewvc/geronimo/sandbox/gshell/trunk/gshell-core/src/main/java/org/apache/geronimo/gshell/layout/model/Command.java?rev=573388&r1=573387&r2=573388&view=diff
==============================================================================
--- geronimo/sandbox/gshell/trunk/gshell-core/src/main/java/org/apache/geronimo/gshell/layout/model/Command.java (original)
+++ geronimo/sandbox/gshell/trunk/gshell-core/src/main/java/org/apache/geronimo/gshell/layout/model/Command.java Thu Sep 6 14:41:07 2007
@@ -30,22 +30,17 @@
public class Command
extends Node
{
- //
- // FIXME: This isn't really goning to be the implementation, but its a key to reference a command which has been discovered previously
- // So, rename this shizzz
- //
-
- protected String implementation;
+ protected String id;
- public Command(final String name, final String implementation) {
+ public Command(final String name, final String id) {
super(name);
- assert implementation != null;
+ assert id != null;
- this.implementation = implementation;
+ this.id = id;
}
- public String getImplementation() {
- return implementation;
+ public String getId() {
+ return id;
}
}
Modified: geronimo/sandbox/gshell/trunk/gshell-core/src/test/resources/org/apache/geronimo/gshell/layout/model/layout2.xml
URL: http://svn.apache.org/viewvc/geronimo/sandbox/gshell/trunk/gshell-core/src/test/resources/org/apache/geronimo/gshell/layout/model/layout2.xml?rev=573388&r1=573387&r2=573388&view=diff
==============================================================================
--- geronimo/sandbox/gshell/trunk/gshell-core/src/test/resources/org/apache/geronimo/gshell/layout/model/layout2.xml (original)
+++ geronimo/sandbox/gshell/trunk/gshell-core/src/test/resources/org/apache/geronimo/gshell/layout/model/layout2.xml Thu Sep 6 14:41:07 2007
@@ -26,7 +26,7 @@
<nodes>
<command>
<name>help</name>
- <implementation>org.apache.geronimo.gshell.commands.builtins.HelpCommand</implementation>
+ <id>org.apache.geronimo.gshell.commands.builtins.HelpCommand</id>
</command>
<alias>
@@ -40,7 +40,7 @@
<nodes>
<command>
<name>start-server</name>
- <implementation>org.apache.geronimo.server.commands.StartServerCommand</implementation>
+ <id>org.apache.geronimo.server.commands.StartServerCommand</id>
</command>
<alias>