You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@amoro.apache.org by "hutiefang76 (via GitHub)" <gi...@apache.org> on 2026/10/07 08:29:11 UTC
[PR] [AMORO-4425][Hive] Fix Hive schema lowercase conversion across nested scopes [amoro]
hutiefang76 opened a new pull request, #4427:
URL: https://github.com/apache/amoro/pull/4427
## Why are the changes needed?
HiveSchemaUtil.changeFieldNameToLowercase uses one collision set for the entire schema. A valid schema with col1.X and col2.X throws an IllegalArgumentException although the fields belong to different structs. Struct fields nested inside lists/maps are also left unchanged.
Closes #4425.
## Brief change log
Keep collision detection within each struct and visit list elements and map keys/values, retaining IDs, docs and requiredness. Same-struct collisions still fail.
## How was this patch tested?
- [x] Added positive and negative regression tests.
- [x] Ran the affected tests locally.
JDK 17: TestHiveSchemaUtil, 5 tests passed. The same tests against the original implementation produced 1 failure and 2 errors. Root ./mvnw -q -Pskip-dashboard-build validate passed.
```shell
./mvnw -q -Pskip-dashboard-build -pl amoro-format-mixed/amoro-mixed-hive -am -Dtest=TestHiveSchemaUtil -Dsurefire.failIfNoSpecifiedTests=false test
```
## Documentation
No new feature or configuration. Existing conversion behavior is corrected.
AI assistance: implementation and initial review used DeepSeek; Codex coordinated final review and local verification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AMORO-4425][Hive] Fix Hive schema lowercase conversion across nested scopes [amoro]
Posted by "hutiefang76 (via GitHub)" <gi...@apache.org>.
hutiefang76 commented on PR #4427:
URL: https://github.com/apache/amoro/pull/4427#issuecomment-6065428118
CI follow-up for head `e6eff1d`: the [JDK 17 / Spark 3.5 job](https://github.com/apache/amoro/actions/runs/37594068852/job/112702272994) failed during `./mvnw validate` at Maven wrapper SHA-256 validation, before Maven compilation or tests. Three JDK 11 legs were cancelled after that failure, consistent with the matrix's default fail-fast behavior; the Hadoop 2 and Trino runs on the same head passed.
I checked the [official Maven wrapper 3.3.4 artifact](https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/3.3.4/maven-wrapper-3.3.4.jar): HTTP 200, 63,093 bytes, SHA-256 `4e2fbf6554bc8a4702cdfdd3bef464f423393d784ddbb037216320ce55d5e4e1`, exactly matching `wrapperSha256Sum`. Its published SHA-1 also matches. `mvnw`, `mvnw.cmd` and the wrapper properties are byte-identical between this PR and master at `2c85dcb`; the local wrapper jar matches the official SHA-256 too.
On the unchanged PR head, `./mvnw validate` passed locally and all 5 `TestHiveSchemaUtil` tests passed on JDK 17. These local results do not establish a full remote CI pass. The failed runner's downloaded jar is unavailable, so the bootstrap failure's underlying cause remains unconfirmed.
I attempted a targeted rerun, but the Actions API returned HTTP 403: repository administrator rights are required. Could a maintainer rerun the failed and cancelled legs? I have kept the wrapper integrity checks unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AMORO-4425][Hive] Fix Hive schema lowercase conversion across nested scopes [amoro]
Posted by "github-actions[bot] (via GitHub) via commits" <co...@amoro.apache.org>.
github-actions[bot] commented on PR #4427:
URL: https://github.com/apache/amoro/pull/4427#issuecomment-6714801086
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@amoro.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org