[GitHub] [doris] morrySnow commented on a diff in pull request #11066: [Refactor](Nereids) Remove expression type.

[GitBox <gi...@apache.org>]

morrySnow commented on code in PR #11066:
URL: https://github.com/apache/doris/pull/11066#discussion_r926439060


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/StringRegexPredicate.java:
##########
@@ -29,15 +29,21 @@
  * Such as: like, regexp
  */
 public abstract class StringRegexPredicate extends Expression implements BinaryExpression {
+
+    /**
+     * like or regexp
+     */
+    protected final String symbol;
+
     /**
      * Constructor of StringRegexPredicate.
      *
-     * @param nodeType node type of expression
      * @param left     left child of string regex
      * @param right    right child of string regex
      */
-    public StringRegexPredicate(ExpressionType nodeType, Expression left, Expression right) {
-        super(nodeType, left, right);
+    public StringRegexPredicate(Expression left, Expression right, String symbol) {

Review Comment:
   nit: mod java doc parameter list



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org