[GitHub] [incubator-druid] jihoonson commented on issue #8185: extension for exactly distinct count for single long type dimension:accurate-cardinality

[GitBox <gi...@apache.org>]

jihoonson commented on issue #8185: extension for exactly distinct count for single long type dimension:accurate-cardinality
URL: https://github.com/apache/incubator-druid/pull/8185#issuecomment-519722429
 
 
   Sorry for the delayed review. I'll look through this PR soon. 
   
   From the PR description, I'm wondering the SQL syntax could be better. I guess it might not easy to use this feature if they have tons of segments. My question is, can we use the same SQL syntax and add a new query context to enable this feature? For example, it could be something like this.
   
   ```json
   {
     "query": "select count(distinct pid) from DATASOURCE where col='val'",
     "context": {
       "accurateCardinarlity": true
     }
   }
   ```
   
   Also, please update the PR description as detailed as possible based on https://github.com/apache/incubator-druid/blob/master/.github/pull_request_template.md. The PR template now has a section to explain design choices which can help others to understand this PR better.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org