You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2021/05/06 14:50:38 UTC
[GitHub] [qpid-dispatch] kgiusti opened a new pull request #1190: 1.16.x update
kgiusti opened a new pull request #1190:
URL: https://github.com/apache/qpid-dispatch/pull/1190
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] codecov-commenter commented on pull request #1190: 1.16.x update
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1190:
URL: https://github.com/apache/qpid-dispatch/pull/1190#issuecomment-833773222
# [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1190?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1190](https://codecov.io/gh/apache/qpid-dispatch/pull/1190?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b8d0881) into [1.16.x](https://codecov.io/gh/apache/qpid-dispatch/commit/e30fffeee3834bb2d8c48c339f45020f1ff613e1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e30fffe) will **decrease** coverage by `0.50%`.
> The diff coverage is `87.73%`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/1190?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 1.16.x #1190 +/- ##
==========================================
- Coverage 84.79% 84.29% -0.51%
==========================================
Files 113 113
Lines 29122 27971 -1151
==========================================
- Hits 24695 23578 -1117
+ Misses 4427 4393 -34
```
| [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1190?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [src/alloc\_pool.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1190/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2FsbG9jX3Bvb2wuYw==) | `93.68% <ø> (-0.99%)` | :arrow_down: |
| [src/adaptors/tcp\_adaptor.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1190/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL3RjcF9hZGFwdG9yLmM=) | `70.29% <50.00%> (-0.24%)` | :arrow_down: |
| [tests/threaded\_timer\_test.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1190/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdHMvdGhyZWFkZWRfdGltZXJfdGVzdC5j) | `84.89% <84.89%> (ø)` | |
| [src/connection\_manager.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1190/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2Nvbm5lY3Rpb25fbWFuYWdlci5j) | `89.45% <88.88%> (-1.72%)` | :arrow_down: |
| [src/server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1190/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3NlcnZlci5j) | `86.57% <89.01%> (-1.02%)` | :arrow_down: |
| [src/timer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1190/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3RpbWVyLmM=) | `96.85% <96.29%> (+0.12%)` | :arrow_up: |
| [src/adaptors/http1/http1\_adaptor.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1190/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX2FkYXB0b3IuYw==) | `83.60% <100.00%> (-0.97%)` | :arrow_down: |
| [src/adaptors/http1/http1\_server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1190/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX3NlcnZlci5j) | `84.57% <100.00%> (-1.06%)` | :arrow_down: |
| [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1190/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21lc3NhZ2UuYw==) | `86.60% <100.00%> (+<0.01%)` | :arrow_up: |
| [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1190/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `92.77% <100.00%> (-1.32%)` | :arrow_down: |
| ... and [17 more](https://codecov.io/gh/apache/qpid-dispatch/pull/1190/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1190?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1190?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e30fffe...b8d0881](https://codecov.io/gh/apache/qpid-dispatch/pull/1190?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti commented on pull request #1190: 1.16.x update
Posted by GitBox <gi...@apache.org>.
kgiusti commented on pull request #1190:
URL: https://github.com/apache/qpid-dispatch/pull/1190#issuecomment-833684388
> Seems like including [d2f47a1](https://github.com/apache/qpid-dispatch/commit/d2f47a19077e604bce22513955dc9466192ca4ca) would be good to give it some chance of passing the GHA jobs if the tests pass. (I have also prodded about getting it published)
Indeed. There are a couple of test-related patches that landed recently - I'll follow up with another PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] gemmellr edited a comment on pull request #1190: 1.16.x update
Posted by GitBox <gi...@apache.org>.
gemmellr edited a comment on pull request #1190:
URL: https://github.com/apache/qpid-dispatch/pull/1190#issuecomment-833659199
Seems like including https://github.com/apache/qpid-dispatch/commit/d2f47a19077e604bce22513955dc9466192ca4ca would be good to give it some chance of passing the GHA jobs if the tests pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] gemmellr edited a comment on pull request #1190: 1.16.x update
Posted by GitBox <gi...@apache.org>.
gemmellr edited a comment on pull request #1190:
URL: https://github.com/apache/qpid-dispatch/pull/1190#issuecomment-833659199
Seems like including https://github.com/apache/qpid-dispatch/commit/d2f47a19077e604bce22513955dc9466192ca4ca would be good to give it some chance of passing the GHA jobs if the tests pass. (I have also prodded about getting it published)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] gemmellr commented on pull request #1190: 1.16.x update
Posted by GitBox <gi...@apache.org>.
gemmellr commented on pull request #1190:
URL: https://github.com/apache/qpid-dispatch/pull/1190#issuecomment-833659199
Seems like https://github.com/apache/qpid-dispatch/commit/d2f47a19077e604bce22513955dc9466192ca4ca would be good to give it some chance of passing the GHA jobs if the tests pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] asfgit merged pull request #1190: 1.16.x update
Posted by GitBox <gi...@apache.org>.
asfgit merged pull request #1190:
URL: https://github.com/apache/qpid-dispatch/pull/1190
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org