You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/17 05:39:55 UTC
[GitHub] [incubator-doris] wangbo opened a new pull request, #10211: [fix]InListPredicate wrong result
wangbo opened a new pull request, #10211:
URL: https://github.com/apache/incubator-doris/pull/10211
# Proposed changes
Issue Number: close #10210
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #10211: [fix]InListPredicate wrong result
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10211:
URL: https://github.com/apache/incubator-doris/pull/10211#issuecomment-1158543571
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] cambyzju commented on pull request #10211: [fix]InListPredicate wrong result
Posted by GitBox <gi...@apache.org>.
cambyzju commented on PR #10211:
URL: https://github.com/apache/incubator-doris/pull/10211#issuecomment-1158545204
We should better add an UT or regression-test to avoid the same error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] BiteTheDDDDt merged pull request #10211: [fix]InListPredicate wrong result
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt merged PR #10211:
URL: https://github.com/apache/doris/pull/10211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] BiteTheDDDDt commented on a diff in pull request #10211: [fix]InListPredicate wrong result
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt commented on code in PR #10211:
URL: https://github.com/apache/incubator-doris/pull/10211#discussion_r899790405
##########
be/src/olap/in_list_predicate.h:
##########
@@ -338,15 +338,29 @@ class InListPredicateBase : public ColumnPredicate {
}
}
- if constexpr (is_opposite != (PT == PredicateType::IN_LIST)) {
Review Comment:
Maybe we can just change `is_opposite != (PT == PredicateType::IN_LIST)` to `!is_opposite`.
Or change it to
```cpp
if (is_opposite ^
_operator(_values.find(reinterpret_cast<const T&>(data_array[idx])),
_values.end())) {
sel[new_size++] = idx;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #10211: [fix]InListPredicate wrong result
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10211:
URL: https://github.com/apache/incubator-doris/pull/10211#issuecomment-1158623923
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #10211: [fix]InListPredicate wrong result
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10211:
URL: https://github.com/apache/incubator-doris/pull/10211#issuecomment-1158543551
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org