[GitHub] JaroslavTulach commented on a change in pull request #1144: NB build with jdk11

[GitBox <gi...@apache.org>]

JaroslavTulach commented on a change in pull request #1144: NB build with jdk11
URL: https://github.com/apache/incubator-netbeans/pull/1144#discussion_r258819503
 
 

 ##########
 File path: apisupport/apisupport.ant/build.xml
 ##########
 @@ -25,7 +25,7 @@
 
     <target name="nblib" depends="init">
         <mkdir dir="build/antclasses"/>
-        <javac srcdir="antsrc" destdir="build/antclasses" source="1.4" debug="true" deprecation="true">
+        <javac srcdir="antsrc" destdir="build/antclasses" source="1.6" debug="true" deprecation="true">
 
 Review comment:
   The question is whether to update all `source` and `target` to `1.6` unconditionally, or whether to do that only when building on JDK11?
   
   I am fine with unconditional update. Should we need to do it conditionally, then I would define:
   `javac.min.source` and `javac.min.target` in `nbbuild/templates/common.xml` and used them as
   ```xml
   source="${javac.min.source}"
   ```
   all over the codebase. Next time the JDK drops support for another version (dropping `1.6` is planned, I think), we would just update `common.xml`. CCing @jlahoda.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists