[GitHub] [tomcat] minfrin commented on a change in pull request #401: Add support for unix domain sockets (APR Protocol)

[GitBox <gi...@apache.org>]

minfrin commented on a change in pull request #401:
URL: https://github.com/apache/tomcat/pull/401#discussion_r564042386



##########
File path: java/org/apache/tomcat/util/net/AprEndpoint.java
##########
@@ -287,6 +312,9 @@ public int getSendfileCount() {
     @Override
     public void bind() throws Exception {
 
+        int family;
+        String hostname = null;

Review comment:
       The APR term is hostname:
   
   http://apr.apache.org/docs/apr/1.7/group__apr__network__io.html#gaa2f399ca2b60b35c0abf7630298c6c9f
   
   So is the underlying getaddrinfo() function: https://en.wikipedia.org/wiki/Getaddrinfo 
   
   I can change it?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org