You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by GitBox <gi...@apache.org> on 2020/05/04 07:23:10 UTC
[GitHub] [carbondata] vikramahuja1001 opened a new pull request #3739: index server doc changes
vikramahuja1001 opened a new pull request #3739:
URL: https://github.com/apache/carbondata/pull/3739
### Why is this PR needed?
Changing index server docs as per the code.
### What changes were proposed in this PR?
Changing index server docs as per the code.
### Does this PR introduce any user interface change?
- No
### Is any new testcase added?
- No
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] kunal642 commented on pull request #3739: [CARBONDATA-3791] Index server doc changes
Posted by GitBox <gi...@apache.org>.
kunal642 commented on pull request #3739:
URL: https://github.com/apache/carbondata/pull/3739#issuecomment-625228432
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] vikramahuja1001 commented on pull request #3739: [CARBONDATA-3791] Index server doc changes
Posted by GitBox <gi...@apache.org>.
vikramahuja1001 commented on pull request #3739:
URL: https://github.com/apache/carbondata/pull/3739#issuecomment-625033845
rebase completed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3739: [CARBONDATA-3791] Index server doc changes
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on a change in pull request #3739:
URL: https://github.com/apache/carbondata/pull/3739#discussion_r419294213
##########
File path: docs/index-server.md
##########
@@ -21,7 +21,7 @@
Carbon currently prunes and caches all block/blocklet datamap index information into the driver for
normal table, for Bloom/Index datamaps the JDBC driver will launch a job to prune and cache the
-datamaps in executors.
+indexes in executors.
Review comment:
Remove datamap keyword in Line No.22, Line No.23, Line no.105, Line no.123, Line No.155 and Line no.159
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] kunal642 commented on a change in pull request #3739: [CARBONDATA-3791] Index server doc changes
Posted by GitBox <gi...@apache.org>.
kunal642 commented on a change in pull request #3739:
URL: https://github.com/apache/carbondata/pull/3739#discussion_r420115446
##########
File path: docs/index-server.md
##########
@@ -21,7 +21,7 @@
Carbon currently prunes and caches all block/blocklet datamap index information into the driver for
normal table, for Bloom/Index datamaps the JDBC driver will launch a job to prune and cache the
-datamaps in executors.
+indexes in executors.
Review comment:
handled in 3738
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3739: [CARBONDATA-3791] Index server doc changes
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on pull request #3739:
URL: https://github.com/apache/carbondata/pull/3739#issuecomment-625082581
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1250/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3739: [CARBONDATA-3791] Index server doc changes
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on pull request #3739:
URL: https://github.com/apache/carbondata/pull/3739#issuecomment-624764906
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2960/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] kunal642 commented on pull request #3739: [CARBONDATA-3791] Index server doc changes
Posted by GitBox <gi...@apache.org>.
kunal642 commented on pull request #3739:
URL: https://github.com/apache/carbondata/pull/3739#issuecomment-624830243
Please rebase
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3739: [CARBONDATA-3791] Index server doc changes
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on pull request #3739:
URL: https://github.com/apache/carbondata/pull/3739#issuecomment-624740721
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1242/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3739: [CARBONDATA-3791] Index server doc changes
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on pull request #3739:
URL: https://github.com/apache/carbondata/pull/3739#issuecomment-623370271
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1206/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #3739: [CARBONDATA-3791] Index server doc changes
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on a change in pull request #3739:
URL: https://github.com/apache/carbondata/pull/3739#discussion_r419351252
##########
File path: docs/index-server.md
##########
@@ -21,7 +21,7 @@
Carbon currently prunes and caches all block/blocklet datamap index information into the driver for
normal table, for Bloom/Index datamaps the JDBC driver will launch a job to prune and cache the
-datamaps in executors.
+indexes in executors.
Review comment:
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3739: [CARBONDATA-3791] Index server doc changes
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on pull request #3739:
URL: https://github.com/apache/carbondata/pull/3739#issuecomment-623366749
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2923/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] kunal642 commented on a change in pull request #3739: [CARBONDATA-3791] Index server doc changes
Posted by GitBox <gi...@apache.org>.
kunal642 commented on a change in pull request #3739:
URL: https://github.com/apache/carbondata/pull/3739#discussion_r420608888
##########
File path: docs/index-server.md
##########
@@ -152,11 +152,11 @@ The user can enable prepriming by using 'carbon.indexserver.enable.prepriming' =
| carbon.index.server.ip | NA | Specify the IP/HOST on which the server would be started. Better to specify the private IP. |
| carbon.index.server.port | NA | The port on which the index server has to be started. |
|carbon.index.server.max.worker.threads| 500 | Number of RPC handlers to open for accepting the requests from JDBC driver. Max accepted value is Integer.Max. Refer: [Hive configuration](https://github.com/apache/hive/blob/master/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java#L3441) |
-|carbon.max.executor.lru.cache.size| NA | Maximum memory **(in MB)** upto which the executor process can cache the data (DataMaps and reverse dictionary values). Only integer values greater than 0 are accepted. **NOTE:** Mandatory for the user to set. |
-|carbon.index.server.max.jobname.length|NA|The max length of the job to show in the index server application UI. For bigger queries this may impact performance as the whole string would be sent from JDBCServer to IndexServer.|
+|carbon.max.executor.lru.cache.size| -1 | Maximum memory **(in MB)** upto which the executor process can cache the data (DataMaps and reverse dictionary values). Only integer values greater than 0 are accepted. **NOTE:** Mandatory for the user to set. |
Review comment:
For index server default value is not set..We are throwing exception if user has not set this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request #3739: [CARBONDATA-3791] Index server doc changes
Posted by GitBox <gi...@apache.org>.
vikramahuja1001 commented on a change in pull request #3739:
URL: https://github.com/apache/carbondata/pull/3739#discussion_r420790813
##########
File path: docs/index-server.md
##########
@@ -152,11 +152,11 @@ The user can enable prepriming by using 'carbon.indexserver.enable.prepriming' =
| carbon.index.server.ip | NA | Specify the IP/HOST on which the server would be started. Better to specify the private IP. |
| carbon.index.server.port | NA | The port on which the index server has to be started. |
|carbon.index.server.max.worker.threads| 500 | Number of RPC handlers to open for accepting the requests from JDBC driver. Max accepted value is Integer.Max. Refer: [Hive configuration](https://github.com/apache/hive/blob/master/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java#L3441) |
-|carbon.max.executor.lru.cache.size| NA | Maximum memory **(in MB)** upto which the executor process can cache the data (DataMaps and reverse dictionary values). Only integer values greater than 0 are accepted. **NOTE:** Mandatory for the user to set. |
-|carbon.index.server.max.jobname.length|NA|The max length of the job to show in the index server application UI. For bigger queries this may impact performance as the whole string would be sent from JDBCServer to IndexServer.|
+|carbon.max.executor.lru.cache.size| -1 | Maximum memory **(in MB)** upto which the executor process can cache the data (DataMaps and reverse dictionary values). Only integer values greater than 0 are accepted. **NOTE:** Mandatory for the user to set. |
Review comment:
reverted it back
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] chetandb commented on a change in pull request #3739: [CARBONDATA-3791] Index server doc changes
Posted by GitBox <gi...@apache.org>.
chetandb commented on a change in pull request #3739:
URL: https://github.com/apache/carbondata/pull/3739#discussion_r420313733
##########
File path: docs/index-server.md
##########
@@ -21,7 +21,7 @@
Carbon currently prunes and caches all block/blocklet datamap index information into the driver for
Review comment:
Remove datamap keyword whereever mentioned
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request #3739: [CARBONDATA-3791] Index server doc changes
Posted by GitBox <gi...@apache.org>.
vikramahuja1001 commented on a change in pull request #3739:
URL: https://github.com/apache/carbondata/pull/3739#discussion_r419327181
##########
File path: docs/index-server.md
##########
@@ -21,7 +21,7 @@
Carbon currently prunes and caches all block/blocklet datamap index information into the driver for
normal table, for Bloom/Index datamaps the JDBC driver will launch a job to prune and cache the
-datamaps in executors.
+indexes in executors.
Review comment:
that is done in PR3738
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request #3739: [CARBONDATA-3791] Index server doc changes
Posted by GitBox <gi...@apache.org>.
vikramahuja1001 commented on a change in pull request #3739:
URL: https://github.com/apache/carbondata/pull/3739#discussion_r420550349
##########
File path: docs/index-server.md
##########
@@ -21,7 +21,7 @@
Carbon currently prunes and caches all block/blocklet datamap index information into the driver for
Review comment:
These changes are handled in PR3738
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org