You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "EricGao888 (via GitHub)" <gi...@apache.org> on 2023/03/29 02:57:49 UTC
[GitHub] [dolphinscheduler] EricGao888 opened a new issue, #13355: [Bug] [Master] Failover may never succeed if master crashes during failover
EricGao888 opened a new issue, #13355:
URL: https://github.com/apache/dolphinscheduler/issues/13355
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
* When master performs failover, it would set the host of process instances which need failover to `NULL`. If master crashes after this step but the failover of process instances hasn't ended yet, those process instances will never get failover again.
https://github.com/apache/dolphinscheduler/blob/2a44a7f36a4be85221703bc3d8d70a650860b31e/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/service/MasterFailoverService.java#L197-L202
https://github.com/apache/dolphinscheduler/blob/2a44a7f36a4be85221703bc3d8d70a650860b31e/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/service/MasterFailoverService.java#L291-L298
### What you expected to happen
* Failover should succeed eventually, even if master crashes during failover.
### How to reproduce
1. Kill workers.
2. Kill masters.
3. Start masters, now masters will perform failover, but there are current no workers, so failover will not succeed.
4. Restart masters and start workers, masters will perform failover again. However, in step 3, the hosts of process instances need failover are set to NULL, they will never really get failover successfully.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] skytt commented on issue #13355: [Bug] [Master] Failover may never succeed if master crashes during failover
Posted by "skytt (via GitHub)" <gi...@apache.org>.
skytt commented on issue #13355:
URL: https://github.com/apache/dolphinscheduler/issues/13355#issuecomment-1654894373
I have the same issue. Is there any progress?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #13355: [Bug] [Master] Failover may never succeed if master crashes during failover
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #13355:
URL: https://github.com/apache/dolphinscheduler/issues/13355#issuecomment-1375071068
Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
* If you haven't received a reply for a long time, you can [join our slack](https://s.apache.org/dolphinscheduler-slack) and send your question to channel `#troubleshooting`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] closed issue #13355: [Bug] [Master] Failover may never succeed if master crashes during failover
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #13355: [Bug] [Master] Failover may never succeed if master crashes during failover
URL: https://github.com/apache/dolphinscheduler/issues/13355
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on issue #13355: [Bug] [Master] Failover may never succeed if master crashes during failover
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on issue #13355:
URL: https://github.com/apache/dolphinscheduler/issues/13355#issuecomment-1375072218
I'm not sure whether it is a bug or it is designed to act like this? May I ask whether we need to fix it? @ruanwenjun @caishunfeng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #13355: [Bug] [Master] Failover may never succeed if master crashes during failover
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #13355:
URL: https://github.com/apache/dolphinscheduler/issues/13355#issuecomment-1425011841
This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #13355: [Bug] [Master] Failover may never succeed if master crashes during failover
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #13355:
URL: https://github.com/apache/dolphinscheduler/issues/13355#issuecomment-1537251402
This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #13355: [Bug] [Master] Failover may never succeed if master crashes during failover
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #13355:
URL: https://github.com/apache/dolphinscheduler/issues/13355#issuecomment-1528289629
This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #13355: [Bug] [Master] Failover may never succeed if master crashes during failover
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #13355:
URL: https://github.com/apache/dolphinscheduler/issues/13355#issuecomment-1433922020
This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #13355: [Bug] [Master] Failover may never succeed if master crashes during failover
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #13355:
URL: https://github.com/apache/dolphinscheduler/issues/13355#issuecomment-1487775145
This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on issue #13355: [Bug] [Master] Failover may never succeed if master crashes during failover
Posted by "EricGao888 (via GitHub)" <gi...@apache.org>.
EricGao888 commented on issue #13355:
URL: https://github.com/apache/dolphinscheduler/issues/13355#issuecomment-1434032066
No close
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #13355: [Bug] [Master] Failover may never succeed if master crashes during failover
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #13355:
URL: https://github.com/apache/dolphinscheduler/issues/13355#issuecomment-1475452891
This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] closed issue #13355: [Bug] [Master] Failover may never succeed if master crashes during failover
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #13355: [Bug] [Master] Failover may never succeed if master crashes during failover
URL: https://github.com/apache/dolphinscheduler/issues/13355
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] closed issue #13355: [Bug] [Master] Failover may never succeed if master crashes during failover
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #13355: [Bug] [Master] Failover may never succeed if master crashes during failover
URL: https://github.com/apache/dolphinscheduler/issues/13355
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org