You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/10/07 02:50:47 UTC
[GitHub] [incubator-kvrocks] maochongxin commented on a diff in pull request #955: Move TCL test unit/expire to Go case
maochongxin commented on code in PR #955:
URL: https://github.com/apache/incubator-kvrocks/pull/955#discussion_r989638858
##########
tests/tcl/tests/unit/expire.tcl:
##########
@@ -1,206 +0,0 @@
-# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license agreements. See the NOTICE file
-# distributed with this work for additional information
-# regarding copyright ownership. The ASF licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License. You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing,
-# software distributed under the License is distributed on an
-# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-# KIND, either express or implied. See the License for the
-# specific language governing permissions and limitations
-# under the License.
-
-# Copyright (c) 2006-2020, Salvatore Sanfilippo
-# See bundled license file licenses/LICENSE.redis for details.
-
-# This file is copied and modified from the Redis project,
-# which started out as: https://github.com/redis/redis/blob/dbcc0a8/tests/unit/expire.tcl
-
-start_server {tags {"expire"}} {
- test {EXPIRE - set timeouts multiple times} {
- r set x foobar
- set v1 [r expire x 5]
- set v2 [r ttl x]
- set v3 [r expire x 10]
- set v4 [r ttl x]
- r expire x 2
- list $v1 $v2 $v3 $v4
- } {1 [45] 1 10}
-
- test {EXPIRE - It should be still possible to read 'x'} {
- r get x
- } {foobar}
-
- tags {"slow"} {
- test {EXPIRE - After 3.1 seconds the key should no longer be here} {
- after 3100
- list [r get x] [r exists x]
- } {{} 0}
- }
-
- test {EXPIRE - write on expire should work} {
- r del x
- r lpush x foo
- r expire x 1000
- r lpush x bar
- r lrange x 0 -1
- } {bar foo}
-
- test {EXPIREAT - Check for EXPIRE alike behavior} {
- r del x
- r set x foo
- r expireat x [expr [clock seconds]+15]
- r ttl x
- } {1[3456]}
-
- test {SETEX - Set + Expire combo operation. Check for TTL} {
- r setex x 12 test
- r ttl x
- } {1[012]}
-
- test {SETEX - Check value} {
- r get x
- } {test}
-
- test {SETEX - Overwrite old key} {
- r setex y 1 foo
- r get y
- } {foo}
-
- tags {"slow"} {
- test {SETEX - Wait for the key to expire} {
- after 2100
- r get y
- } {}
- }
-
- test {SETEX - Wrong time parameter} {
- catch {r setex z -10 foo} e
- set _ $e
- } {*invalid expire*}
-
- test {PERSIST can undo an EXPIRE} {
- r set x foo
- r expire x 12
- list [r ttl x] [r persist x] [r ttl x] [r get x]
- } {1[012] 1 -1 foo}
-
- test {PERSIST returns 0 against non existing or non volatile keys} {
- r set x foo
- list [r persist foo] [r persist nokeyatall]
- } {0 0}
-
- test {EXPIRE pricision is now the millisecond} {
- # This test is very likely to do a false positive if the
- # server is under pressure, so if it does not work give it a few more
- # chances.
- for {set j 0} {$j < 3} {incr j} {
- r del x
- r setex x 1 somevalue
- after 900
- set a [r get x]
- after 1100
- set b [r get x]
- if {$a eq {somevalue} && $b eq {}} break
- }
- list $a $b
- } {somevalue {}}
-
- test {PEXPIRE/PSETEX/PEXPIREAT can set sub-second expires} {
- # This test is very likely to do a false positive if the
- # server is under pressure, so if it does not work give it a few more
- # chances.
- for {set j 0} {$j < 3} {incr j} {
- r del x y z
- r psetex x 100 somevalue
- after 80
- set a [r get x]
- after 2100
- set b [r get x]
-
- r set x somevalue
- r pexpire x 100
- after 80
- set c [r get x]
- after 2100
- set d [r get x]
-
- r set x somevalue
- r pexpireat x [expr ([clock seconds]*1000)+100]
- after 80
- set e [r get x]
- after 2100
- set f [r get x]
-
- if {$a eq {somevalue} && $b eq {} &&
- $c eq {somevalue} && $d eq {} &&
- $e eq {somevalue} && $f eq {}} break
- }
- list $a $b
- } {somevalue {}}
-
- test {TTL returns tiem to live in seconds} {
- r del x
- r setex x 10 somevalue
- set ttl [r ttl x]
- assert {$ttl > 8 && $ttl <= 10}
- }
-
- test {PTTL returns time to live in milliseconds} {
- r del x
- r setex x 1 somevalue
- set ttl [r pttl x]
- assert {$ttl > 900 && $ttl <= 1000}
- }
-
- test {TTL / PTTL return -1 if key has no expire} {
- r del x
- r set x hello
- list [r ttl x] [r pttl x]
- } {-1 -1}
-
- test {TTL / PTTL return -2 if key does not exit} {
- r del x
- list [r ttl x] [r pttl x]
- } {-2 -2}
-
- test {Redis should actively expire keys incrementally} {
- r flushdb
- r psetex key1 500 a
- r psetex key2 500 a
- r psetex key3 500 a
- r dbsize scan
- after 100
- set size1 [r dbsize]
- # Redis expires random keys ten times every second so we are
- # fairly sure that all the three keys should be evicted after
- # one second.
- after 2000
- r dbsize scan
- after 100
- set size2 [r dbsize]
- list $size1 $size2
- } {3 0}
-
- test {5 keys in, 5 keys out} {
- r flushdb
- r set a c
- r expire a 5
- r set t c
- r set e c
- r set s c
- r set foo b
- lsort [r keys *]
- } {a e foo s t}
-
- test {EXPIRE with empty string as TTL should report an error} {
- r set foo bar
- catch {r expire foo ""} e
- set e
- } {*not an integer*}
Review Comment:
At first I thought that the `go-redis Expire` method would have type checking, so it was not implemented, it has been added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org