You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/04/29 15:27:48 UTC

[GitHub] [arrow-rs] ritchie46 opened a new pull request #239: pin flatbuffer to 0.8.4

ritchie46 opened a new pull request #239:
URL: https://github.com/apache/arrow-rs/pull/239


   Fix for #238 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] ritchie46 commented on pull request #239: pin flatbuffers to 0.8.4

Posted by GitBox <gi...@apache.org>.
ritchie46 commented on pull request #239:
URL: https://github.com/apache/arrow-rs/pull/239#issuecomment-829521464


   Thanks for the quick merge on this one!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] alamb merged pull request #239: pin flatbuffers to 0.8.4

Posted by GitBox <gi...@apache.org>.
alamb merged pull request #239:
URL: https://github.com/apache/arrow-rs/pull/239


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] returnString commented on a change in pull request #239: pin flatbuffers to 0.8.4

Posted by GitBox <gi...@apache.org>.
returnString commented on a change in pull request #239:
URL: https://github.com/apache/arrow-rs/pull/239#discussion_r623177439



##########
File path: arrow/Cargo.toml
##########
@@ -47,7 +47,7 @@ regex = "1.3"
 lazy_static = "1.4"
 packed_simd = { version = "0.3.4", optional = true, package = "packed_simd_2" }
 chrono = "0.4"
-flatbuffers = "^0.8"
+flatbuffers = "0.8.4"

Review comment:
       I think this needs to be `< 0.8.5` or similar, as bare versions with no operator get interpreted as [caret requirements](https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#specifying-dependencies-from-cratesio).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] andygrove commented on a change in pull request #239: pin flatbuffers to 0.8.4

Posted by GitBox <gi...@apache.org>.
andygrove commented on a change in pull request #239:
URL: https://github.com/apache/arrow-rs/pull/239#discussion_r623205165



##########
File path: arrow/Cargo.toml
##########
@@ -47,7 +47,7 @@ regex = "1.3"
 lazy_static = "1.4"
 packed_simd = { version = "0.3.4", optional = true, package = "packed_simd_2" }
 chrono = "0.4"
-flatbuffers = "^0.8"
+flatbuffers = "0.8.4"

Review comment:
       I know this from experience when they introduced const generics in 0.8.3 and that broke CI until we upgraded our Rust versions




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] andygrove commented on a change in pull request #239: pin flatbuffers to 0.8.4

Posted by GitBox <gi...@apache.org>.
andygrove commented on a change in pull request #239:
URL: https://github.com/apache/arrow-rs/pull/239#discussion_r623204655



##########
File path: arrow/Cargo.toml
##########
@@ -47,7 +47,7 @@ regex = "1.3"
 lazy_static = "1.4"
 packed_simd = { version = "0.3.4", optional = true, package = "packed_simd_2" }
 chrono = "0.4"
-flatbuffers = "^0.8"
+flatbuffers = "0.8.4"

Review comment:
       You can do `"=0.8.4"`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] ritchie46 commented on a change in pull request #239: pin flatbuffers to 0.8.4

Posted by GitBox <gi...@apache.org>.
ritchie46 commented on a change in pull request #239:
URL: https://github.com/apache/arrow-rs/pull/239#discussion_r623219935



##########
File path: arrow/Cargo.toml
##########
@@ -47,7 +47,7 @@ regex = "1.3"
 lazy_static = "1.4"
 packed_simd = { version = "0.3.4", optional = true, package = "packed_simd_2" }
 chrono = "0.4"
-flatbuffers = "^0.8"
+flatbuffers = "0.8.4"

Review comment:
       > You can do `"=0.8.4"`
   
   I go for that one,  that seems most explicit.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] codecov-commenter commented on pull request #239: pin flatbuffers to 0.8.4

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #239:
URL: https://github.com/apache/arrow-rs/pull/239#issuecomment-829376288


   # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/239?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#239](https://codecov.io/gh/apache/arrow-rs/pull/239?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (991de9d) into [master](https://codecov.io/gh/apache/arrow-rs/commit/ed00e4d4a160cd5182bfafb81fee2240ec005014?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ed00e4d) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head 991de9d differs from pull request most recent head 8f1a465. Consider uploading reports for the commit 8f1a465 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/arrow-rs/pull/239/graphs/tree.svg?width=650&height=150&src=pr&token=pq9V9qWZ1N&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/arrow-rs/pull/239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master     #239   +/-   ##
   =======================================
     Coverage   82.49%   82.49%           
   =======================================
     Files         162      162           
     Lines       43621    43621           
   =======================================
     Hits        35983    35983           
     Misses       7638     7638           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/239?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/239?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ed00e4d...8f1a465](https://codecov.io/gh/apache/arrow-rs/pull/239?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] alamb commented on pull request #239: pin flatbuffers to 0.8.4

Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #239:
URL: https://github.com/apache/arrow-rs/pull/239#issuecomment-829460311


   merging to get CI green


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] returnString commented on a change in pull request #239: pin flatbuffers to 0.8.4

Posted by GitBox <gi...@apache.org>.
returnString commented on a change in pull request #239:
URL: https://github.com/apache/arrow-rs/pull/239#discussion_r623224172



##########
File path: arrow/Cargo.toml
##########
@@ -47,7 +47,7 @@ regex = "1.3"
 lazy_static = "1.4"
 packed_simd = { version = "0.3.4", optional = true, package = "packed_simd_2" }
 chrono = "0.4"
-flatbuffers = "^0.8"
+flatbuffers = "0.8.4"

Review comment:
       Yeah Andy's right, that's a better solution here - forgot that Cargo handles conflicting dep requirements relatively gracefully so doesn't matter if an Arrow user needs another `flatbuffers` version in their project. Been doing too much Python lately.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org