You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by "Hyrum K. Wright" <hy...@hyrumwright.org> on 2009/05/03 02:10:26 UTC

Re: svn commit: r37545 - in trunk/subversion: svnversion tests/cmdline

On May 2, 2009, at 9:03 PM, Arfrever Frehtes Taifersar Arahesis wrote:

> Author: arfrever
> Date: Sat May  2 19:03:53 2009
> New Revision: 37545
>
> Log:
> Follow-up to r37543:
>
> * subversion/svnversion/main.c
>  (main): Use svn_dirent_local_style() for some paths in error  
> messages.
>
> * subversion/tests/cmdline/svnversion_tests.py
>  (svnversion_test): Improve test.

How was this test improved?

>
>
> Modified:
>   trunk/subversion/svnversion/main.c
>   trunk/subversion/tests/cmdline/svnversion_tests.py
>
> Modified: trunk/subversion/svnversion/main.c
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/svnversion/main.c?pathrev=37545&r1=37544&r2=37545
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> ======================================================================
> --- trunk/subversion/svnversion/main.c	Sat May  2 14:46:33 2009	 
> (r37544)
> +++ trunk/subversion/svnversion/main.c	Sat May  2 19:03:53 2009	 
> (r37545)
> @@ -255,7 +255,7 @@ main(int argc, const char *argv[])
>     {
>       svn_error_clear(svn_cmdline_fprintf(stderr, pool,
>                                           _("'%s' doesn't exist\n"),
> -                                          wc_path));
> +                                           
> svn_dirent_local_style(wc_path, pool)));
>       svn_pool_destroy(pool);
>       return EXIT_FAILURE;
>     }
> @@ -263,7 +263,7 @@ main(int argc, const char *argv[])
>     {
>       svn_error_clear(svn_cmdline_fprintf(stderr, pool,
>                                           _("'%s' is of unknown type 
> \n"),
> -                                          wc_path));
> +                                           
> svn_dirent_local_style(wc_path, pool)));
>       svn_pool_destroy(pool);
>       return EXIT_FAILURE;
>     }
>
> Modified: trunk/subversion/tests/cmdline/svnversion_tests.py
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/tests/cmdline/svnversion_tests.py?pathrev=37545&r1=37544&r2=37545
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> ======================================================================
> --- trunk/subversion/tests/cmdline/svnversion_tests.py	Sat May  2  
> 14:46:33 2009	(r37544)
> +++ trunk/subversion/tests/cmdline/svnversion_tests.py	Sat May  2  
> 19:03:53 2009	(r37545)
> @@ -32,7 +32,7 @@ Item = svntest.wc.StateItem
> #----------------------------------------------------------------------
>
> def svnversion_test(sbox):
> -  "test 'svnversion' on wc and other dirs"
> +  "test 'svnversion' on files and directories"
>   sbox.build()
>   wc_dir = sbox.wc_dir
>   repo_url = sbox.repo_url
> @@ -50,6 +50,11 @@ def svnversion_test(sbox):
>   mu_path = os.path.join(wc_dir, 'A', 'mu')
>   svntest.main.file_append(mu_path, 'appended mu text')
>
> +  # Modified file
> +  svntest.actions.run_and_verify_svnversion("Modified file",
> +                                            mu_path, repo_url + '/A/ 
> mu',
> +                                            [ "1M\n" ], [])
> +
>   # Text modified
>   svntest.actions.run_and_verify_svnversion("Modified text", wc_dir,  
> repo_url,
>                                             [ "1M\n" ], [])
> @@ -112,14 +117,14 @@ def svnversion_test(sbox):
>                                             R_path, repo_url,
>                                             [ "Unversioned directory 
> \n" ], [])
>
> -  # Versioned file
> -  svntest.actions.run_and_verify_svnversion("Versioned, switched  
> file",
> -                                            iota_path, repo_url,
> +  # Switched file
> +  svntest.actions.run_and_verify_svnversion("Switched file",
> +                                            iota_path, repo_url + '/ 
> iota',
>                                             [ "2S\n" ], [])
>
>   # Unversioned file
>   kappa_path = os.path.join(wc_dir, 'kappa')
> -  open(kappa_path, 'w').write("This is the file 'kappa'.")
> +  svntest.main.file_write(kappa_path, "This is the file 'kappa'.")
>   svntest.actions.run_and_verify_svnversion("Unversioned file",
>                                             kappa_path, repo_url,
>                                             [ "Unversioned file 
> \n" ], [])
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=495&dsMessageId=2038965

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2038990

Re: svn commit: r37545 - in trunk/subversion: svnversion tests/cmdline

Posted by Gavin Baumanis <ga...@thespidernet.com>.
Mike, I am glad someone else posted that.....
I instantly thought it... but being relatively new to the dev list -  
wasn't sure if the humor would come through!

Gavin


On 04/05/2009, at 11:25 PM, C. Michael Pilato wrote:

> Arfrever Frehtes Taifersar Arahesis wrote:
>> 2009-05-03 04:10:26 Hyrum K. Wright napisał(a):
>>> On May 2, 2009, at 9:03 PM, Arfrever Frehtes Taifersar Arahesis  
>>> wrote:
>>>
>>>> Author: arfrever
>>>> Date: Sat May  2 19:03:53 2009
>>>> New Revision: 37545
>>>>
>>>> Log:
>>>> Follow-up to r37543:
>>>>
>>>> * subversion/svnversion/main.c
>>>> (main): Use svn_dirent_local_style() for some paths in error
>>>> messages.
>>>>
>>>> * subversion/tests/cmdline/svnversion_tests.py
>>>> (svnversion_test): Improve test.
>>> How was this test improved?
>>
>> I improved svn:log.
>
> How was svn:log improved?
>
> (Just kidding ... I couldn't resist.)
>
>
> -- 
> C. Michael Pilato <cm...@collab.net>
> CollabNet   <>   www.collab.net   <>   Distributed Development On  
> Demand
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2056428

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2074935


Re: svn commit: r37545 - in trunk/subversion: svnversion tests/cmdline

Posted by "C. Michael Pilato" <cm...@collab.net>.
Arfrever Frehtes Taifersar Arahesis wrote:
> 2009-05-03 04:10:26 Hyrum K. Wright napisał(a):
>> On May 2, 2009, at 9:03 PM, Arfrever Frehtes Taifersar Arahesis wrote:
>>
>>> Author: arfrever
>>> Date: Sat May  2 19:03:53 2009
>>> New Revision: 37545
>>>
>>> Log:
>>> Follow-up to r37543:
>>>
>>> * subversion/svnversion/main.c
>>>  (main): Use svn_dirent_local_style() for some paths in error  
>>> messages.
>>>
>>> * subversion/tests/cmdline/svnversion_tests.py
>>>  (svnversion_test): Improve test.
>> How was this test improved?
> 
> I improved svn:log.

How was svn:log improved?

(Just kidding ... I couldn't resist.)


-- 
C. Michael Pilato <cm...@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2056428

Re: svn commit: r37545 - in trunk/subversion: svnversion tests/cmdline

Posted by Arfrever Frehtes Taifersar Arahesis <Ar...@GMail.Com>.
2009-05-03 04:10:26 Hyrum K. Wright napisał(a):
> On May 2, 2009, at 9:03 PM, Arfrever Frehtes Taifersar Arahesis wrote:
> 
> > Author: arfrever
> > Date: Sat May  2 19:03:53 2009
> > New Revision: 37545
> >
> > Log:
> > Follow-up to r37543:
> >
> > * subversion/svnversion/main.c
> >  (main): Use svn_dirent_local_style() for some paths in error  
> > messages.
> >
> > * subversion/tests/cmdline/svnversion_tests.py
> >  (svnversion_test): Improve test.
> 
> How was this test improved?

I improved svn:log.

-- 
Arfrever Frehtes Taifersar Arahesis