You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by kkhatua <gi...@git.apache.org> on 2017/06/28 17:49:22 UTC
[GitHub] drill pull request #862: DRILL-5420: ParquetAsyncPgReader goes into infinite...
GitHub user kkhatua opened a pull request:
https://github.com/apache/drill/pull/862
DRILL-5420: ParquetAsyncPgReader goes into infinite loop during cleanup
PageQueue is cleaned up using poll() instead of take(), which constantly gets interrupted and causes CPU churn.
During a columnReader shutdown, a flag is set so as to block any new page reading tasks from being submitted, before the queues are finally cleared and memory occupied by the pages released.
More details are in this JIRA comment : https://issues.apache.org/jira/browse/DRILL-5420?focusedCommentId=16066933&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16066933
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kkhatua/drill DRILL-5420
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/862.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #862
----
commit 2f233d4b1318e29211856877937ef9988c34ffaf
Author: Kunal Khatua <kk...@maprtech.com>
Date: 2017-06-28T06:35:34Z
DRILL-5420: ParquetAsyncPgReader goes into infinite loop during cleanup
PageQueue is cleaned up using poll() instead of take(), which constantly gets interrupted and causes CPU churn.
During a columnReader shutdown, a flag is set so as to block any new page reading tasks from being submitted.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request #862: DRILL-5420: ParquetAsyncPgReader goes into infinite...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/862
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request #862: DRILL-5420: ParquetAsyncPgReader goes into infinite...
Posted by kkhatua <gi...@git.apache.org>.
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/862#discussion_r124688876
--- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/AsyncPageReader.java ---
@@ -409,9 +414,10 @@ public Void call() throws IOException {
DrillBuf pageData = null;
timer.reset();
- try {
+ parqProcessing: try {
--- End diff --
Good point. I didn't realize that the `finally` block is empty. If there was something to be done, a labelled break would allow the finally to be executed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request #862: DRILL-5420: ParquetAsyncPgReader goes into infinite...
Posted by parthchandra <gi...@git.apache.org>.
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/862#discussion_r124659309
--- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/AsyncPageReader.java ---
@@ -409,9 +414,10 @@ public Void call() throws IOException {
DrillBuf pageData = null;
timer.reset();
- try {
+ parqProcessing: try {
--- End diff --
Maybe just check isShuttingDown here and return? (breaks with labels with no outer for/while loops confuse me!)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill issue #862: DRILL-5420: ParquetAsyncPgReader goes into infinite loop d...
Posted by parthchandra <gi...@git.apache.org>.
Github user parthchandra commented on the issue:
https://github.com/apache/drill/pull/862
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill issue #862: DRILL-5420: ParquetAsyncPgReader goes into infinite loop d...
Posted by kkhatua <gi...@git.apache.org>.
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/862
@parthchandra Can you please review this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill issue #862: DRILL-5420: ParquetAsyncPgReader goes into infinite loop d...
Posted by kkhatua <gi...@git.apache.org>.
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/862
@parthchandra Please review the final change. I'll mark the JIRA with a ready-to-commit label if everything looks fine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---