You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gora.apache.org by kamaci <gi...@git.apache.org> on 2015/09/03 21:21:31 UTC
[GitHub] gora pull request: GORA-433 Non-Final Public Static Fields Should ...
GitHub user kamaci opened a pull request:
https://github.com/apache/gora/pull/37
GORA-433 Non-Final Public Static Fields Should Be Final
Non-final public static fields can be changed by external classes (by a malicious code or accidentally).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kamaci/gora GORA-433_2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/gora/pull/37.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #37
----
commit c8550d3558d1a438b64409bcbac94f072c191d23
Author: Furkan KAMACI <fu...@gmail.com>
Date: 2015-09-03T19:19:03Z
Non-final public static fields can be changed by external classes (by a malicious code or accidentally).
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request: GORA-433 Non-Final Public Static Fields Should ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/gora/pull/37
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request: GORA-433 Non-Final Public Static Fields Should ...
Posted by kamaci <gi...@git.apache.org>.
Github user kamaci commented on the pull request:
https://github.com/apache/gora/pull/37#issuecomment-137561837
I've updated PR. These changes don't break anything (also passes tests as well).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] gora pull request: GORA-433 Non-Final Public Static Fields Should ...
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the pull request:
https://github.com/apache/gora/pull/37#issuecomment-137548950
Does this only effect solr-store? Is this the entire PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---