You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/02 15:38:18 UTC
[GitHub] [spark] dongjoon-hyun opened a new pull request #29936: [WIP][BUILD][SQL] Remove Hive 1.2
dongjoon-hyun opened a new pull request #29936:
URL: https://github.com/apache/spark/pull/29936
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29936: [WIP][BUILD][SQL] Remove Hive 1.2
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-702928410
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33972/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29936: [WIP][BUILD][SQL] Remove Hive 1.2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-702968945
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29936: [WIP][BUILD][SQL][test-hadoop2.7] Remove Hive 1.2
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-703162593
**[Test build #129382 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129382/testReport)** for PR 29936 at commit [`16b3452`](https://github.com/apache/spark/commit/16b3452d88824615a094671cb5aa9b0bdba9b498).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on a change in pull request #29936: [SPARK-20202][BUILD][SQL] Remove references to org.spark-project.hive (Hive 1.2.1)
Posted by GitBox <gi...@apache.org>.
srowen commented on a change in pull request #29936:
URL: https://github.com/apache/spark/pull/29936#discussion_r499878361
##########
File path: pom.xml
##########
@@ -3150,23 +3146,7 @@
<profile>
<id>hive-1.2</id>
- <properties>
- <hive.group>org.spark-project.hive</hive.group>
- <hive.classifier></hive.classifier>
- <!-- Version used in Maven Hive dependency -->
- <hive.version>1.2.1.spark2</hive.version>
- <!-- Version used for internal directory structure -->
- <hive.version.short>1.2</hive.version.short>
- <hive.parquet.scope>${hive.deps.scope}</hive.parquet.scope>
- <hive.storage.version>2.6.0</hive.storage.version>
- <hive.storage.scope>provided</hive.storage.scope>
- <hive.common.scope>provided</hive.common.scope>
- <hive.llap.scope>provided</hive.llap.scope>
- <hive.serde.scope>provided</hive.serde.scope>
- <hive.shims.scope>provided</hive.shims.scope>
- <orc.classifier>nohive</orc.classifier>
- <datanucleus-core.version>3.2.10</datanucleus-core.version>
- </properties>
+ <!-- Exists only for backward compatibility. No-op. -->
Review comment:
No, it's just that you get an error if you specify `-Phive-1.2` if it's removed entirely. Now, maybe that's a good thing? previously for Scala profiles I had left them in because, for example `-Pscala-2.12` was not the default before. When it became the default, that would have caused an error even though it was already set up for 2.12. But this case is probably different: someone selecting Hive 1.x support should see an error, probably? in which case this should be removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29936: [WIP][BUILD][SQL] Remove Hive 1.2
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-702976090
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33976/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29936: [WIP][BUILD][SQL] Remove Hive 1.2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-702925341
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29936: [SPARK-20202][BUILD][SQL] Remove references to org.spark-project.hive (Hive 1.2.1)
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-703918291
**[Test build #129424 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129424/testReport)** for PR 29936 at commit [`c855260`](https://github.com/apache/spark/commit/c855260761af80b287caaea0ab071dbd15319265).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29936: [WIP][BUILD][SQL] Remove Hive 1.2
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-702969149
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33976/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on a change in pull request #29936: [SPARK-20202][BUILD][SQL] Remove references to org.spark-project.hive (Hive 1.2.1)
Posted by GitBox <gi...@apache.org>.
wangyum commented on a change in pull request #29936:
URL: https://github.com/apache/spark/pull/29936#discussion_r499330799
##########
File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
##########
@@ -296,8 +296,7 @@ private[hive] class HiveClientImpl(
case e: NoClassDefFoundError
if HiveUtils.isHive23 && e.getMessage.contains("org/apache/hadoop/hive/serde2/SerDe") =>
Review comment:
+1, we can remove `HiveUtils.isHive23` and related changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29936: [WIP][BUILD][SQL] Remove Hive 1.2
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-702921862
**[Test build #129363 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129363/testReport)** for PR 29936 at commit [`621582f`](https://github.com/apache/spark/commit/621582f40e4c0a088073e80fcfac91f3c17f31e8).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29936: [WIP][BUILD][SQL] Remove Hive 1.2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-702872832
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29936: [WIP][BUILD][SQL][test-hadoop2.7][test-hive1.2] Remove Hive 1.2
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-703165202
**[Test build #129383 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129383/testReport)** for PR 29936 at commit [`16b3452`](https://github.com/apache/spark/commit/16b3452d88824615a094671cb5aa9b0bdba9b498).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29936: [WIP][BUILD][SQL] Remove Hive 1.2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-702921895
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129363/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29936: [WIP][BUILD][SQL] Remove Hive 1.2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-702841805
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29936: [WIP][BUILD][SQL] Remove Hive 1.2
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-702968296
**[Test build #129362 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129362/testReport)** for PR 29936 at commit [`032499e`](https://github.com/apache/spark/commit/032499ea09191cf86aa5eb4f06ca559c5e30d0c2).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #29936: [SPARK-20202][BUILD][SQL] Remove references to org.spark-project.hive (Hive 1.2.1)
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-703361362
@wangyum can you review this? I think it's important to get your review here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29936: [WIP][BUILD][SQL] Remove Hive 1.2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-702976109
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #29936: [SPARK-20202][BUILD][SQL] Remove references to org.spark-project.hive (Hive 1.2.1)
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #29936:
URL: https://github.com/apache/spark/pull/29936#discussion_r499876526
##########
File path: pom.xml
##########
@@ -3150,23 +3146,7 @@
<profile>
<id>hive-1.2</id>
- <properties>
- <hive.group>org.spark-project.hive</hive.group>
- <hive.classifier></hive.classifier>
- <!-- Version used in Maven Hive dependency -->
- <hive.version>1.2.1.spark2</hive.version>
- <!-- Version used for internal directory structure -->
- <hive.version.short>1.2</hive.version.short>
- <hive.parquet.scope>${hive.deps.scope}</hive.parquet.scope>
- <hive.storage.version>2.6.0</hive.storage.version>
- <hive.storage.scope>provided</hive.storage.scope>
- <hive.common.scope>provided</hive.common.scope>
- <hive.llap.scope>provided</hive.llap.scope>
- <hive.serde.scope>provided</hive.serde.scope>
- <hive.shims.scope>provided</hive.shims.scope>
- <orc.classifier>nohive</orc.classifier>
- <datanucleus-core.version>3.2.10</datanucleus-core.version>
- </properties>
+ <!-- Exists only for backward compatibility. No-op. -->
Review comment:
So this profile is still useful?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29936: [SPARK-20202][BUILD][SQL] Remove references to org.spark-project.hive (Hive 1.2.1)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-703938862
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29936: [SPARK-20202][BUILD][SQL] Remove references to org.spark-project.hive (Hive 1.2.1)
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-703330783
Thank you, @srowen .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29936: [WIP][BUILD][SQL] Remove Hive 1.2
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-702908152
**[Test build #129362 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129362/testReport)** for PR 29936 at commit [`032499e`](https://github.com/apache/spark/commit/032499ea09191cf86aa5eb4f06ca559c5e30d0c2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29936: [WIP][BUILD][SQL][test-hadoop2.7] Remove Hive 1.2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-703171034
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #29936: [SPARK-20202][BUILD][SQL] Remove references to org.spark-project.hive (Hive 1.2.1)
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-703842774
Thank you so much for review, @HyukjinKwon and @wangyum . It's difficult to remove all conditional logics or comments in this PR. We have more instances in the test cases, too. I want to clean up them in another PR or a follow-up carefully. Is it okay for you guys? This PR focuses on removing `org.spark-project.hive` reference in mainly pom and source code structure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29936: [WIP][BUILD][SQL] Remove Hive 1.2
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-702841787
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33964/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29936: [SPARK-20202][BUILD][SQL] Remove references to org.spark-project.hive (Hive 1.2.1)
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-703963249
**[Test build #129424 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129424/testReport)** for PR 29936 at commit [`c855260`](https://github.com/apache/spark/commit/c855260761af80b287caaea0ab071dbd15319265).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29936: [WIP][BUILD][SQL][test-hadoop2.7][test-hive1.2] Remove Hive 1.2
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-703164619
Retest this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29936: [WIP][BUILD][SQL] Remove Hive 1.2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-702999949
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29936: [WIP][BUILD][SQL] Remove Hive 1.2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-702936163
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29936: [SPARK-20202][BUILD][SQL] Remove references to org.spark-project.hive (Hive 1.2.1)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-703963630
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29936: [WIP][BUILD][SQL] Remove Hive 1.2
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-702917408
**[Test build #129363 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129363/testReport)** for PR 29936 at commit [`621582f`](https://github.com/apache/spark/commit/621582f40e4c0a088073e80fcfac91f3c17f31e8).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29936: [WIP][BUILD][SQL] Remove Hive 1.2
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-702999509
**[Test build #129366 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129366/testReport)** for PR 29936 at commit [`16b3452`](https://github.com/apache/spark/commit/16b3452d88824615a094671cb5aa9b0bdba9b498).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29936: [SPARK-20202][BUILD][SQL] Remove references to org.spark-project.hive (Hive 1.2.1)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-703178237
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29936: [WIP][BUILD][SQL][test-hadoop2.7][test-hive1.2] Remove Hive 1.2
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-703165202
**[Test build #129383 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129383/testReport)** for PR 29936 at commit [`16b3452`](https://github.com/apache/spark/commit/16b3452d88824615a094671cb5aa9b0bdba9b498).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #29936: [SPARK-20202][BUILD][SQL] Remove references to org.spark-project.hive (Hive 1.2.1)
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-703956225
Yeah, followup is fine. LGTM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29936: [WIP][BUILD][SQL][test-hadoop2.7] Remove Hive 1.2
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-703168439
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33990/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29936: [SPARK-20202][BUILD][SQL] Remove references to org.spark-project.hive (Hive 1.2.1)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-703938862
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29936: [SPARK-20202][BUILD][SQL] Remove references to org.spark-project.hive (Hive 1.2.1)
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-703842774
Thank you so much for review, @HyukjinKwon and @wangyum . It's difficult to remove all conditional logics in this PR. We have more instances in the test cases, too. I want to clean up them in another PR or a follow-up carefully. Is it okay for you guys?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29936: [WIP][BUILD][SQL][test-hadoop2.7] Remove Hive 1.2
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-703171028
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33991/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29936: [SPARK-20202][BUILD][SQL] Remove references to org.spark-project.hive (Hive 1.2.1)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-703178237
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #29936: [SPARK-20202][BUILD][SQL] Remove references to org.spark-project.hive (Hive 1.2.1)
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #29936:
URL: https://github.com/apache/spark/pull/29936#discussion_r499320346
##########
File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
##########
@@ -296,8 +296,7 @@ private[hive] class HiveClientImpl(
case e: NoClassDefFoundError
if HiveUtils.isHive23 && e.getMessage.contains("org/apache/hadoop/hive/serde2/SerDe") =>
Review comment:
@dongjoon-hyun should we remove `HiveUtils.isHive23` and related changes? I see it was added when we add Hive 2.3 support at https://github.com/apache/spark/commit/33f3c48cac087e079b9c7e342c2e58b16eaaa681#diff-842e3447fc453de26c706db1cac8f2c4R59. cc @wangyum FYI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29936: [WIP][BUILD][SQL] Remove Hive 1.2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-702921886
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29936: [WIP][BUILD][SQL] Remove Hive 1.2
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-702936147
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33972/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29936: [SPARK-20202][BUILD][SQL] Remove references to org.spark-project.hive (Hive 1.2.1)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-703963634
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129424/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29936: [WIP][BUILD][SQL] Remove Hive 1.2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-702968945
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29936: [SPARK-20202][BUILD][SQL] Remove references to org.spark-project.hive (Hive 1.2.1)
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-703938842
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34031/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29936: [SPARK-20202][BUILD][SQL] Remove references to org.spark-project.hive (Hive 1.2.1)
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-703923535
Thank you all. Merged to master for Apache Spark 3.1.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29936: [SPARK-20202][BUILD][SQL] Remove references to org.spark-project.hive (Hive 1.2.1)
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-703933477
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34031/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29936: [WIP][BUILD][SQL][test-hadoop2.7] Remove Hive 1.2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-703168441
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #29936: [SPARK-20202][BUILD][SQL] Remove references to org.spark-project.hive (Hive 1.2.1)
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #29936:
URL: https://github.com/apache/spark/pull/29936
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29936: [WIP][BUILD][SQL][test-hadoop2.7][test-hive1.2] Remove Hive 1.2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-703165278
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29936: [WIP][BUILD][SQL] Remove Hive 1.2
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-702807613
**[Test build #129353 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129353/testReport)** for PR 29936 at commit [`032499e`](https://github.com/apache/spark/commit/032499ea09191cf86aa5eb4f06ca559c5e30d0c2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #29936: [SPARK-20202][BUILD][SQL] Remove references to org.spark-project.hive (Hive 1.2.1)
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #29936:
URL: https://github.com/apache/spark/pull/29936#discussion_r499884592
##########
File path: pom.xml
##########
@@ -3150,23 +3146,7 @@
<profile>
<id>hive-1.2</id>
- <properties>
- <hive.group>org.spark-project.hive</hive.group>
- <hive.classifier></hive.classifier>
- <!-- Version used in Maven Hive dependency -->
- <hive.version>1.2.1.spark2</hive.version>
- <!-- Version used for internal directory structure -->
- <hive.version.short>1.2</hive.version.short>
- <hive.parquet.scope>${hive.deps.scope}</hive.parquet.scope>
- <hive.storage.version>2.6.0</hive.storage.version>
- <hive.storage.scope>provided</hive.storage.scope>
- <hive.common.scope>provided</hive.common.scope>
- <hive.llap.scope>provided</hive.llap.scope>
- <hive.serde.scope>provided</hive.serde.scope>
- <hive.shims.scope>provided</hive.shims.scope>
- <orc.classifier>nohive</orc.classifier>
- <datanucleus-core.version>3.2.10</datanucleus-core.version>
- </properties>
+ <!-- Exists only for backward compatibility. No-op. -->
Review comment:
Yeah, this sounds more correct.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29936: [WIP][BUILD][SQL] Remove Hive 1.2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-702925341
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29936: [WIP][BUILD][SQL] Remove Hive 1.2
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-702829885
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33964/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29936: [WIP][BUILD][SQL][test-hadoop2.7][test-hive1.2] Remove Hive 1.2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-703165278
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29936: [WIP][BUILD][SQL] Remove Hive 1.2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-702936163
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29936: [WIP][BUILD][SQL] Remove Hive 1.2
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-702908152
**[Test build #129362 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129362/testReport)** for PR 29936 at commit [`032499e`](https://github.com/apache/spark/commit/032499ea09191cf86aa5eb4f06ca559c5e30d0c2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29936: [WIP][BUILD][SQL] Remove Hive 1.2
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-702953727
**[Test build #129366 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129366/testReport)** for PR 29936 at commit [`16b3452`](https://github.com/apache/spark/commit/16b3452d88824615a094671cb5aa9b0bdba9b498).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #29936: [SPARK-20202][BUILD][SQL] Remove references to org.spark-project.hive (Hive 1.2.1)
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #29936:
URL: https://github.com/apache/spark/pull/29936#discussion_r499323326
##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/execution/benchmark/InsertIntoHiveTableBenchmark.scala
##########
@@ -28,14 +28,11 @@ import org.apache.spark.sql.hive.test.TestHive
* {{{
Review comment:
Looks we can just remove this comment too:
https://github.com/apache/spark/blob/6be8b935a4f7ce0dea2d7aaaf747c2e8e1a9f47a/sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/HiveOrcQuerySuite.scala#L171-L173
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29936: [WIP][BUILD][SQL][test-hadoop2.7][test-hive1.2] Remove Hive 1.2
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-703165274
**[Test build #129383 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129383/testReport)** for PR 29936 at commit [`16b3452`](https://github.com/apache/spark/commit/16b3452d88824615a094671cb5aa9b0bdba9b498).
* This patch **fails some tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #29936: [SPARK-20202][BUILD][SQL] Remove references to org.spark-project.hive (Hive 1.2.1)
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-703894667
Looks OK and the tests/Github Actions were passed. It is okay to clean up other Hive 1.2 related code in next PRs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29936: [WIP][BUILD][SQL][test-hadoop2.7][test-hive1.2] Remove Hive 1.2
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-703166213
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33990/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29936: [WIP][BUILD][SQL][test-hadoop2.7] Remove Hive 1.2
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-703169437
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33991/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29936: [WIP][BUILD][SQL] Remove Hive 1.2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-702999949
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29936: [WIP][BUILD][SQL] Remove Hive 1.2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-702872832
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #29936: [SPARK-20202][BUILD][SQL] Remove references to org.spark-project.hive (Hive 1.2.1)
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #29936:
URL: https://github.com/apache/spark/pull/29936#discussion_r499321451
##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/execution/benchmark/InsertIntoHiveTableBenchmark.scala
##########
@@ -28,14 +28,11 @@ import org.apache.spark.sql.hive.test.TestHive
* {{{
Review comment:
I think we can now remove this comment https://github.com/apache/spark/commit/d7755cfd07554c132b7271730102b8b68eb56b28#diff-10e604a9a9d9c4bcc9cdc01049851095R170
and enable this test https://github.com/apache/spark/commit/d7755cfd07554c132b7271730102b8b68eb56b28#diff-10e604a9a9d9c4bcc9cdc01049851095R201. Feel free to ignore back if it fails for whatever reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29936: [SPARK-20202][BUILD][SQL] Remove references to org.spark-project.hive (Hive 1.2.1)
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-703844457
cc @dbtsai , @holdenk , @viirya , @sunchao
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29936: [WIP][BUILD][SQL] Remove Hive 1.2
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-702953727
**[Test build #129366 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129366/testReport)** for PR 29936 at commit [`16b3452`](https://github.com/apache/spark/commit/16b3452d88824615a094671cb5aa9b0bdba9b498).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29936: [WIP][BUILD][SQL] Remove Hive 1.2
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-702907893
Retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29936: [SPARK-20202][BUILD][SQL] Remove references to org.spark-project.hive (Hive 1.2.1)
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-703162593
**[Test build #129382 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129382/testReport)** for PR 29936 at commit [`16b3452`](https://github.com/apache/spark/commit/16b3452d88824615a094671cb5aa9b0bdba9b498).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29936: [SPARK-20202][BUILD][SQL] Remove references to org.spark-project.hive (Hive 1.2.1)
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #29936:
URL: https://github.com/apache/spark/pull/29936#discussion_r499897925
##########
File path: pom.xml
##########
@@ -3150,23 +3146,7 @@
<profile>
<id>hive-1.2</id>
- <properties>
- <hive.group>org.spark-project.hive</hive.group>
- <hive.classifier></hive.classifier>
- <!-- Version used in Maven Hive dependency -->
- <hive.version>1.2.1.spark2</hive.version>
- <!-- Version used for internal directory structure -->
- <hive.version.short>1.2</hive.version.short>
- <hive.parquet.scope>${hive.deps.scope}</hive.parquet.scope>
- <hive.storage.version>2.6.0</hive.storage.version>
- <hive.storage.scope>provided</hive.storage.scope>
- <hive.common.scope>provided</hive.common.scope>
- <hive.llap.scope>provided</hive.llap.scope>
- <hive.serde.scope>provided</hive.serde.scope>
- <hive.shims.scope>provided</hive.shims.scope>
- <orc.classifier>nohive</orc.classifier>
- <datanucleus-core.version>3.2.10</datanucleus-core.version>
- </properties>
+ <!-- Exists only for backward compatibility. No-op. -->
Review comment:
Got it. I'll remove this and raise error explicitly, @viirya and @srowen . :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29936: [WIP][BUILD][SQL] Remove Hive 1.2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-702925350
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/33973/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29936: [WIP][BUILD][SQL] Remove Hive 1.2
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-702917408
**[Test build #129363 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129363/testReport)** for PR 29936 at commit [`621582f`](https://github.com/apache/spark/commit/621582f40e4c0a088073e80fcfac91f3c17f31e8).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #29936: [SPARK-20202][BUILD][SQL] Remove references to org.spark-project.hive (Hive 1.2.1)
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #29936:
URL: https://github.com/apache/spark/pull/29936#discussion_r499876526
##########
File path: pom.xml
##########
@@ -3150,23 +3146,7 @@
<profile>
<id>hive-1.2</id>
- <properties>
- <hive.group>org.spark-project.hive</hive.group>
- <hive.classifier></hive.classifier>
- <!-- Version used in Maven Hive dependency -->
- <hive.version>1.2.1.spark2</hive.version>
- <!-- Version used for internal directory structure -->
- <hive.version.short>1.2</hive.version.short>
- <hive.parquet.scope>${hive.deps.scope}</hive.parquet.scope>
- <hive.storage.version>2.6.0</hive.storage.version>
- <hive.storage.scope>provided</hive.storage.scope>
- <hive.common.scope>provided</hive.common.scope>
- <hive.llap.scope>provided</hive.llap.scope>
- <hive.serde.scope>provided</hive.serde.scope>
- <hive.shims.scope>provided</hive.shims.scope>
- <orc.classifier>nohive</orc.classifier>
- <datanucleus-core.version>3.2.10</datanucleus-core.version>
- </properties>
+ <!-- Exists only for backward compatibility. No-op. -->
Review comment:
So this profile is still useful after we remove all the hive-1.2 stuffs?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29936: [WIP][BUILD][SQL][test-hadoop2.7] Remove Hive 1.2
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-703161855
Retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29936: [SPARK-20202][BUILD][SQL] Remove references to org.spark-project.hive (Hive 1.2.1)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-703963630
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29936: [WIP][BUILD][SQL][test-hadoop2.7] Remove Hive 1.2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-703171034
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #29936: [SPARK-20202][BUILD][SQL] Remove references to org.spark-project.hive (Hive 1.2.1)
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-703842774
Thank you so much for review, @HyukjinKwon and @wangyum . It's difficult to remove all conditional logics or comments in this PR. We have more instances in the test cases, too. I want to clean up them in another PR or a follow-up carefully. Is it okay for you guys?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29936: [SPARK-20202][BUILD][SQL] Remove references to org.spark-project.hive (Hive 1.2.1)
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-703918291
**[Test build #129424 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129424/testReport)** for PR 29936 at commit [`c855260`](https://github.com/apache/spark/commit/c855260761af80b287caaea0ab071dbd15319265).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29936: [SPARK-20202][BUILD][SQL] Remove references to org.spark-project.hive (Hive 1.2.1)
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-703178092
**[Test build #129382 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129382/testReport)** for PR 29936 at commit [`16b3452`](https://github.com/apache/spark/commit/16b3452d88824615a094671cb5aa9b0bdba9b498).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29936: [WIP][BUILD][SQL] Remove Hive 1.2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-702841805
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #29936: [SPARK-20202][BUILD][SQL] Remove references to org.spark-project.hive (Hive 1.2.1)
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-703842774
Thank you so much for review, @HyukjinKwon and @wangyum . It's difficult to remove all conditional logics / comments / website in this PR. We have more instances in the test cases, too. I want to clean up them in another PR or a follow-up carefully. Is it okay for you guys? This PR focuses on removing `org.spark-project.hive` reference in mainly pom and source code structure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29936: [WIP][BUILD][SQL][test-hadoop2.7] Remove Hive 1.2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-703168441
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29936: [WIP][BUILD][SQL] Remove Hive 1.2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-702921886
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #29936: [SPARK-20202][BUILD][SQL] Remove references to org.spark-project.hive (Hive 1.2.1)
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #29936:
URL: https://github.com/apache/spark/pull/29936#discussion_r499320462
##########
File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
##########
@@ -296,8 +296,7 @@ private[hive] class HiveClientImpl(
case e: NoClassDefFoundError
if HiveUtils.isHive23 && e.getMessage.contains("org/apache/hadoop/hive/serde2/SerDe") =>
Review comment:
@AngersZhuuuu should we remove https://github.com/apache/spark/blob/55ce49ed28a58e0047a9680fa63f4dff54c11be4/sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveScriptTransformationSuite.scala#L41 too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29936: [WIP][BUILD][SQL][test-hadoop2.7][test-hive1.2] Remove Hive 1.2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-703165280
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129383/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29936: [WIP][BUILD][SQL] Remove Hive 1.2
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29936:
URL: https://github.com/apache/spark/pull/29936#issuecomment-702976109
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org