You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/10/23 13:13:09 UTC

[GitHub] [phoenix] stoty commented on pull request #936: PHOENIX-5998 Paged server side ungrouped aggregate operations

stoty commented on pull request #936:
URL: https://github.com/apache/phoenix/pull/936#issuecomment-715332240


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   1m  8s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 1 new or modified test files.  |
   ||| _ 4.x Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |  11m 39s |  4.x passed  |
   | +1 :green_heart: |  compile  |   1m  1s |  4.x passed  |
   | +1 :green_heart: |  checkstyle  |   1m  1s |  4.x passed  |
   | +1 :green_heart: |  javadoc  |   0m 47s |  4.x passed  |
   | +0 :ok: |  spotbugs  |   3m  6s |  phoenix-core in 4.x has 954 extant spotbugs warnings.  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   6m 21s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m  1s |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m  1s |  the patch passed  |
   | -1 :x: |  checkstyle  |   1m  5s |  phoenix-core: The patch generated 303 new + 1695 unchanged - 208 fixed = 1998 total (was 1903)  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace issues.  |
   | +1 :green_heart: |  javadoc  |   0m 45s |  the patch passed  |
   | -1 :x: |  spotbugs  |   3m 25s |  phoenix-core generated 1 new + 953 unchanged - 1 fixed = 954 total (was 954)  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  | 185m 54s |  phoenix-core in the patch failed.  |
   | +1 :green_heart: |  asflicense  |   0m 31s |  The patch does not generate ASF License warnings.  |
   |  |   | 220m 17s |   |
   
   
   | Reason | Tests |
   |-------:|:------|
   | FindBugs | module:phoenix-core |
   |  |  Switch statement found in org.apache.phoenix.coprocessor.UngroupedAggregateRegionScanner.descRowKeyOrderUpgrade(List, ImmutableBytesWritable, UngroupedAggregateRegionObserver$MutationList) where default case is missing  At UngroupedAggregateRegionScanner.java:ImmutableBytesWritable, UngroupedAggregateRegionObserver$MutationList) where default case is missing  At UngroupedAggregateRegionScanner.java:[lines 391-412] |
   | Failed junit tests | phoenix.end2end.TenantSpecificViewIndexSaltedIT |
   |   | phoenix.end2end.SpillableGroupByIT |
   |   | phoenix.execute.UpsertSelectOverlappingBatchesIT |
   |   | phoenix.end2end.UpsertSelectIT |
   |   | phoenix.end2end.StringToArrayFunctionIT |
   |   | phoenix.end2end.index.MutableIndexSplitForwardScanIT |
   |   | phoenix.end2end.join.HashJoinPersistentCacheIT |
   |   | phoenix.end2end.QueryDatabaseMetaDataIT |
   |   | phoenix.end2end.RowTimestampIT |
   |   | phoenix.end2end.ArithmeticQueryIT |
   |   | phoenix.end2end.InListIT |
   |   | phoenix.end2end.index.InvalidIndexStateClientSideIT |
   |   | phoenix.end2end.OrphanViewToolIT |
   |   | phoenix.end2end.BackwardCompatibilityIT |
   |   | phoenix.end2end.index.LocalImmutableNonTxIndexIT |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-936/2/artifact/yetus-general-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/phoenix/pull/936 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile |
   | uname | Linux b1c316e10591 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev/phoenix-personality.sh |
   | git revision | 4.x / 605656c |
   | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
   | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-936/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
   | spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-936/2/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html |
   | unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-936/2/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt |
   |  Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-936/2/testReport/ |
   | Max. process+thread count | 6113 (vs. ulimit of 30000) |
   | modules | C: phoenix-core U: phoenix-core |
   | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-936/2/console |
   | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org