You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "orionlibs (via GitHub)" <gi...@apache.org> on 2023/07/16 00:56:57 UTC
[GitHub] [commons-email] orionlibs opened a new pull request, #153: EMAIL-205: removed dead code
orionlibs opened a new pull request, #153:
URL: https://github.com/apache/commons-email/pull/153
[EMAIL-205](https://issues.apache.org/jira/browse/EMAIL-205): removed dead code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-email] orionlibs commented on a diff in pull request #153: EMAIL-205: removed dead code
Posted by "orionlibs (via GitHub)" <gi...@apache.org>.
orionlibs commented on code in PR #153:
URL: https://github.com/apache/commons-email/pull/153#discussion_r1265946647
##########
src/main/java/org/apache/commons/mail/EmailUtils.java:
##########
@@ -295,10 +295,6 @@ static String encodeUrl(final String input) throws UnsupportedEncodingException
for (final byte c : input.getBytes(US_ASCII))
{
int b = c;
- if (b < 0)
Review Comment:
@aherbert done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] EMAIL-205: Update conversion code [commons-email]
Posted by "AdamGEmerson (via GitHub)" <gi...@apache.org>.
AdamGEmerson commented on PR #153:
URL: https://github.com/apache/commons-email/pull/153#issuecomment-1837500267
I created this issue on Jira after digging into the code during a school assignment. Nice to see those test cases led to something!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] EMAIL-205: removed dead code [commons-email]
Posted by "orionlibs (via GitHub)" <gi...@apache.org>.
orionlibs commented on PR #153:
URL: https://github.com/apache/commons-email/pull/153#issuecomment-1837483317
this PR has been open for half a year
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] EMAIL-205: Update conversion code [commons-email]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory merged PR #153:
URL: https://github.com/apache/commons-email/pull/153
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-email] aherbert commented on a diff in pull request #153: EMAIL-205: removed dead code
Posted by "aherbert (via GitHub)" <gi...@apache.org>.
aherbert commented on code in PR #153:
URL: https://github.com/apache/commons-email/pull/153#discussion_r1264625263
##########
src/main/java/org/apache/commons/mail/EmailUtils.java:
##########
@@ -295,10 +295,6 @@ static String encodeUrl(final String input) throws UnsupportedEncodingException
for (final byte c : input.getBytes(US_ASCII))
{
int b = c;
- if (b < 0)
Review Comment:
This is not dead code. It converts a signed 8-bit number (byte) to an unsigned 8-bit number, stored in an integer. It could be replaced with:
```Java
int b = c & 0xff;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-email] orionlibs commented on pull request #153: EMAIL-205: removed dead code
Posted by "orionlibs (via GitHub)" <gi...@apache.org>.
orionlibs commented on PR #153:
URL: https://github.com/apache/commons-email/pull/153#issuecomment-1735966009
this PR was done 70 days ago. It needs review and merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org