You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andriy Babiichuk <ab...@hortonworks.com> on 2015/02/16 17:29:00 UTC

Review Request 31086: Modify flow for checking and authenticating admin principal to make it more robust (Add Services / Add Host)

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31086/
-----------------------------------------------------------

Review request for Ambari and Aleksandr Kovalenko.


Bugs: AMBARI-9660
    https://issues.apache.org/jira/browse/AMBARI-9660


Repository: ambari


Description
-------

Handle KDC session fail using new api that allows to check kdc state by GET request for Add Services and Add Hosts.


Diffs
-----

  ambari-web/app/controllers/main/admin/kerberos.js d04cc9238c017308e9f3bb2710596f7139288388 
  ambari-web/app/controllers/main/host/add_controller.js 03a250682613d0f3281384ed8e7e71e990e68636 
  ambari-web/app/controllers/main/service/add_controller.js 51c126439135170d16541599a5d6b572555137aa 
  ambari-web/app/controllers/wizard/step8_controller.js 2acb762c4f0b8b8c859363f6ff851901422a0bb5 
  ambari-web/app/controllers/wizard/step9_controller.js be9999b3f3589c9e158dc4b9fb13cdcc4c0f7098 
  ambari-web/app/routes/add_host_routes.js 6abce6057c86279329c997edaf6ce29fc7c9b59b 
  ambari-web/app/utils/ajax/ajax.js d739da79d9c16652df3edd2d715a5ef32a3655d2 
  ambari-web/app/utils/helper.js c2cb990b1edcd974d112ee42685c2d60ff44a507 
  ambari-web/test/controllers/wizard/step8_test.js 4c89ed618ed623f0125c839226b9c7f78fbf4071 
  ambari-web/test/utils/helper_test.js ab59276f98b690ca8535f4b282a4a477d30be3bb 

Diff: https://reviews.apache.org/r/31086/diff/


Testing
-------

5395 tests complete (9 seconds)
  62 tests pending


Thanks,

Andriy Babiichuk


Re: Review Request 31086: Modify flow for checking and authenticating admin principal to make it more robust (Add Services / Add Host)

Posted by Aleksandr Kovalenko <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31086/#review72622
-----------------------------------------------------------

Ship it!


Ship It!

- Aleksandr Kovalenko


On Лют. 16, 2015, 4:28 після полудня, Andriy Babiichuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31086/
> -----------------------------------------------------------
> 
> (Updated Лют. 16, 2015, 4:28 після полудня)
> 
> 
> Review request for Ambari and Aleksandr Kovalenko.
> 
> 
> Bugs: AMBARI-9660
>     https://issues.apache.org/jira/browse/AMBARI-9660
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Handle KDC session fail using new api that allows to check kdc state by GET request for Add Services and Add Hosts.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/main/admin/kerberos.js d04cc9238c017308e9f3bb2710596f7139288388 
>   ambari-web/app/controllers/main/host/add_controller.js 03a250682613d0f3281384ed8e7e71e990e68636 
>   ambari-web/app/controllers/main/service/add_controller.js 51c126439135170d16541599a5d6b572555137aa 
>   ambari-web/app/controllers/wizard/step8_controller.js 2acb762c4f0b8b8c859363f6ff851901422a0bb5 
>   ambari-web/app/controllers/wizard/step9_controller.js be9999b3f3589c9e158dc4b9fb13cdcc4c0f7098 
>   ambari-web/app/routes/add_host_routes.js 6abce6057c86279329c997edaf6ce29fc7c9b59b 
>   ambari-web/app/utils/ajax/ajax.js d739da79d9c16652df3edd2d715a5ef32a3655d2 
>   ambari-web/app/utils/helper.js c2cb990b1edcd974d112ee42685c2d60ff44a507 
>   ambari-web/test/controllers/wizard/step8_test.js 4c89ed618ed623f0125c839226b9c7f78fbf4071 
>   ambari-web/test/utils/helper_test.js ab59276f98b690ca8535f4b282a4a477d30be3bb 
> 
> Diff: https://reviews.apache.org/r/31086/diff/
> 
> 
> Testing
> -------
> 
> 5395 tests complete (9 seconds)
>   62 tests pending
> 
> 
> Thanks,
> 
> Andriy Babiichuk
> 
>