You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/11/05 23:23:05 UTC
[GitHub] [kafka] bbejeck commented on a change in pull request #9565: MINOR: Move upgraded docs from site to Kafka docs
bbejeck commented on a change in pull request #9565:
URL: https://github.com/apache/kafka/pull/9565#discussion_r518417041
##########
File path: docs/js/templateData.js
##########
@@ -19,6 +19,6 @@ limitations under the License.
var context={
"version": "26",
"dotVersion": "2.6",
- "fullDotVersion": "2.6.1",
+ "fullDotVersion": "2.6.0",
Review comment:
this needs to be `2.6.1`
##########
File path: docs/quickstart-zookeeper.html
##########
@@ -0,0 +1,277 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+
+<script>
+ <!--#include virtual="js/templateData.js" -->
+</script>
+
+<script id="quickstart-template" type="text/x-handlebars-template">
+
+ <div class="quickstart-step">
+ <h4 class="anchor-heading">
+ <a class="anchor-link" id="quickstart_download" href="#quickstart_download"></a>
+ <a href="#quickstart_download">Step 1: Get Kafka</a>
+ </h4>
+
+ <p>
Review comment:
refs in this file to `2.6.0` need to be `2.6.1`
##########
File path: docs/security.html
##########
@@ -316,28 +294,24 @@ <h5>Host Name Verification</h5>
harder for a malicious party to obtain certificates with potentially misleading or fraudulent values.
It is adviseable to double check signed certificates, whether these contain all requested SAN fields to enable proper hostname verification.
The following command can be used to print certificate details to the console, which should be compared with what was originally requested:
- <pre class="brush: bash;">
- openssl x509 -in certificate.crt -text -noout
- </pre>
+ <pre class="line-numbers"><code class="language-bash"> openssl x509 -in certificate.crt -text -noout</code></pre>
</li>
</ol>
</li>
- <li><h4><a id="security_configbroker" href="#security_configbroker">Configuring Kafka Brokers</a></h4>
+ <li><h4 class="anchor-heading"><a id="security_configbroker" class="anchor-link"></a><a href="#security_configbroker">Configuring Kafka Brokers</a></h4>
Kafka Brokers support listening for connections on multiple ports.
We need to configure the following property in server.properties, which must have one or more comma-separated values:
- <pre>listeners</pre>
+ <pre>listeners</code></pre>
Review comment:
ditto
##########
File path: docs/ops.html
##########
@@ -538,98 +472,74 @@ <h5>Safe usage of throttled replication</h5>
<p><i>(2) Ensuring Progress:</i></p>
<p>If the throttle is set too low, in comparison to the incoming write rate, it is possible for replication to not
make progress. This occurs when:</p>
- <pre>max(BytesInPerSec) > throttle</pre>
+ <pre>max(BytesInPerSec) > throttle</code></pre>
<p>
Where BytesInPerSec is the metric that monitors the write throughput of producers into each broker. </p>
<p>The administrator can monitor whether replication is making progress, during the rebalance, using the metric:</p>
- <pre>kafka.server:type=FetcherLagMetrics,name=ConsumerLag,clientId=([-.\w]+),topic=([-.\w]+),partition=([0-9]+)</pre>
+ <pre>kafka.server:type=FetcherLagMetrics,name=ConsumerLag,clientId=([-.\w]+),topic=([-.\w]+),partition=([0-9]+)</code></pre>
Review comment:
same here
##########
File path: docs/upgrade.html
##########
@@ -39,17 +81,51 @@ <h5><a id="upgrade_260_notable" href="#upgrade_260_notable">Notable changes in 2
Fetch requests and other requests intended only for the leader or follower return NOT_LEADER_OR_FOLLOWER(6) instead of REPLICA_NOT_AVAILABLE(9)
if the broker is not a replica, ensuring that this transient error during reassignments is handled by all clients as a retriable exception.
</li>
- <li>There are several notable changes to the reassignment tool <code>kafka-reassign-partitions.sh</code>
Review comment:
This section should go back in I believe
##########
File path: docs/ops.html
##########
@@ -1653,9 +1559,9 @@ <h4><a id="kafka_streams_monitoring" href="#kafka_streams_monitoring">Streams Mo
Use the following configuration option to specify which metrics
you want collected:
-<pre>metrics.recording.level="info"</pre>
+<pre>metrics.recording.level="info"</code></pre>
Review comment:
here too
##########
File path: docs/ops.html
##########
@@ -538,98 +472,74 @@ <h5>Safe usage of throttled replication</h5>
<p><i>(2) Ensuring Progress:</i></p>
<p>If the throttle is set too low, in comparison to the incoming write rate, it is possible for replication to not
make progress. This occurs when:</p>
- <pre>max(BytesInPerSec) > throttle</pre>
+ <pre>max(BytesInPerSec) > throttle</code></pre>
Review comment:
this is missing an opening `<code>`
##########
File path: docs/upgrade.html
##########
@@ -19,7 +19,49 @@
<script id="upgrade-template" type="text/x-handlebars-template">
-<h5><a id="upgrade_260_notable" href="#upgrade_260_notable">Notable changes in 2.6.0</a></h5>
+<h4><a id="upgrade_2_6_0" href="#upgrade_2_6_0">Upgrading to 2.6.0 from any version 0.8.x through 2.5.x</a></h4>
Review comment:
I think `Upgrading to 2.6.0` needs to go to `Upgrading to 2.6.1`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org