You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by shahidki31 <gi...@git.apache.org> on 2018/10/13 17:56:10 UTC
[GitHub] spark pull request #22714: [SPARK-25720][WEBUI] Support auto refresh page fo...
GitHub user shahidki31 opened a pull request:
https://github.com/apache/spark/pull/22714
[SPARK-25720][WEBUI] Support auto refresh page for the WEBUI
## What changes were proposed in this pull request?
Currently spark webui doesn't have an option of auto refresh page. Because of this, user has to reload
every time to see the updates in the page.
For SQL page and Streaming page, currently we are passing the refresh interval, but it is not implemented in the 'headerSparkPage' method. This PR, added the refresh functionality to the webui.
## How was this patch tested?
Manually verified.
Every 5 seconds the SQL page is refreshing.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shahidki31/spark refresh
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/22714.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22714
----
commit 95b6a1e3cdcce51dc2c57a4feac47208ebd4e390
Author: Shahid <sh...@...>
Date: 2018-10-13T17:41:30Z
refresh page
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22714: [SPARK-25720][WEBUI] Support auto refresh page for the W...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22714
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22714: [SPARK-25720][WEBUI] Support auto refresh page fo...
Posted by shahidki31 <gi...@git.apache.org>.
Github user shahidki31 closed the pull request at:
https://github.com/apache/spark/pull/22714
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22714: [SPARK-25720][WEBUI] Support auto refresh page for the W...
Posted by shahidki31 <gi...@git.apache.org>.
Github user shahidki31 commented on the issue:
https://github.com/apache/spark/pull/22714
Thank you @srowen for the comment. Yes, we should not hard-code the refresh interval and we let the user to enable the parameter. I will update the code accordingly.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22714: [SPARK-25720][WEBUI] Support auto refresh page for the W...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22714
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22714: [SPARK-25720][WEBUI] Support auto refresh page for the W...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/22714
can this be passed in as a param in the url?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22714: [SPARK-25720][WEBUI] Support auto refresh page for the W...
Posted by shahidki31 <gi...@git.apache.org>.
Github user shahidki31 commented on the issue:
https://github.com/apache/spark/pull/22714
@gengliangwang Sorry, I didn't see the PR. Yes, that PR also for refreshing functionality for the webui.
I have taken the patch and checked the functionality, and it seems fine. Below is the screen shot of the ui.
**Except the alignment of the tabs,** functionality seems good.
**After the patch**
**Before the patch**
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22714: [SPARK-25720][WEBUI] Support auto refresh page for the W...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22714
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22714: [SPARK-25720][WEBUI] Support auto refresh page for the W...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22714
Shouldn't it go in `commonHeaderNodes`?
Looks like this was added waaay back in https://github.com/JoshRosen/spark/commit/6aa08c39cf30fa5c4ed97f4fff16371b9030a2e6 by @tdas but never used. Only a few call sites set it. The problem I can see is that those hard-code it to 5 second refreshes.
I think we'd have to introduce a new parameter to control this, like `spark.ui.refreshInterval` or something, and then stop passing it into this method and just read it in this code somewhere?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22714: [SPARK-25720][WEBUI] Support auto refresh page for the W...
Posted by shahidki31 <gi...@git.apache.org>.
Github user shahidki31 commented on the issue:
https://github.com/apache/spark/pull/22714
I am closing the PR, since already one PR is there for the webui auto refresh. Thanks.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22714: [SPARK-25720][WEBUI] Support auto refresh page for the W...
Posted by shahidki31 <gi...@git.apache.org>.
Github user shahidki31 commented on the issue:
https://github.com/apache/spark/pull/22714
cc @srowen @cloud-fan . Kindly review.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22714: [SPARK-25720][WEBUI] Support auto refresh page for the W...
Posted by gengliangwang <gi...@git.apache.org>.
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/22714
BTW there is another approach: https://github.com/apache/spark/pull/21512
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org