[GitHub] [incubator-dolphinscheduler] lenboo commented on a change in pull request #1973: #1310 add executor user to the process instance & task instance pages

[GitBox <gi...@apache.org>]

lenboo commented on a change in pull request #1973: #1310 add executor user to the process instance & task instance pages
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1973#discussion_r381042144
 
 

 ##########
 File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/TaskInstanceService.java
 ##########
 @@ -111,18 +116,35 @@
             return result;
         }
 
+
         Page<TaskInstance> page = new Page(pageNo, pageSize);
+        PageInfo pageInfo = new PageInfo<TaskInstance>(pageNo, pageSize);
+
+        //executor name query
+        int executorId = 0;
+        if (StringUtils.isNotEmpty(executorName)) {
 
 Review comment:
   Can duplicate code be refactored together？
   Suggest that put these them in UserService.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services