You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Ravi Magham <ma...@gmail.com> on 2016/01/31 06:39:26 UTC
Re: Review Request 42809: SQOOP-2649 : Support for importing data onto
Apache Phoenix tables
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42809/
-----------------------------------------------------------
(Updated Jan. 31, 2016, 5:39 a.m.)
Review request for Sqoop and Venkat Ranganathan.
Repository: sqoop-trunk
Description
-------
Support for importing data onto Apache Phoenix tables
Diffs
-----
build.xml d614d09
ivy.xml a93d0af
ivy/ivysettings.xml 2920c89
src/docs/user/import.txt df04157
src/docs/user/phoenix-args.txt PRE-CREATION
src/docs/user/phoenix.txt PRE-CREATION
src/docs/user/validation.txt 27a78e2
src/java/org/apache/sqoop/SqoopOptions.java ef6e0ce
src/java/org/apache/sqoop/manager/ConnManager.java d9569c5
src/java/org/apache/sqoop/manager/SqlManager.java ead581d
src/java/org/apache/sqoop/mapreduce/ImportJobBase.java 04d60fd
src/java/org/apache/sqoop/mapreduce/PhoenixBulkImportJob.java PRE-CREATION
src/java/org/apache/sqoop/mapreduce/PhoenixBulkImportMapper.java PRE-CREATION
src/java/org/apache/sqoop/mapreduce/PhoenixImportJob.java PRE-CREATION
src/java/org/apache/sqoop/mapreduce/PhoenixImportMapper.java PRE-CREATION
src/java/org/apache/sqoop/phoenix/PhoenixConstants.java PRE-CREATION
src/java/org/apache/sqoop/phoenix/PhoenixSqoopWritable.java PRE-CREATION
src/java/org/apache/sqoop/phoenix/PhoenixUtil.java PRE-CREATION
src/java/org/apache/sqoop/tool/BaseSqoopTool.java c97bb58
src/java/org/apache/sqoop/tool/ImportTool.java c79e044
src/test/org/apache/sqoop/phoenix/PhoenixBaseTestCase.java PRE-CREATION
src/test/org/apache/sqoop/phoenix/PhoenixBasicImportTest.java PRE-CREATION
src/test/org/apache/sqoop/phoenix/PhoenixBulkImportTest.java PRE-CREATION
src/test/org/apache/sqoop/phoenix/PhoenixQueryImportTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/42809/diff/
Testing
-------
Thanks,
Ravi Magham
Re: Review Request 42809: SQOOP-2649 : Support for importing data onto
Apache Phoenix tables
Posted by Venkat Ranganathan <n....@live.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42809/#review119105
-----------------------------------------------------------
build.xml (line 195)
<https://reviews.apache.org/r/42809/#comment180367>
Line with spaces - nit pick
ivy/ivysettings.xml (line 37)
<https://reviews.apache.org/r/42809/#comment180369>
Trailing spaces
src/docs/user/phoenix.txt (line 12)
<https://reviews.apache.org/r/42809/#comment180368>
please remove trailing spaces
src/java/org/apache/sqoop/SqoopOptions.java (line 2423)
<https://reviews.apache.org/r/42809/#comment180370>
trailing spaces
- Venkat Ranganathan
On Feb. 1, 2016, 12:49 a.m., Ravi Magham wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42809/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2016, 12:49 a.m.)
>
>
> Review request for Sqoop and Venkat Ranganathan.
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Support for importing data onto Apache Phoenix tables
>
>
> Diffs
> -----
>
> build.xml d614d09
> ivy.xml a93d0af
> ivy/ivysettings.xml 2920c89
> src/docs/user/import.txt df04157
> src/docs/user/phoenix-args.txt PRE-CREATION
> src/docs/user/phoenix.txt PRE-CREATION
> src/docs/user/validation.txt 27a78e2
> src/java/org/apache/sqoop/SqoopOptions.java ef6e0ce
> src/java/org/apache/sqoop/manager/ConnManager.java d9569c5
> src/java/org/apache/sqoop/manager/SqlManager.java ead581d
> src/java/org/apache/sqoop/mapreduce/ImportJobBase.java 04d60fd
> src/java/org/apache/sqoop/mapreduce/PhoenixBulkImportJob.java PRE-CREATION
> src/java/org/apache/sqoop/mapreduce/PhoenixBulkImportMapper.java PRE-CREATION
> src/java/org/apache/sqoop/mapreduce/PhoenixImportJob.java PRE-CREATION
> src/java/org/apache/sqoop/mapreduce/PhoenixImportMapper.java PRE-CREATION
> src/java/org/apache/sqoop/phoenix/PhoenixConstants.java PRE-CREATION
> src/java/org/apache/sqoop/phoenix/PhoenixSqoopWritable.java PRE-CREATION
> src/java/org/apache/sqoop/phoenix/PhoenixUtil.java PRE-CREATION
> src/java/org/apache/sqoop/tool/BaseSqoopTool.java c97bb58
> src/java/org/apache/sqoop/tool/ImportTool.java c79e044
> src/test/org/apache/sqoop/phoenix/PhoenixBaseTestCase.java PRE-CREATION
> src/test/org/apache/sqoop/phoenix/PhoenixBasicImportTest.java PRE-CREATION
> src/test/org/apache/sqoop/phoenix/PhoenixBulkImportTest.java PRE-CREATION
> src/test/org/apache/sqoop/phoenix/PhoenixQueryImportTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42809/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ravi Magham
>
>
Re: Review Request 42809: SQOOP-2649 : Support for importing data onto
Apache Phoenix tables
Posted by Venkat Ranganathan <n....@live.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42809/#review122617
-----------------------------------------------------------
There are still a few whitespace issues. Will fix and validate it.
Thanks
src/java/org/apache/sqoop/tool/BaseSqoopTool.java (line 798)
<https://reviews.apache.org/r/42809/#comment184726>
Trailing space
src/java/org/apache/sqoop/tool/BaseSqoopTool.java (line 1676)
<https://reviews.apache.org/r/42809/#comment184727>
Line with only spaces
src/java/org/apache/sqoop/tool/BaseSqoopTool.java (line 1680)
<https://reviews.apache.org/r/42809/#comment184728>
Tabs
- Venkat Ranganathan
On March 5, 2016, 9:43 p.m., Ravi Magham wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42809/
> -----------------------------------------------------------
>
> (Updated March 5, 2016, 9:43 p.m.)
>
>
> Review request for Sqoop and Venkat Ranganathan.
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Support for importing data onto Apache Phoenix tables
>
>
> Diffs
> -----
>
> build.xml d614d09
> ivy.xml a93d0af
> ivy/ivysettings.xml 2920c89
> src/docs/user/import.txt df04157
> src/docs/user/phoenix-args.txt PRE-CREATION
> src/docs/user/phoenix.txt PRE-CREATION
> src/docs/user/validation.txt 27a78e2
> src/java/org/apache/sqoop/SqoopOptions.java ef6e0ce
> src/java/org/apache/sqoop/manager/ConnManager.java d9569c5
> src/java/org/apache/sqoop/manager/SqlManager.java ead581d
> src/java/org/apache/sqoop/mapreduce/ImportJobBase.java 04d60fd
> src/java/org/apache/sqoop/mapreduce/PhoenixBulkImportJob.java PRE-CREATION
> src/java/org/apache/sqoop/mapreduce/PhoenixBulkImportMapper.java PRE-CREATION
> src/java/org/apache/sqoop/mapreduce/PhoenixImportJob.java PRE-CREATION
> src/java/org/apache/sqoop/mapreduce/PhoenixImportMapper.java PRE-CREATION
> src/java/org/apache/sqoop/phoenix/PhoenixConstants.java PRE-CREATION
> src/java/org/apache/sqoop/phoenix/PhoenixSqoopWritable.java PRE-CREATION
> src/java/org/apache/sqoop/phoenix/PhoenixUtil.java PRE-CREATION
> src/java/org/apache/sqoop/tool/BaseSqoopTool.java c97bb58
> src/java/org/apache/sqoop/tool/ImportTool.java c79e044
> src/test/org/apache/sqoop/phoenix/PhoenixBaseTestCase.java PRE-CREATION
> src/test/org/apache/sqoop/phoenix/PhoenixBasicImportTest.java PRE-CREATION
> src/test/org/apache/sqoop/phoenix/PhoenixBulkImportTest.java PRE-CREATION
> src/test/org/apache/sqoop/phoenix/PhoenixQueryImportTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42809/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ravi Magham
>
>
Re: Review Request 42809: SQOOP-2649 : Support for importing data onto
Apache Phoenix tables
Posted by Venkat Ranganathan <n....@live.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42809/#review122618
-----------------------------------------------------------
The patch does not apply - Can you please rebase and upload a new patch
Thanks
- Venkat Ranganathan
On March 5, 2016, 9:43 p.m., Ravi Magham wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42809/
> -----------------------------------------------------------
>
> (Updated March 5, 2016, 9:43 p.m.)
>
>
> Review request for Sqoop and Venkat Ranganathan.
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Support for importing data onto Apache Phoenix tables
>
>
> Diffs
> -----
>
> build.xml d614d09
> ivy.xml a93d0af
> ivy/ivysettings.xml 2920c89
> src/docs/user/import.txt df04157
> src/docs/user/phoenix-args.txt PRE-CREATION
> src/docs/user/phoenix.txt PRE-CREATION
> src/docs/user/validation.txt 27a78e2
> src/java/org/apache/sqoop/SqoopOptions.java ef6e0ce
> src/java/org/apache/sqoop/manager/ConnManager.java d9569c5
> src/java/org/apache/sqoop/manager/SqlManager.java ead581d
> src/java/org/apache/sqoop/mapreduce/ImportJobBase.java 04d60fd
> src/java/org/apache/sqoop/mapreduce/PhoenixBulkImportJob.java PRE-CREATION
> src/java/org/apache/sqoop/mapreduce/PhoenixBulkImportMapper.java PRE-CREATION
> src/java/org/apache/sqoop/mapreduce/PhoenixImportJob.java PRE-CREATION
> src/java/org/apache/sqoop/mapreduce/PhoenixImportMapper.java PRE-CREATION
> src/java/org/apache/sqoop/phoenix/PhoenixConstants.java PRE-CREATION
> src/java/org/apache/sqoop/phoenix/PhoenixSqoopWritable.java PRE-CREATION
> src/java/org/apache/sqoop/phoenix/PhoenixUtil.java PRE-CREATION
> src/java/org/apache/sqoop/tool/BaseSqoopTool.java c97bb58
> src/java/org/apache/sqoop/tool/ImportTool.java c79e044
> src/test/org/apache/sqoop/phoenix/PhoenixBaseTestCase.java PRE-CREATION
> src/test/org/apache/sqoop/phoenix/PhoenixBasicImportTest.java PRE-CREATION
> src/test/org/apache/sqoop/phoenix/PhoenixBulkImportTest.java PRE-CREATION
> src/test/org/apache/sqoop/phoenix/PhoenixQueryImportTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42809/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ravi Magham
>
>
Re: Review Request 42809: SQOOP-2649 : Support for importing data onto
Apache Phoenix tables
Posted by Ravi Magham <ma...@gmail.com>.
> On March 12, 2016, 8:09 p.m., Venkat Ranganathan wrote:
> > Thanks for working on this. Looking through this, I am trying to make sure we can build (but not have the functionality ) in older versions of hadoop and hbase.
> > Is it possible to add reflection to identify and fail if the hadoop version and hbase version are not right.
> >
> > We always have newer capabilities from dependent products used (for example 2.6.0 Hadoop features are used for password alias), but we do reflection in those cases to not disable the building with older versions
> >
> > Venkat
Sounds a good idea Venkat. Will have it implemented and push another patch .
- Ravi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42809/#review123287
-----------------------------------------------------------
On March 11, 2016, 6:32 p.m., Ravi Magham wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42809/
> -----------------------------------------------------------
>
> (Updated March 11, 2016, 6:32 p.m.)
>
>
> Review request for Sqoop and Venkat Ranganathan.
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Support for importing data onto Apache Phoenix tables
>
>
> Diffs
> -----
>
> build.xml 97e5502
> ivy.xml d84b88f
> ivy/ivysettings.xml 2920c89
> src/docs/user/import.txt fbb32f5
> src/docs/user/phoenix-args.txt PRE-CREATION
> src/docs/user/phoenix.txt PRE-CREATION
> src/docs/user/validation.txt 27a78e2
> src/java/org/apache/sqoop/SqoopOptions.java 17751c7
> src/java/org/apache/sqoop/manager/ConnManager.java 1811ce0
> src/java/org/apache/sqoop/manager/SqlManager.java 768507b
> src/java/org/apache/sqoop/mapreduce/ImportJobBase.java 9b6e1a0
> src/java/org/apache/sqoop/mapreduce/PhoenixBulkImportJob.java PRE-CREATION
> src/java/org/apache/sqoop/mapreduce/PhoenixBulkImportMapper.java PRE-CREATION
> src/java/org/apache/sqoop/mapreduce/PhoenixImportJob.java PRE-CREATION
> src/java/org/apache/sqoop/mapreduce/PhoenixImportMapper.java PRE-CREATION
> src/java/org/apache/sqoop/phoenix/PhoenixConstants.java PRE-CREATION
> src/java/org/apache/sqoop/phoenix/PhoenixSqoopWritable.java PRE-CREATION
> src/java/org/apache/sqoop/phoenix/PhoenixUtil.java PRE-CREATION
> src/java/org/apache/sqoop/tool/BaseSqoopTool.java 50dd67d
> src/java/org/apache/sqoop/tool/ImportTool.java ad1d48b
> src/test/org/apache/sqoop/phoenix/PhoenixBaseTestCase.java PRE-CREATION
> src/test/org/apache/sqoop/phoenix/PhoenixBasicImportTest.java PRE-CREATION
> src/test/org/apache/sqoop/phoenix/PhoenixBulkImportTest.java PRE-CREATION
> src/test/org/apache/sqoop/phoenix/PhoenixQueryImportTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42809/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ravi Magham
>
>
Re: Review Request 42809: SQOOP-2649 : Support for importing data onto
Apache Phoenix tables
Posted by Venkat Ranganathan <n....@live.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42809/#review123287
-----------------------------------------------------------
Thanks for working on this. Looking through this, I am trying to make sure we can build (but not have the functionality ) in older versions of hadoop and hbase.
Is it possible to add reflection to identify and fail if the hadoop version and hbase version are not right.
We always have newer capabilities from dependent products used (for example 2.6.0 Hadoop features are used for password alias), but we do reflection in those cases to not disable the building with older versions
Venkat
- Venkat Ranganathan
On March 11, 2016, 10:32 a.m., Ravi Magham wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42809/
> -----------------------------------------------------------
>
> (Updated March 11, 2016, 10:32 a.m.)
>
>
> Review request for Sqoop and Venkat Ranganathan.
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Support for importing data onto Apache Phoenix tables
>
>
> Diffs
> -----
>
> build.xml 97e5502
> ivy.xml d84b88f
> ivy/ivysettings.xml 2920c89
> src/docs/user/import.txt fbb32f5
> src/docs/user/phoenix-args.txt PRE-CREATION
> src/docs/user/phoenix.txt PRE-CREATION
> src/docs/user/validation.txt 27a78e2
> src/java/org/apache/sqoop/SqoopOptions.java 17751c7
> src/java/org/apache/sqoop/manager/ConnManager.java 1811ce0
> src/java/org/apache/sqoop/manager/SqlManager.java 768507b
> src/java/org/apache/sqoop/mapreduce/ImportJobBase.java 9b6e1a0
> src/java/org/apache/sqoop/mapreduce/PhoenixBulkImportJob.java PRE-CREATION
> src/java/org/apache/sqoop/mapreduce/PhoenixBulkImportMapper.java PRE-CREATION
> src/java/org/apache/sqoop/mapreduce/PhoenixImportJob.java PRE-CREATION
> src/java/org/apache/sqoop/mapreduce/PhoenixImportMapper.java PRE-CREATION
> src/java/org/apache/sqoop/phoenix/PhoenixConstants.java PRE-CREATION
> src/java/org/apache/sqoop/phoenix/PhoenixSqoopWritable.java PRE-CREATION
> src/java/org/apache/sqoop/phoenix/PhoenixUtil.java PRE-CREATION
> src/java/org/apache/sqoop/tool/BaseSqoopTool.java 50dd67d
> src/java/org/apache/sqoop/tool/ImportTool.java ad1d48b
> src/test/org/apache/sqoop/phoenix/PhoenixBaseTestCase.java PRE-CREATION
> src/test/org/apache/sqoop/phoenix/PhoenixBasicImportTest.java PRE-CREATION
> src/test/org/apache/sqoop/phoenix/PhoenixBulkImportTest.java PRE-CREATION
> src/test/org/apache/sqoop/phoenix/PhoenixQueryImportTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42809/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ravi Magham
>
>
Re: Review Request 42809: SQOOP-2649 : Support for importing data onto
Apache Phoenix tables
Posted by Ravi Magham <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42809/
-----------------------------------------------------------
(Updated April 12, 2016, 7:02 a.m.)
Review request for Sqoop and Venkat Ranganathan.
Changes
-------
Adding HBase 95 configuration property
Repository: sqoop-trunk
Description
-------
Support for importing data onto Apache Phoenix tables
Diffs (updated)
-----
build.xml 97e5502
ivy.xml d84b88f
ivy/ivysettings.xml 2920c89
src/docs/user/import.txt fbb32f5
src/docs/user/phoenix-args.txt PRE-CREATION
src/docs/user/phoenix.txt PRE-CREATION
src/docs/user/validation.txt 27a78e2
src/java/org/apache/sqoop/SqoopOptions.java ff96280
src/java/org/apache/sqoop/manager/ConnManager.java 1811ce0
src/java/org/apache/sqoop/manager/SqlManager.java 768507b
src/java/org/apache/sqoop/mapreduce/ImportJobBase.java 9b6e1a0
src/java/org/apache/sqoop/mapreduce/PhoenixBulkImportJob.java PRE-CREATION
src/java/org/apache/sqoop/mapreduce/PhoenixBulkImportMapper.java PRE-CREATION
src/java/org/apache/sqoop/mapreduce/PhoenixImportJob.java PRE-CREATION
src/java/org/apache/sqoop/mapreduce/PhoenixImportMapper.java PRE-CREATION
src/java/org/apache/sqoop/phoenix/PhoenixConstants.java PRE-CREATION
src/java/org/apache/sqoop/phoenix/PhoenixSqoopWritable.java PRE-CREATION
src/java/org/apache/sqoop/phoenix/PhoenixUtil.java PRE-CREATION
src/java/org/apache/sqoop/tool/BaseSqoopTool.java fecdf43
src/java/org/apache/sqoop/tool/ImportTool.java ff7b822
src/test/org/apache/sqoop/phoenix/PhoenixBaseTestCase.java PRE-CREATION
src/test/org/apache/sqoop/phoenix/PhoenixBasicImportTest.java PRE-CREATION
src/test/org/apache/sqoop/phoenix/PhoenixBulkImportTest.java PRE-CREATION
src/test/org/apache/sqoop/phoenix/PhoenixQueryImportTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/42809/diff/
Testing (updated)
-------
HBase tests fails on various Hadoop and HBase combinations. I notice the same behaviour with or without the patch changes. Below is the list of all combinations I tried and their status is below
ant test -Dthirdparty=true -Dhadoopversion=220 -Dhbaseprofile=98 : working
ant test -Dthirdparty=true -Dhadoopversion=220 -Dhbaseprofile=95 : not working
ant test -Dthirdparty=true -Dhadoopversion=220 -Dhbaseprofile=94 : not working
ant test -Dthirdparty=true -Dhadoopversion=210 -Dhbaseprofile=95 : not working
ant test -Dthirdparty=true -Dhadoopversion=210 -Dhbaseprofile=94 : not working
ant test -Dthirdparty=true -Dhadoopversion=200 -Dhbaseprofile=95 : working
ant test -Dthirdparty=true -Dhadoopversion=200 -Dhbaseprofile=94 : not working
ant test -Dthirdparty=true -Dhadoopversion=23 -Dhbaseprofile=95 : working
ant test -Dthirdparty=true -Dhadoopversion=23 -Dhbaseprofile=94 : working
ant test -Dthirdparty=true -Dhadoopversion=100 -Dhbaseprofile=95 : not working
ant test -Dthirdparty=true -Dhadoopversion=100 -Dhbaseprofile=94 : not working
Thanks,
Ravi Magham
Re: Review Request 42809: SQOOP-2649 : Support for importing data onto
Apache Phoenix tables
Posted by Venkat Ranganathan <n....@live.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42809/#review127484
-----------------------------------------------------------
Ship it!
Fix the identified changes and ship it.
There are two lines with whitespace issues - but I can fix it on commit once the new patch is in
- Venkat Ranganathan
On March 21, 2016, 8:08 p.m., Ravi Magham wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42809/
> -----------------------------------------------------------
>
> (Updated March 21, 2016, 8:08 p.m.)
>
>
> Review request for Sqoop and Venkat Ranganathan.
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Support for importing data onto Apache Phoenix tables
>
>
> Diffs
> -----
>
> build.xml 97e5502
> ivy.xml d84b88f
> ivy/ivysettings.xml 2920c89
> src/docs/user/import.txt fbb32f5
> src/docs/user/phoenix-args.txt PRE-CREATION
> src/docs/user/phoenix.txt PRE-CREATION
> src/docs/user/validation.txt 27a78e2
> src/java/org/apache/sqoop/SqoopOptions.java ff96280
> src/java/org/apache/sqoop/manager/ConnManager.java 1811ce0
> src/java/org/apache/sqoop/manager/SqlManager.java 768507b
> src/java/org/apache/sqoop/mapreduce/ImportJobBase.java 9b6e1a0
> src/java/org/apache/sqoop/mapreduce/PhoenixBulkImportJob.java PRE-CREATION
> src/java/org/apache/sqoop/mapreduce/PhoenixBulkImportMapper.java PRE-CREATION
> src/java/org/apache/sqoop/mapreduce/PhoenixImportJob.java PRE-CREATION
> src/java/org/apache/sqoop/mapreduce/PhoenixImportMapper.java PRE-CREATION
> src/java/org/apache/sqoop/phoenix/PhoenixConstants.java PRE-CREATION
> src/java/org/apache/sqoop/phoenix/PhoenixSqoopWritable.java PRE-CREATION
> src/java/org/apache/sqoop/phoenix/PhoenixUtil.java PRE-CREATION
> src/java/org/apache/sqoop/tool/BaseSqoopTool.java fecdf43
> src/java/org/apache/sqoop/tool/ImportTool.java ff7b822
> src/test/org/apache/sqoop/phoenix/PhoenixBaseTestCase.java PRE-CREATION
> src/test/org/apache/sqoop/phoenix/PhoenixBasicImportTest.java PRE-CREATION
> src/test/org/apache/sqoop/phoenix/PhoenixBulkImportTest.java PRE-CREATION
> src/test/org/apache/sqoop/phoenix/PhoenixQueryImportTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42809/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ravi Magham
>
>
Re: Review Request 42809: SQOOP-2649 : Support for importing data
onto Apache Phoenix tables
Posted by James Taylor <ja...@apache.org>.
I've never heard of anyone using 0.95. It's never been in any distro as far
as I know.
On Mon, Mar 21, 2016 at 9:44 PM, Ravi Magham <ma...@gmail.com>
wrote:
>
>
> > On March 22, 2016, 4:08 a.m., Venkat Ranganathan wrote:
> > > build.xml, line 897
> > > <
> https://reviews.apache.org/r/42809/diff/6/?file=1307692#file1307692line897
> >
> > >
> > > Why do we need this?
>
> This was added as the version of hadoop that is passed to the build script
> should be at a minimum of 210 for Phoenix. I have used these system
> properties in my test cases.
>
>
> > On March 22, 2016, 4:08 a.m., Venkat Ranganathan wrote:
> > > build.xml, line 196
> > > <
> https://reviews.apache.org/r/42809/diff/6/?file=1307692#file1307692line196
> >
> > >
> > > Do we need a profile based mechanism like Accumulo/Hbase/HCat
> etc? I see that 4.6.0 is a later version and may be we need to support
> 4.4.0 also?
>
> I haven't honestly tested with 4.4.0 of phoenix. For now, we can stick
> with 4.6.0 as it is much stable.
>
>
> > On March 22, 2016, 4:08 a.m., Venkat Ranganathan wrote:
> > > build.xml, line 194
> > > <
> https://reviews.apache.org/r/42809/diff/6/?file=1307692#file1307692line194
> >
> > >
> > > Can we add 098 version separately
>
> Sure will do that. Apparently, HBase 098 requires Hadoop 220 . Tests
> aren't successful for previous versions. Is it ok to add a new Hadoop
> profile 220 ?
>
>
> > On March 22, 2016, 4:08 a.m., Venkat Ranganathan wrote:
> > > build.xml, line 101
> > > <
> https://reviews.apache.org/r/42809/diff/6/?file=1307692#file1307692line101
> >
> > >
> > > Is this (0.95 to 0.98) required?
>
> Since the plan is on having both 0.95 and 0.98, I will go ahead and keep
> both.
>
>
> - Ravi
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42809/#review124725
> -----------------------------------------------------------
>
>
> On March 22, 2016, 3:08 a.m., Ravi Magham wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/42809/
> > -----------------------------------------------------------
> >
> > (Updated March 22, 2016, 3:08 a.m.)
> >
> >
> > Review request for Sqoop and Venkat Ranganathan.
> >
> >
> > Repository: sqoop-trunk
> >
> >
> > Description
> > -------
> >
> > Support for importing data onto Apache Phoenix tables
> >
> >
> > Diffs
> > -----
> >
> > build.xml 97e5502
> > ivy.xml d84b88f
> > ivy/ivysettings.xml 2920c89
> > src/docs/user/import.txt fbb32f5
> > src/docs/user/phoenix-args.txt PRE-CREATION
> > src/docs/user/phoenix.txt PRE-CREATION
> > src/docs/user/validation.txt 27a78e2
> > src/java/org/apache/sqoop/SqoopOptions.java ff96280
> > src/java/org/apache/sqoop/manager/ConnManager.java 1811ce0
> > src/java/org/apache/sqoop/manager/SqlManager.java 768507b
> > src/java/org/apache/sqoop/mapreduce/ImportJobBase.java 9b6e1a0
> > src/java/org/apache/sqoop/mapreduce/PhoenixBulkImportJob.java
> PRE-CREATION
> > src/java/org/apache/sqoop/mapreduce/PhoenixBulkImportMapper.java
> PRE-CREATION
> > src/java/org/apache/sqoop/mapreduce/PhoenixImportJob.java PRE-CREATION
> > src/java/org/apache/sqoop/mapreduce/PhoenixImportMapper.java
> PRE-CREATION
> > src/java/org/apache/sqoop/phoenix/PhoenixConstants.java PRE-CREATION
> > src/java/org/apache/sqoop/phoenix/PhoenixSqoopWritable.java
> PRE-CREATION
> > src/java/org/apache/sqoop/phoenix/PhoenixUtil.java PRE-CREATION
> > src/java/org/apache/sqoop/tool/BaseSqoopTool.java fecdf43
> > src/java/org/apache/sqoop/tool/ImportTool.java ff7b822
> > src/test/org/apache/sqoop/phoenix/PhoenixBaseTestCase.java PRE-CREATION
> > src/test/org/apache/sqoop/phoenix/PhoenixBasicImportTest.java
> PRE-CREATION
> > src/test/org/apache/sqoop/phoenix/PhoenixBulkImportTest.java
> PRE-CREATION
> > src/test/org/apache/sqoop/phoenix/PhoenixQueryImportTest.java
> PRE-CREATION
> >
> > Diff: https://reviews.apache.org/r/42809/diff/
> >
> >
> > Testing
> > -------
> >
> >
> > Thanks,
> >
> > Ravi Magham
> >
> >
>
>
Re: Review Request 42809: SQOOP-2649 : Support for importing data onto
Apache Phoenix tables
Posted by Ravi Magham <ma...@gmail.com>.
> On March 22, 2016, 4:08 a.m., Venkat Ranganathan wrote:
> > build.xml, line 897
> > <https://reviews.apache.org/r/42809/diff/6/?file=1307692#file1307692line897>
> >
> > Why do we need this?
This was added as the version of hadoop that is passed to the build script should be at a minimum of 210 for Phoenix. I have used these system properties in my test cases.
> On March 22, 2016, 4:08 a.m., Venkat Ranganathan wrote:
> > build.xml, line 196
> > <https://reviews.apache.org/r/42809/diff/6/?file=1307692#file1307692line196>
> >
> > Do we need a profile based mechanism like Accumulo/Hbase/HCat etc? I see that 4.6.0 is a later version and may be we need to support 4.4.0 also?
I haven't honestly tested with 4.4.0 of phoenix. For now, we can stick with 4.6.0 as it is much stable.
> On March 22, 2016, 4:08 a.m., Venkat Ranganathan wrote:
> > build.xml, line 194
> > <https://reviews.apache.org/r/42809/diff/6/?file=1307692#file1307692line194>
> >
> > Can we add 098 version separately
Sure will do that. Apparently, HBase 098 requires Hadoop 220 . Tests aren't successful for previous versions. Is it ok to add a new Hadoop profile 220 ?
> On March 22, 2016, 4:08 a.m., Venkat Ranganathan wrote:
> > build.xml, line 101
> > <https://reviews.apache.org/r/42809/diff/6/?file=1307692#file1307692line101>
> >
> > Is this (0.95 to 0.98) required?
Since the plan is on having both 0.95 and 0.98, I will go ahead and keep both.
- Ravi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42809/#review124725
-----------------------------------------------------------
On March 22, 2016, 3:08 a.m., Ravi Magham wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42809/
> -----------------------------------------------------------
>
> (Updated March 22, 2016, 3:08 a.m.)
>
>
> Review request for Sqoop and Venkat Ranganathan.
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Support for importing data onto Apache Phoenix tables
>
>
> Diffs
> -----
>
> build.xml 97e5502
> ivy.xml d84b88f
> ivy/ivysettings.xml 2920c89
> src/docs/user/import.txt fbb32f5
> src/docs/user/phoenix-args.txt PRE-CREATION
> src/docs/user/phoenix.txt PRE-CREATION
> src/docs/user/validation.txt 27a78e2
> src/java/org/apache/sqoop/SqoopOptions.java ff96280
> src/java/org/apache/sqoop/manager/ConnManager.java 1811ce0
> src/java/org/apache/sqoop/manager/SqlManager.java 768507b
> src/java/org/apache/sqoop/mapreduce/ImportJobBase.java 9b6e1a0
> src/java/org/apache/sqoop/mapreduce/PhoenixBulkImportJob.java PRE-CREATION
> src/java/org/apache/sqoop/mapreduce/PhoenixBulkImportMapper.java PRE-CREATION
> src/java/org/apache/sqoop/mapreduce/PhoenixImportJob.java PRE-CREATION
> src/java/org/apache/sqoop/mapreduce/PhoenixImportMapper.java PRE-CREATION
> src/java/org/apache/sqoop/phoenix/PhoenixConstants.java PRE-CREATION
> src/java/org/apache/sqoop/phoenix/PhoenixSqoopWritable.java PRE-CREATION
> src/java/org/apache/sqoop/phoenix/PhoenixUtil.java PRE-CREATION
> src/java/org/apache/sqoop/tool/BaseSqoopTool.java fecdf43
> src/java/org/apache/sqoop/tool/ImportTool.java ff7b822
> src/test/org/apache/sqoop/phoenix/PhoenixBaseTestCase.java PRE-CREATION
> src/test/org/apache/sqoop/phoenix/PhoenixBasicImportTest.java PRE-CREATION
> src/test/org/apache/sqoop/phoenix/PhoenixBulkImportTest.java PRE-CREATION
> src/test/org/apache/sqoop/phoenix/PhoenixQueryImportTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42809/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ravi Magham
>
>
Re: Review Request 42809: SQOOP-2649 : Support for importing data onto
Apache Phoenix tables
Posted by Venkat Ranganathan <n....@live.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42809/#review124725
-----------------------------------------------------------
build.xml (line 101)
<https://reviews.apache.org/r/42809/#comment187369>
Is this (0.95 to 0.98) required?
build.xml (line 194)
<https://reviews.apache.org/r/42809/#comment187370>
Can we add 098 version separately
build.xml (line 196)
<https://reviews.apache.org/r/42809/#comment187373>
Do we need a profile based mechanism like Accumulo/Hbase/HCat etc? I see that 4.6.0 is a later version and may be we need to support 4.4.0 also?
build.xml (line 897)
<https://reviews.apache.org/r/42809/#comment187371>
Why do we need this?
- Venkat Ranganathan
On March 21, 2016, 8:08 p.m., Ravi Magham wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42809/
> -----------------------------------------------------------
>
> (Updated March 21, 2016, 8:08 p.m.)
>
>
> Review request for Sqoop and Venkat Ranganathan.
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Support for importing data onto Apache Phoenix tables
>
>
> Diffs
> -----
>
> build.xml 97e5502
> ivy.xml d84b88f
> ivy/ivysettings.xml 2920c89
> src/docs/user/import.txt fbb32f5
> src/docs/user/phoenix-args.txt PRE-CREATION
> src/docs/user/phoenix.txt PRE-CREATION
> src/docs/user/validation.txt 27a78e2
> src/java/org/apache/sqoop/SqoopOptions.java ff96280
> src/java/org/apache/sqoop/manager/ConnManager.java 1811ce0
> src/java/org/apache/sqoop/manager/SqlManager.java 768507b
> src/java/org/apache/sqoop/mapreduce/ImportJobBase.java 9b6e1a0
> src/java/org/apache/sqoop/mapreduce/PhoenixBulkImportJob.java PRE-CREATION
> src/java/org/apache/sqoop/mapreduce/PhoenixBulkImportMapper.java PRE-CREATION
> src/java/org/apache/sqoop/mapreduce/PhoenixImportJob.java PRE-CREATION
> src/java/org/apache/sqoop/mapreduce/PhoenixImportMapper.java PRE-CREATION
> src/java/org/apache/sqoop/phoenix/PhoenixConstants.java PRE-CREATION
> src/java/org/apache/sqoop/phoenix/PhoenixSqoopWritable.java PRE-CREATION
> src/java/org/apache/sqoop/phoenix/PhoenixUtil.java PRE-CREATION
> src/java/org/apache/sqoop/tool/BaseSqoopTool.java fecdf43
> src/java/org/apache/sqoop/tool/ImportTool.java ff7b822
> src/test/org/apache/sqoop/phoenix/PhoenixBaseTestCase.java PRE-CREATION
> src/test/org/apache/sqoop/phoenix/PhoenixBasicImportTest.java PRE-CREATION
> src/test/org/apache/sqoop/phoenix/PhoenixBulkImportTest.java PRE-CREATION
> src/test/org/apache/sqoop/phoenix/PhoenixQueryImportTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42809/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ravi Magham
>
>
Re: Review Request 42809: SQOOP-2649 : Support for importing data onto
Apache Phoenix tables
Posted by Ravi Magham <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42809/
-----------------------------------------------------------
(Updated March 22, 2016, 3:08 a.m.)
Review request for Sqoop and Venkat Ranganathan.
Repository: sqoop-trunk
Description
-------
Support for importing data onto Apache Phoenix tables
Diffs
-----
build.xml 97e5502
ivy.xml d84b88f
ivy/ivysettings.xml 2920c89
src/docs/user/import.txt fbb32f5
src/docs/user/phoenix-args.txt PRE-CREATION
src/docs/user/phoenix.txt PRE-CREATION
src/docs/user/validation.txt 27a78e2
src/java/org/apache/sqoop/SqoopOptions.java ff96280
src/java/org/apache/sqoop/manager/ConnManager.java 1811ce0
src/java/org/apache/sqoop/manager/SqlManager.java 768507b
src/java/org/apache/sqoop/mapreduce/ImportJobBase.java 9b6e1a0
src/java/org/apache/sqoop/mapreduce/PhoenixBulkImportJob.java PRE-CREATION
src/java/org/apache/sqoop/mapreduce/PhoenixBulkImportMapper.java PRE-CREATION
src/java/org/apache/sqoop/mapreduce/PhoenixImportJob.java PRE-CREATION
src/java/org/apache/sqoop/mapreduce/PhoenixImportMapper.java PRE-CREATION
src/java/org/apache/sqoop/phoenix/PhoenixConstants.java PRE-CREATION
src/java/org/apache/sqoop/phoenix/PhoenixSqoopWritable.java PRE-CREATION
src/java/org/apache/sqoop/phoenix/PhoenixUtil.java PRE-CREATION
src/java/org/apache/sqoop/tool/BaseSqoopTool.java fecdf43
src/java/org/apache/sqoop/tool/ImportTool.java ff7b822
src/test/org/apache/sqoop/phoenix/PhoenixBaseTestCase.java PRE-CREATION
src/test/org/apache/sqoop/phoenix/PhoenixBasicImportTest.java PRE-CREATION
src/test/org/apache/sqoop/phoenix/PhoenixBulkImportTest.java PRE-CREATION
src/test/org/apache/sqoop/phoenix/PhoenixQueryImportTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/42809/diff/
Testing
-------
Thanks,
Ravi Magham
Re: Review Request 42809: SQOOP-2649 : Support for importing data onto
Apache Phoenix tables
Posted by Ravi Magham <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42809/
-----------------------------------------------------------
(Updated March 21, 2016, 1:21 a.m.)
Review request for Sqoop and Venkat Ranganathan.
Changes
-------
Minor changes to the tests to ensure phoenix tests run only for hadoop 210 and hbase 098 versions at a minimum.
Repository: sqoop-trunk
Description
-------
Support for importing data onto Apache Phoenix tables
Diffs (updated)
-----
build.xml 97e5502
ivy.xml d84b88f
ivy/ivysettings.xml 2920c89
src/docs/user/import.txt fbb32f5
src/docs/user/phoenix-args.txt PRE-CREATION
src/docs/user/phoenix.txt PRE-CREATION
src/docs/user/validation.txt 27a78e2
src/java/org/apache/sqoop/SqoopOptions.java ff96280
src/java/org/apache/sqoop/manager/ConnManager.java 1811ce0
src/java/org/apache/sqoop/manager/SqlManager.java 768507b
src/java/org/apache/sqoop/mapreduce/ImportJobBase.java 9b6e1a0
src/java/org/apache/sqoop/mapreduce/PhoenixBulkImportJob.java PRE-CREATION
src/java/org/apache/sqoop/mapreduce/PhoenixBulkImportMapper.java PRE-CREATION
src/java/org/apache/sqoop/mapreduce/PhoenixImportJob.java PRE-CREATION
src/java/org/apache/sqoop/mapreduce/PhoenixImportMapper.java PRE-CREATION
src/java/org/apache/sqoop/phoenix/PhoenixConstants.java PRE-CREATION
src/java/org/apache/sqoop/phoenix/PhoenixSqoopWritable.java PRE-CREATION
src/java/org/apache/sqoop/phoenix/PhoenixUtil.java PRE-CREATION
src/java/org/apache/sqoop/tool/BaseSqoopTool.java fecdf43
src/java/org/apache/sqoop/tool/ImportTool.java ff7b822
src/test/org/apache/sqoop/phoenix/PhoenixBaseTestCase.java PRE-CREATION
src/test/org/apache/sqoop/phoenix/PhoenixBasicImportTest.java PRE-CREATION
src/test/org/apache/sqoop/phoenix/PhoenixBulkImportTest.java PRE-CREATION
src/test/org/apache/sqoop/phoenix/PhoenixQueryImportTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/42809/diff/
Testing
-------
Thanks,
Ravi Magham
Re: Review Request 42809: SQOOP-2649 : Support for importing data onto
Apache Phoenix tables
Posted by Ravi Magham <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42809/
-----------------------------------------------------------
(Updated March 11, 2016, 6:32 p.m.)
Review request for Sqoop and Venkat Ranganathan.
Changes
-------
I have attached the patch that applied cleanly on the trunk.
Ran the tests using ant test -Dthirdparty=true -Dhadoopversion=210 -Dhbaseprofile=98
Repository: sqoop-trunk
Description
-------
Support for importing data onto Apache Phoenix tables
Diffs (updated)
-----
build.xml 97e5502
ivy.xml d84b88f
ivy/ivysettings.xml 2920c89
src/docs/user/import.txt fbb32f5
src/docs/user/phoenix-args.txt PRE-CREATION
src/docs/user/phoenix.txt PRE-CREATION
src/docs/user/validation.txt 27a78e2
src/java/org/apache/sqoop/SqoopOptions.java 17751c7
src/java/org/apache/sqoop/manager/ConnManager.java 1811ce0
src/java/org/apache/sqoop/manager/SqlManager.java 768507b
src/java/org/apache/sqoop/mapreduce/ImportJobBase.java 9b6e1a0
src/java/org/apache/sqoop/mapreduce/PhoenixBulkImportJob.java PRE-CREATION
src/java/org/apache/sqoop/mapreduce/PhoenixBulkImportMapper.java PRE-CREATION
src/java/org/apache/sqoop/mapreduce/PhoenixImportJob.java PRE-CREATION
src/java/org/apache/sqoop/mapreduce/PhoenixImportMapper.java PRE-CREATION
src/java/org/apache/sqoop/phoenix/PhoenixConstants.java PRE-CREATION
src/java/org/apache/sqoop/phoenix/PhoenixSqoopWritable.java PRE-CREATION
src/java/org/apache/sqoop/phoenix/PhoenixUtil.java PRE-CREATION
src/java/org/apache/sqoop/tool/BaseSqoopTool.java 50dd67d
src/java/org/apache/sqoop/tool/ImportTool.java ad1d48b
src/test/org/apache/sqoop/phoenix/PhoenixBaseTestCase.java PRE-CREATION
src/test/org/apache/sqoop/phoenix/PhoenixBasicImportTest.java PRE-CREATION
src/test/org/apache/sqoop/phoenix/PhoenixBulkImportTest.java PRE-CREATION
src/test/org/apache/sqoop/phoenix/PhoenixQueryImportTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/42809/diff/
Testing
-------
Thanks,
Ravi Magham
Re: Review Request 42809: SQOOP-2649 : Support for importing data onto
Apache Phoenix tables
Posted by Ravi Magham <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42809/
-----------------------------------------------------------
(Updated March 6, 2016, 5:43 a.m.)
Review request for Sqoop and Venkat Ranganathan.
Changes
-------
Fixes to formatting issues.
Repository: sqoop-trunk
Description
-------
Support for importing data onto Apache Phoenix tables
Diffs (updated)
-----
build.xml d614d09
ivy.xml a93d0af
ivy/ivysettings.xml 2920c89
src/docs/user/import.txt df04157
src/docs/user/phoenix-args.txt PRE-CREATION
src/docs/user/phoenix.txt PRE-CREATION
src/docs/user/validation.txt 27a78e2
src/java/org/apache/sqoop/SqoopOptions.java ef6e0ce
src/java/org/apache/sqoop/manager/ConnManager.java d9569c5
src/java/org/apache/sqoop/manager/SqlManager.java ead581d
src/java/org/apache/sqoop/mapreduce/ImportJobBase.java 04d60fd
src/java/org/apache/sqoop/mapreduce/PhoenixBulkImportJob.java PRE-CREATION
src/java/org/apache/sqoop/mapreduce/PhoenixBulkImportMapper.java PRE-CREATION
src/java/org/apache/sqoop/mapreduce/PhoenixImportJob.java PRE-CREATION
src/java/org/apache/sqoop/mapreduce/PhoenixImportMapper.java PRE-CREATION
src/java/org/apache/sqoop/phoenix/PhoenixConstants.java PRE-CREATION
src/java/org/apache/sqoop/phoenix/PhoenixSqoopWritable.java PRE-CREATION
src/java/org/apache/sqoop/phoenix/PhoenixUtil.java PRE-CREATION
src/java/org/apache/sqoop/tool/BaseSqoopTool.java c97bb58
src/java/org/apache/sqoop/tool/ImportTool.java c79e044
src/test/org/apache/sqoop/phoenix/PhoenixBaseTestCase.java PRE-CREATION
src/test/org/apache/sqoop/phoenix/PhoenixBasicImportTest.java PRE-CREATION
src/test/org/apache/sqoop/phoenix/PhoenixBulkImportTest.java PRE-CREATION
src/test/org/apache/sqoop/phoenix/PhoenixQueryImportTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/42809/diff/
Testing
-------
Thanks,
Ravi Magham
Re: Review Request 42809: SQOOP-2649 : Support for importing data onto
Apache Phoenix tables
Posted by Venkat Ranganathan <n....@live.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42809/#review120024
-----------------------------------------------------------
Thanks for doing this. If you look at the RB patch, there are lots of lines with tabs and a few with trailing spaces. Can you please fix them and upload. It is probably your IDE that is causing this. Please check your IDE settings
Thanks
src/java/org/apache/sqoop/SqoopOptions.java (line 2454)
<https://reviews.apache.org/r/42809/#comment181384>
Tabs instead of spaces
src/java/org/apache/sqoop/manager/SqlManager.java (line 674)
<https://reviews.apache.org/r/42809/#comment181385>
Tabs instead of spaces - trailing spaces
src/java/org/apache/sqoop/mapreduce/PhoenixBulkImportJob.java (line 66)
<https://reviews.apache.org/r/42809/#comment181386>
Tabs instead of spaces
- Venkat Ranganathan
On Feb. 13, 2016, 4:11 p.m., Ravi Magham wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42809/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2016, 4:11 p.m.)
>
>
> Review request for Sqoop and Venkat Ranganathan.
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Support for importing data onto Apache Phoenix tables
>
>
> Diffs
> -----
>
> build.xml d614d09
> ivy.xml a93d0af
> ivy/ivysettings.xml 2920c89
> src/docs/user/import.txt df04157
> src/docs/user/phoenix-args.txt PRE-CREATION
> src/docs/user/phoenix.txt PRE-CREATION
> src/docs/user/validation.txt 27a78e2
> src/java/org/apache/sqoop/SqoopOptions.java ef6e0ce
> src/java/org/apache/sqoop/manager/ConnManager.java d9569c5
> src/java/org/apache/sqoop/manager/SqlManager.java ead581d
> src/java/org/apache/sqoop/mapreduce/ImportJobBase.java 04d60fd
> src/java/org/apache/sqoop/mapreduce/PhoenixBulkImportJob.java PRE-CREATION
> src/java/org/apache/sqoop/mapreduce/PhoenixBulkImportMapper.java PRE-CREATION
> src/java/org/apache/sqoop/mapreduce/PhoenixImportJob.java PRE-CREATION
> src/java/org/apache/sqoop/mapreduce/PhoenixImportMapper.java PRE-CREATION
> src/java/org/apache/sqoop/phoenix/PhoenixConstants.java PRE-CREATION
> src/java/org/apache/sqoop/phoenix/PhoenixSqoopWritable.java PRE-CREATION
> src/java/org/apache/sqoop/phoenix/PhoenixUtil.java PRE-CREATION
> src/java/org/apache/sqoop/tool/BaseSqoopTool.java c97bb58
> src/java/org/apache/sqoop/tool/ImportTool.java c79e044
> src/test/org/apache/sqoop/phoenix/PhoenixBaseTestCase.java PRE-CREATION
> src/test/org/apache/sqoop/phoenix/PhoenixBasicImportTest.java PRE-CREATION
> src/test/org/apache/sqoop/phoenix/PhoenixBulkImportTest.java PRE-CREATION
> src/test/org/apache/sqoop/phoenix/PhoenixQueryImportTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42809/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ravi Magham
>
>
Re: Review Request 42809: SQOOP-2649 : Support for importing data onto
Apache Phoenix tables
Posted by Ravi Magham <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42809/
-----------------------------------------------------------
(Updated Feb. 14, 2016, 12:11 a.m.)
Review request for Sqoop and Venkat Ranganathan.
Changes
-------
Updates to review comments.
Repository: sqoop-trunk
Description
-------
Support for importing data onto Apache Phoenix tables
Diffs (updated)
-----
build.xml d614d09
ivy.xml a93d0af
ivy/ivysettings.xml 2920c89
src/docs/user/import.txt df04157
src/docs/user/phoenix-args.txt PRE-CREATION
src/docs/user/phoenix.txt PRE-CREATION
src/docs/user/validation.txt 27a78e2
src/java/org/apache/sqoop/SqoopOptions.java ef6e0ce
src/java/org/apache/sqoop/manager/ConnManager.java d9569c5
src/java/org/apache/sqoop/manager/SqlManager.java ead581d
src/java/org/apache/sqoop/mapreduce/ImportJobBase.java 04d60fd
src/java/org/apache/sqoop/mapreduce/PhoenixBulkImportJob.java PRE-CREATION
src/java/org/apache/sqoop/mapreduce/PhoenixBulkImportMapper.java PRE-CREATION
src/java/org/apache/sqoop/mapreduce/PhoenixImportJob.java PRE-CREATION
src/java/org/apache/sqoop/mapreduce/PhoenixImportMapper.java PRE-CREATION
src/java/org/apache/sqoop/phoenix/PhoenixConstants.java PRE-CREATION
src/java/org/apache/sqoop/phoenix/PhoenixSqoopWritable.java PRE-CREATION
src/java/org/apache/sqoop/phoenix/PhoenixUtil.java PRE-CREATION
src/java/org/apache/sqoop/tool/BaseSqoopTool.java c97bb58
src/java/org/apache/sqoop/tool/ImportTool.java c79e044
src/test/org/apache/sqoop/phoenix/PhoenixBaseTestCase.java PRE-CREATION
src/test/org/apache/sqoop/phoenix/PhoenixBasicImportTest.java PRE-CREATION
src/test/org/apache/sqoop/phoenix/PhoenixBulkImportTest.java PRE-CREATION
src/test/org/apache/sqoop/phoenix/PhoenixQueryImportTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/42809/diff/
Testing
-------
Thanks,
Ravi Magham
Re: Review Request 42809: SQOOP-2649 : Support for importing data onto
Apache Phoenix tables
Posted by Ravi Magham <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42809/
-----------------------------------------------------------
(Updated Feb. 1, 2016, 8:49 a.m.)
Review request for Sqoop and Venkat Ranganathan.
Changes
-------
Updates to the patch based on Venkat review comments.
Repository: sqoop-trunk
Description
-------
Support for importing data onto Apache Phoenix tables
Diffs (updated)
-----
build.xml d614d09
ivy.xml a93d0af
ivy/ivysettings.xml 2920c89
src/docs/user/import.txt df04157
src/docs/user/phoenix-args.txt PRE-CREATION
src/docs/user/phoenix.txt PRE-CREATION
src/docs/user/validation.txt 27a78e2
src/java/org/apache/sqoop/SqoopOptions.java ef6e0ce
src/java/org/apache/sqoop/manager/ConnManager.java d9569c5
src/java/org/apache/sqoop/manager/SqlManager.java ead581d
src/java/org/apache/sqoop/mapreduce/ImportJobBase.java 04d60fd
src/java/org/apache/sqoop/mapreduce/PhoenixBulkImportJob.java PRE-CREATION
src/java/org/apache/sqoop/mapreduce/PhoenixBulkImportMapper.java PRE-CREATION
src/java/org/apache/sqoop/mapreduce/PhoenixImportJob.java PRE-CREATION
src/java/org/apache/sqoop/mapreduce/PhoenixImportMapper.java PRE-CREATION
src/java/org/apache/sqoop/phoenix/PhoenixConstants.java PRE-CREATION
src/java/org/apache/sqoop/phoenix/PhoenixSqoopWritable.java PRE-CREATION
src/java/org/apache/sqoop/phoenix/PhoenixUtil.java PRE-CREATION
src/java/org/apache/sqoop/tool/BaseSqoopTool.java c97bb58
src/java/org/apache/sqoop/tool/ImportTool.java c79e044
src/test/org/apache/sqoop/phoenix/PhoenixBaseTestCase.java PRE-CREATION
src/test/org/apache/sqoop/phoenix/PhoenixBasicImportTest.java PRE-CREATION
src/test/org/apache/sqoop/phoenix/PhoenixBulkImportTest.java PRE-CREATION
src/test/org/apache/sqoop/phoenix/PhoenixQueryImportTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/42809/diff/
Testing
-------
Thanks,
Ravi Magham