You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/21 14:17:40 UTC
[GitHub] [apisix-ingress-controller] tokers opened a new pull request #122: chore: hone e2e test scaffold and make the first case passed.
tokers opened a new pull request #122:
URL: https://github.com/apache/apisix-ingress-controller/pull/122
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #122: chore: hone e2e test scaffold and run cases in CI
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #122:
URL: https://github.com/apache/apisix-ingress-controller/pull/122#issuecomment-748997502
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=h1) Report
> Merging [#122](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=desc) (d35d130) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/ef552b8ba799c907f9205a7952b28a7b42286d37?el=desc) (ef552b8) will **increase** coverage by `1.31%`.
> The diff coverage is `62.96%`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #122 +/- ##
==========================================
+ Coverage 60.53% 61.84% +1.31%
==========================================
Files 16 17 +1
Lines 527 574 +47
==========================================
+ Hits 319 355 +36
- Misses 184 190 +6
- Partials 24 29 +5
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [test/e2e/e2e.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122/diff?src=pr&el=tree#diff-dGVzdC9lMmUvZTJlLmdv) | `62.96% <62.96%> (ø)` | |
| [pkg/api/router/router.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122/diff?src=pr&el=tree#diff-cGtnL2FwaS9yb3V0ZXIvcm91dGVyLmdv) | `75.00% <0.00%> (-5.00%)` | :arrow_down: |
| [cmd/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122/diff?src=pr&el=tree#diff-Y21kL2luZ3Jlc3MvaW5ncmVzcy5nbw==) | `77.38% <0.00%> (+2.71%)` | :arrow_up: |
| [pkg/api/server.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122/diff?src=pr&el=tree#diff-cGtnL2FwaS9zZXJ2ZXIuZ28=) | `74.07% <0.00%> (+10.91%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=footer). Last update [ef552b8...d35d130](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #122: chore: hone e2e test scaffold and run cases in CI
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #122:
URL: https://github.com/apache/apisix-ingress-controller/pull/122#issuecomment-748997502
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=h1) Report
> Merging [#122](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=desc) (2b0bfc3) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/ef552b8ba799c907f9205a7952b28a7b42286d37?el=desc) (ef552b8) will **increase** coverage by `0.66%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #122 +/- ##
==========================================
+ Coverage 60.53% 61.19% +0.66%
==========================================
Files 16 16
Lines 527 536 +9
==========================================
+ Hits 319 328 +9
Misses 184 184
Partials 24 24
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cmd/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122/diff?src=pr&el=tree#diff-Y21kL2luZ3Jlc3MvaW5ncmVzcy5nbw==) | `77.38% <0.00%> (+2.71%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=footer). Last update [ef552b8...2b0bfc3](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #122: chore: hone e2e test scaffold and run cases in CI
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #122:
URL: https://github.com/apache/apisix-ingress-controller/pull/122#discussion_r548530216
##########
File path: Makefile
##########
@@ -48,6 +49,14 @@ gofmt:
unit-test:
go test -cover -coverprofile=coverage.txt ./...
+### e2e-test: Run e2e test cases
+e2e-test:
+ export APISIX_ROUTE_DEF=$(PWD)/samples/deploy/crd/v1beta1/ApisixRoute.yaml && \
+ export APISIX_UPSTREAM_DEF=$(PWD)/samples/deploy/crd/v1beta1/ApisixUpstream.yaml && \
+ export APISIX_SERVICE_DEF=$(PWD)/samples/deploy/crd/v1beta1/ApisixService.yaml && \
+ export APISIX_TLS_DEF=$(PWD)/samples/deploy/crd/v1beta1/ApisixTls.yaml && \
+ cd test/e2e && go test github.com/api7/ingress-controller/test/e2e
Review comment:
Fixed.
##########
File path: .github/workflows/e2e-test-ci.yml
##########
@@ -0,0 +1,33 @@
+name: e2e-test-ci
+
+on:
+ push:
+ branches:
+ - master
+ pull_request:
+ branches:
+ - master
+ - test/e2e-sanity-case
+jobs:
+ e2e-test:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v2
+ - name: Install minikube
+ uses: abstractj/setup-minikube@issue-12
+ - name: Output cluster info
+ run: kubectl cluster-info
+ - name: Add images
+ run: |
+ minikube cache add apache/apisix:latest -v 7 --alsologtostderr
+ minikube cache add bitnami/etcd:3.4.14-debian-10-r0 -v 7 --alsologtostderr
+ minikube cache add kennethreitz/httpbin -v 7 --alsologtostderr
+ minikube cache add viewking/apisix-ingress-controller:dev -v 7 --alsologtostderr
Review comment:
Fixed.
##########
File path: test/e2e/testdata/apisix-gw-config-default.yaml
##########
@@ -59,6 +59,7 @@ apisix:
allow_admin: # http://nginx.org/en/docs/http/ngx_http_access_module.html#allow
- 127.0.0.0/24 # If we don't set any IP list, then any IP access is allowed by default.
+ - 0.0.0.0/0
Review comment:
Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on pull request #122: chore: hone e2e test scaffold and run cases in CI
Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #122:
URL: https://github.com/apache/apisix-ingress-controller/pull/122#issuecomment-751140359
@membphis Please take a look when you have time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #122: chore: hone e2e test scaffold and run cases in CI
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #122:
URL: https://github.com/apache/apisix-ingress-controller/pull/122#issuecomment-748997502
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=h1) Report
> Merging [#122](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=desc) (a534139) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/ef552b8ba799c907f9205a7952b28a7b42286d37?el=desc) (ef552b8) will **increase** coverage by `0.66%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #122 +/- ##
==========================================
+ Coverage 60.53% 61.19% +0.66%
==========================================
Files 16 16
Lines 527 536 +9
==========================================
+ Hits 319 328 +9
Misses 184 184
Partials 24 24
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cmd/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122/diff?src=pr&el=tree#diff-Y21kL2luZ3Jlc3MvaW5ncmVzcy5nbw==) | `77.38% <0.00%> (+2.71%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=footer). Last update [ef552b8...a534139](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #122: chore: hone e2e test scaffold and run cases in CI
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #122:
URL: https://github.com/apache/apisix-ingress-controller/pull/122#issuecomment-748997502
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=h1) Report
> Merging [#122](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=desc) (e6cfa5c) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/ef552b8ba799c907f9205a7952b28a7b42286d37?el=desc) (ef552b8) will **increase** coverage by `0.66%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #122 +/- ##
==========================================
+ Coverage 60.53% 61.19% +0.66%
==========================================
Files 16 16
Lines 527 536 +9
==========================================
+ Hits 319 328 +9
Misses 184 184
Partials 24 24
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cmd/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122/diff?src=pr&el=tree#diff-Y21kL2luZ3Jlc3MvaW5ncmVzcy5nbw==) | `77.38% <0.00%> (+2.71%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=footer). Last update [ef552b8...e6cfa5c](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #122: chore: hone e2e test scaffold and run cases in CI
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #122:
URL: https://github.com/apache/apisix-ingress-controller/pull/122#discussion_r548513795
##########
File path: Makefile
##########
@@ -48,6 +49,14 @@ gofmt:
unit-test:
go test -cover -coverprofile=coverage.txt ./...
+### e2e-test: Run e2e test cases
+e2e-test:
+ export APISIX_ROUTE_DEF=$(PWD)/samples/deploy/crd/v1beta1/ApisixRoute.yaml && \
+ export APISIX_UPSTREAM_DEF=$(PWD)/samples/deploy/crd/v1beta1/ApisixUpstream.yaml && \
+ export APISIX_SERVICE_DEF=$(PWD)/samples/deploy/crd/v1beta1/ApisixService.yaml && \
+ export APISIX_TLS_DEF=$(PWD)/samples/deploy/crd/v1beta1/ApisixTls.yaml && \
+ cd test/e2e && go test github.com/api7/ingress-controller/test/e2e
Review comment:
It only calculates the code coverage of package test/e2e, not our ingress controller.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #122: chore: hone e2e test scaffold and run cases in CI
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #122:
URL: https://github.com/apache/apisix-ingress-controller/pull/122#issuecomment-748997502
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=h1) Report
> Merging [#122](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=desc) (2eafc22) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/ef552b8ba799c907f9205a7952b28a7b42286d37?el=desc) (ef552b8) will **increase** coverage by `0.66%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #122 +/- ##
==========================================
+ Coverage 60.53% 61.19% +0.66%
==========================================
Files 16 16
Lines 527 536 +9
==========================================
+ Hits 319 328 +9
Misses 184 184
Partials 24 24
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cmd/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122/diff?src=pr&el=tree#diff-Y21kL2luZ3Jlc3MvaW5ncmVzcy5nbw==) | `77.38% <0.00%> (+2.71%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=footer). Last update [ef552b8...8a0209a](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] moonming merged pull request #122: chore: hone e2e test scaffold and run cases in CI
Posted by GitBox <gi...@apache.org>.
moonming merged pull request #122:
URL: https://github.com/apache/apisix-ingress-controller/pull/122
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #122: chore: hone e2e test scaffold and run cases in CI
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #122:
URL: https://github.com/apache/apisix-ingress-controller/pull/122#discussion_r548451582
##########
File path: Makefile
##########
@@ -48,6 +49,14 @@ gofmt:
unit-test:
go test -cover -coverprofile=coverage.txt ./...
+### e2e-test: Run e2e test cases
+e2e-test:
+ export APISIX_ROUTE_DEF=$(PWD)/samples/deploy/crd/v1beta1/ApisixRoute.yaml && \
+ export APISIX_UPSTREAM_DEF=$(PWD)/samples/deploy/crd/v1beta1/ApisixUpstream.yaml && \
+ export APISIX_SERVICE_DEF=$(PWD)/samples/deploy/crd/v1beta1/ApisixService.yaml && \
+ export APISIX_TLS_DEF=$(PWD)/samples/deploy/crd/v1beta1/ApisixTls.yaml && \
+ cd test/e2e && go test github.com/api7/ingress-controller/test/e2e
Review comment:
We can add test coverage here .
##########
File path: test/e2e/ingress/sanity.go
##########
@@ -0,0 +1,62 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+package ingress
+
+import (
+ "encoding/json"
+ "net/http"
+
+ "github.com/onsi/ginkgo"
+ "github.com/stretchr/testify/assert"
+
+ "github.com/api7/ingress-controller/test/e2e/scaffold"
+)
+
+type ip struct {
+ IP string `json:"ip"`
+}
+
+var _ = ginkgo.Describe("single-route", func() {
+ s := scaffold.NewDefaultScaffold()
+ ginkgo.It("/ip should return your ip", func() {
+ backendSvc, backendSvcPort := s.DefaultHTTPBackend()
+ s.CreateApisixRoute("httpbin-route", []scaffold.ApisixRouteRule{
+ {
+ Host: "httpbin.com",
+ HTTP: scaffold.ApisixRouteRuleHTTP{
+ Paths: []scaffold.ApisixRouteRuleHTTPPath{
+ {
+ Path: "/ip",
+ Backend: scaffold.ApisixRouteRuleHTTPBackend{
+ ServiceName: backendSvc,
+ ServicePort: backendSvcPort[0],
+ },
+ },
+ },
+ },
+ },
+ })
Review comment:
I think we need to use yaml to manage the creation of `ApisixRoute`, In this way, we can simulate the user's usage scenario test conversion process.
This is an enhancement and will not block PR .
##########
File path: test/e2e/testdata/apisix-gw-config-default.yaml
##########
@@ -59,6 +59,7 @@ apisix:
allow_admin: # http://nginx.org/en/docs/http/ngx_http_access_module.html#allow
- 127.0.0.0/24 # If we don't set any IP list, then any IP access is allowed by default.
+ - 0.0.0.0/0
Review comment:
Should remove this. Had add this in `test/e2e/testdata/apisix-gw-config.yaml` already.
##########
File path: .github/workflows/e2e-test-ci.yml
##########
@@ -0,0 +1,33 @@
+name: e2e-test-ci
+
+on:
+ push:
+ branches:
+ - master
+ pull_request:
+ branches:
+ - master
+ - test/e2e-sanity-case
+jobs:
+ e2e-test:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v2
+ - name: Install minikube
+ uses: abstractj/setup-minikube@issue-12
+ - name: Output cluster info
+ run: kubectl cluster-info
+ - name: Add images
+ run: |
+ minikube cache add apache/apisix:latest -v 7 --alsologtostderr
+ minikube cache add bitnami/etcd:3.4.14-debian-10-r0 -v 7 --alsologtostderr
+ minikube cache add kennethreitz/httpbin -v 7 --alsologtostderr
+ minikube cache add viewking/apisix-ingress-controller:dev -v 7 --alsologtostderr
Review comment:
Why adding `viewking/apisix-ingress-controller:dev` cache ?
Do we need to deploy `apisix-ingress-controller`in minikube ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #122: chore: hone e2e test scaffold and make the first case passed.
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #122:
URL: https://github.com/apache/apisix-ingress-controller/pull/122#issuecomment-748997502
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=h1) Report
> Merging [#122](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=desc) (a99083e) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/ef552b8ba799c907f9205a7952b28a7b42286d37?el=desc) (ef552b8) will **increase** coverage by `0.66%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #122 +/- ##
==========================================
+ Coverage 60.53% 61.19% +0.66%
==========================================
Files 16 16
Lines 527 536 +9
==========================================
+ Hits 319 328 +9
Misses 184 184
Partials 24 24
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cmd/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122/diff?src=pr&el=tree#diff-Y21kL2luZ3Jlc3MvaW5ncmVzcy5nbw==) | `77.38% <0.00%> (+2.71%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=footer). Last update [ef552b8...a99083e](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #122: chore: hone e2e test scaffold and run cases in CI
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #122:
URL: https://github.com/apache/apisix-ingress-controller/pull/122#issuecomment-748997502
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=h1) Report
> Merging [#122](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=desc) (265f835) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/ef552b8ba799c907f9205a7952b28a7b42286d37?el=desc) (ef552b8) will **increase** coverage by `0.69%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #122 +/- ##
==========================================
+ Coverage 60.53% 61.22% +0.69%
==========================================
Files 16 16
Lines 527 539 +12
==========================================
+ Hits 319 330 +11
- Misses 184 185 +1
Partials 24 24
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/api/router/router.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122/diff?src=pr&el=tree#diff-cGtnL2FwaS9yb3V0ZXIvcm91dGVyLmdv) | `75.00% <0.00%> (-5.00%)` | :arrow_down: |
| [cmd/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122/diff?src=pr&el=tree#diff-Y21kL2luZ3Jlc3MvaW5ncmVzcy5nbw==) | `77.38% <0.00%> (+2.71%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=footer). Last update [ef552b8...265f835](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #122: chore: hone e2e test scaffold and run cases in CI
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #122:
URL: https://github.com/apache/apisix-ingress-controller/pull/122#issuecomment-748997502
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=h1) Report
> Merging [#122](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=desc) (de2d8cd) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/ef552b8ba799c907f9205a7952b28a7b42286d37?el=desc) (ef552b8) will **increase** coverage by `0.69%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #122 +/- ##
==========================================
+ Coverage 60.53% 61.22% +0.69%
==========================================
Files 16 16
Lines 527 539 +12
==========================================
+ Hits 319 330 +11
- Misses 184 185 +1
Partials 24 24
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/api/router/router.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122/diff?src=pr&el=tree#diff-cGtnL2FwaS9yb3V0ZXIvcm91dGVyLmdv) | `75.00% <0.00%> (-5.00%)` | :arrow_down: |
| [cmd/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122/diff?src=pr&el=tree#diff-Y21kL2luZ3Jlc3MvaW5ncmVzcy5nbw==) | `77.38% <0.00%> (+2.71%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=footer). Last update [ef552b8...de2d8cd](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #122: chore: hone e2e test scaffold and run cases in CI
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #122:
URL: https://github.com/apache/apisix-ingress-controller/pull/122#discussion_r548514124
##########
File path: test/e2e/testdata/apisix-gw-config-default.yaml
##########
@@ -59,6 +59,7 @@ apisix:
allow_admin: # http://nginx.org/en/docs/http/ngx_http_access_module.html#allow
- 127.0.0.0/24 # If we don't set any IP list, then any IP access is allowed by default.
+ - 0.0.0.0/0
Review comment:
OK.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #122: chore: hone e2e test scaffold and run cases in CI
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #122:
URL: https://github.com/apache/apisix-ingress-controller/pull/122#issuecomment-748997502
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=h1) Report
> Merging [#122](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=desc) (8a0209a) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/ef552b8ba799c907f9205a7952b28a7b42286d37?el=desc) (ef552b8) will **increase** coverage by `0.66%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #122 +/- ##
==========================================
+ Coverage 60.53% 61.19% +0.66%
==========================================
Files 16 16
Lines 527 536 +9
==========================================
+ Hits 319 328 +9
Misses 184 184
Partials 24 24
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cmd/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122/diff?src=pr&el=tree#diff-Y21kL2luZ3Jlc3MvaW5ncmVzcy5nbw==) | `77.38% <0.00%> (+2.71%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=footer). Last update [ef552b8...8a0209a](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #122: chore: hone e2e test scaffold and run cases in CI
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #122:
URL: https://github.com/apache/apisix-ingress-controller/pull/122#discussion_r548513978
##########
File path: .github/workflows/e2e-test-ci.yml
##########
@@ -0,0 +1,33 @@
+name: e2e-test-ci
+
+on:
+ push:
+ branches:
+ - master
+ pull_request:
+ branches:
+ - master
+ - test/e2e-sanity-case
+jobs:
+ e2e-test:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v2
+ - name: Install minikube
+ uses: abstractj/setup-minikube@issue-12
+ - name: Output cluster info
+ run: kubectl cluster-info
+ - name: Add images
+ run: |
+ minikube cache add apache/apisix:latest -v 7 --alsologtostderr
+ minikube cache add bitnami/etcd:3.4.14-debian-10-r0 -v 7 --alsologtostderr
+ minikube cache add kennethreitz/httpbin -v 7 --alsologtostderr
+ minikube cache add viewking/apisix-ingress-controller:dev -v 7 --alsologtostderr
Review comment:
Oops, it seems i made a mistake here, we should build ingress-controller image each time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #122: chore: hone e2e test scaffold and run cases in CI
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #122:
URL: https://github.com/apache/apisix-ingress-controller/pull/122#discussion_r548514638
##########
File path: Makefile
##########
@@ -48,6 +49,14 @@ gofmt:
unit-test:
go test -cover -coverprofile=coverage.txt ./...
+### e2e-test: Run e2e test cases
+e2e-test:
+ export APISIX_ROUTE_DEF=$(PWD)/samples/deploy/crd/v1beta1/ApisixRoute.yaml && \
+ export APISIX_UPSTREAM_DEF=$(PWD)/samples/deploy/crd/v1beta1/ApisixUpstream.yaml && \
+ export APISIX_SERVICE_DEF=$(PWD)/samples/deploy/crd/v1beta1/ApisixService.yaml && \
+ export APISIX_TLS_DEF=$(PWD)/samples/deploy/crd/v1beta1/ApisixTls.yaml && \
+ cd test/e2e && go test github.com/api7/ingress-controller/test/e2e
Review comment:
Yes, we need to calculates code coverage for e2e and UT separately .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #122: chore: hone e2e test scaffold and make the first case passed.
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #122:
URL: https://github.com/apache/apisix-ingress-controller/pull/122#issuecomment-748997502
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=h1) Report
> Merging [#122](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=desc) (25a2bf1) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/ef552b8ba799c907f9205a7952b28a7b42286d37?el=desc) (ef552b8) will **increase** coverage by `0.66%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #122 +/- ##
==========================================
+ Coverage 60.53% 61.19% +0.66%
==========================================
Files 16 16
Lines 527 536 +9
==========================================
+ Hits 319 328 +9
Misses 184 184
Partials 24 24
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cmd/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122/diff?src=pr&el=tree#diff-Y21kL2luZ3Jlc3MvaW5ncmVzcy5nbw==) | `77.38% <0.00%> (+2.71%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=footer). Last update [ef552b8...25a2bf1](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #122: chore: hone e2e test scaffold and run cases in CI
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #122:
URL: https://github.com/apache/apisix-ingress-controller/pull/122#issuecomment-748997502
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=h1) Report
> Merging [#122](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=desc) (bd32084) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/ef552b8ba799c907f9205a7952b28a7b42286d37?el=desc) (ef552b8) will **increase** coverage by `0.83%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #122 +/- ##
==========================================
+ Coverage 60.53% 61.36% +0.83%
==========================================
Files 16 16
Lines 527 541 +14
==========================================
+ Hits 319 332 +13
- Misses 184 185 +1
Partials 24 24
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/api/router/router.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122/diff?src=pr&el=tree#diff-cGtnL2FwaS9yb3V0ZXIvcm91dGVyLmdv) | `80.00% <0.00%> (ø)` | |
| [cmd/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122/diff?src=pr&el=tree#diff-Y21kL2luZ3Jlc3MvaW5ncmVzcy5nbw==) | `77.38% <0.00%> (+2.71%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=footer). Last update [ef552b8...bd32084](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #122: chore: hone e2e test scaffold and run cases in CI
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #122:
URL: https://github.com/apache/apisix-ingress-controller/pull/122#issuecomment-748997502
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=h1) Report
> Merging [#122](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=desc) (d35d130) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/ef552b8ba799c907f9205a7952b28a7b42286d37?el=desc) (ef552b8) will **increase** coverage by `1.26%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #122 +/- ##
==========================================
+ Coverage 60.53% 61.79% +1.26%
==========================================
Files 16 16
Lines 527 547 +20
==========================================
+ Hits 319 338 +19
- Misses 184 185 +1
Partials 24 24
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/api/router/router.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122/diff?src=pr&el=tree#diff-cGtnL2FwaS9yb3V0ZXIvcm91dGVyLmdv) | `75.00% <0.00%> (-5.00%)` | :arrow_down: |
| [cmd/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122/diff?src=pr&el=tree#diff-Y21kL2luZ3Jlc3MvaW5ncmVzcy5nbw==) | `77.38% <0.00%> (+2.71%)` | :arrow_up: |
| [pkg/api/server.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122/diff?src=pr&el=tree#diff-cGtnL2FwaS9zZXJ2ZXIuZ28=) | `74.07% <0.00%> (+10.91%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=footer). Last update [ef552b8...d35d130](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #122: chore: hone e2e test scaffold and make the first case passed.
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #122:
URL: https://github.com/apache/apisix-ingress-controller/pull/122#issuecomment-748997502
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=h1) Report
> Merging [#122](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=desc) (ceecf43) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/ef552b8ba799c907f9205a7952b28a7b42286d37?el=desc) (ef552b8) will **increase** coverage by `0.66%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #122 +/- ##
==========================================
+ Coverage 60.53% 61.19% +0.66%
==========================================
Files 16 16
Lines 527 536 +9
==========================================
+ Hits 319 328 +9
Misses 184 184
Partials 24 24
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cmd/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122/diff?src=pr&el=tree#diff-Y21kL2luZ3Jlc3MvaW5ncmVzcy5nbw==) | `77.38% <0.00%> (+2.71%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=footer). Last update [ef552b8...ceecf43](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #122: chore: hone e2e test scaffold and run cases in CI
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #122:
URL: https://github.com/apache/apisix-ingress-controller/pull/122#issuecomment-748997502
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=h1) Report
> Merging [#122](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=desc) (705a9f1) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/ef552b8ba799c907f9205a7952b28a7b42286d37?el=desc) (ef552b8) will **increase** coverage by `1.26%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #122 +/- ##
==========================================
+ Coverage 60.53% 61.79% +1.26%
==========================================
Files 16 16
Lines 527 547 +20
==========================================
+ Hits 319 338 +19
- Misses 184 185 +1
Partials 24 24
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/api/router/router.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122/diff?src=pr&el=tree#diff-cGtnL2FwaS9yb3V0ZXIvcm91dGVyLmdv) | `75.00% <0.00%> (-5.00%)` | :arrow_down: |
| [cmd/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122/diff?src=pr&el=tree#diff-Y21kL2luZ3Jlc3MvaW5ncmVzcy5nbw==) | `77.38% <0.00%> (+2.71%)` | :arrow_up: |
| [pkg/api/server.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122/diff?src=pr&el=tree#diff-cGtnL2FwaS9zZXJ2ZXIuZ28=) | `74.07% <0.00%> (+10.91%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=footer). Last update [ef552b8...705a9f1](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #122: chore: hone e2e test scaffold and run cases in CI
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #122:
URL: https://github.com/apache/apisix-ingress-controller/pull/122#issuecomment-748997502
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=h1) Report
> Merging [#122](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=desc) (de2d8cd) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/ef552b8ba799c907f9205a7952b28a7b42286d37?el=desc) (ef552b8) will **increase** coverage by `0.69%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #122 +/- ##
==========================================
+ Coverage 60.53% 61.22% +0.69%
==========================================
Files 16 16
Lines 527 539 +12
==========================================
+ Hits 319 330 +11
- Misses 184 185 +1
Partials 24 24
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/api/router/router.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122/diff?src=pr&el=tree#diff-cGtnL2FwaS9yb3V0ZXIvcm91dGVyLmdv) | `75.00% <0.00%> (-5.00%)` | :arrow_down: |
| [cmd/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122/diff?src=pr&el=tree#diff-Y21kL2luZ3Jlc3MvaW5ncmVzcy5nbw==) | `77.38% <0.00%> (+2.71%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=footer). Last update [ef552b8...de2d8cd](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #122: chore: hone e2e test scaffold and run cases in CI
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #122:
URL: https://github.com/apache/apisix-ingress-controller/pull/122#issuecomment-748997502
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=h1) Report
> Merging [#122](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=desc) (bd32084) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/ef552b8ba799c907f9205a7952b28a7b42286d37?el=desc) (ef552b8) will **increase** coverage by `0.66%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #122 +/- ##
==========================================
+ Coverage 60.53% 61.19% +0.66%
==========================================
Files 16 16
Lines 527 536 +9
==========================================
+ Hits 319 328 +9
Misses 184 184
Partials 24 24
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cmd/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122/diff?src=pr&el=tree#diff-Y21kL2luZ3Jlc3MvaW5ncmVzcy5nbw==) | `77.38% <0.00%> (+2.71%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=footer). Last update [ef552b8...bd32084](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org